From 32da55ef5bc92a3b12daf35ee2c87b42c805aa3f Mon Sep 17 00:00:00 2001 From: Lioncache Date: Wed, 3 Dec 2025 15:49:17 -0500 Subject: [PATCH] CCollisionRenderSettingsDialog: Reduce copies --- src/Editor/WorldEditor/CCollisionRenderSettingsDialog.cpp | 4 ++-- src/Editor/WorldEditor/CCollisionRenderSettingsDialog.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.cpp b/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.cpp index 5ce11133..9c5426b6 100644 --- a/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.cpp +++ b/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.cpp @@ -63,14 +63,14 @@ void CCollisionRenderSettingsDialog::SetupWidgets() mpUi->HideAiBlockCheckBox->setHidden( Game < EGame::EchoesDemo || Game == EGame::DKCReturns ); } -void CCollisionRenderSettingsDialog::OnHideMaskChanged(QString NewMask) +void CCollisionRenderSettingsDialog::OnHideMaskChanged(const QString& NewMask) { TString MaskStr = TO_TSTRING(NewMask); uint64 Mask = (MaskStr.IsHexString() ? MaskStr.ToInt64(16) : 0); mpEditor->Viewport()->CollisionRenderSettings().HideMask = Mask; } -void CCollisionRenderSettingsDialog::OnHighlightMaskChanged(QString NewMask) +void CCollisionRenderSettingsDialog::OnHighlightMaskChanged(const QString& NewMask) { TString MaskStr = TO_TSTRING(NewMask); uint64 Mask = (MaskStr.IsHexString() ? MaskStr.ToInt64(16) : 0); diff --git a/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.h b/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.h index 7162001b..6b5eac07 100644 --- a/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.h +++ b/src/Editor/WorldEditor/CCollisionRenderSettingsDialog.h @@ -23,8 +23,8 @@ public: public slots: void SetupWidgets(); - void OnHideMaskChanged(QString NewMask); - void OnHighlightMaskChanged(QString NewMask); + void OnHideMaskChanged(const QString& NewMask); + void OnHighlightMaskChanged(const QString& NewMask); void OnWireframeToggled(bool Enable); void OnSurfaceTypeToggled(bool Enable); void OnStandableTrisToggled(bool Enable);