From 70c3d7d68cdc8303c4b5f6b0cab8c04423a658fd Mon Sep 17 00:00:00 2001 From: Lioncache Date: Tue, 2 Dec 2025 21:23:05 -0500 Subject: [PATCH] CNodeSelection: Avoid copy churning We can return via const reference to avoid making redundant copies of QLists. --- src/Editor/CNodeSelection.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Editor/CNodeSelection.h b/src/Editor/CNodeSelection.h index d19b8ed4..afb5e6a7 100644 --- a/src/Editor/CNodeSelection.h +++ b/src/Editor/CNodeSelection.h @@ -109,17 +109,17 @@ public: return mCachedBounds; } - uint32 Size() const { return mSelectedNodes.size(); } - bool IsEmpty() const { return Size() == 0; } - CSceneNode* At(uint32 Index) const { return mSelectedNodes[Index]; } - CSceneNode* Front() const { return mSelectedNodes.front(); } - CSceneNode* Back() const { return mSelectedNodes.back(); } - CSceneNode* operator[](uint32 Index) const { return mSelectedNodes[Index]; } - void UpdateBounds() { mBoundsDirty = true; } - void SetAllowedNodeTypes(FNodeFlags Types) { mAllowedNodes = Types; } - bool IsAllowedType(ENodeType Type) const { return (mAllowedNodes & Type) != 0; } - bool IsAllowedType(CSceneNode *pNode) const { return (mAllowedNodes & pNode->NodeType()) != 0; } - QList SelectedNodeList() const { return mSelectedNodes; } + uint32 Size() const { return mSelectedNodes.size(); } + bool IsEmpty() const { return Size() == 0; } + CSceneNode* At(uint32 Index) const { return mSelectedNodes[Index]; } + CSceneNode* Front() const { return mSelectedNodes.front(); } + CSceneNode* Back() const { return mSelectedNodes.back(); } + CSceneNode* operator[](uint32 Index) const { return mSelectedNodes[Index]; } + void UpdateBounds() { mBoundsDirty = true; } + void SetAllowedNodeTypes(FNodeFlags Types) { mAllowedNodes = Types; } + bool IsAllowedType(ENodeType Type) const { return (mAllowedNodes & Type) != 0; } + bool IsAllowedType(CSceneNode *pNode) const { return (mAllowedNodes & pNode->NodeType()) != 0; } + const QList& SelectedNodeList() const { return mSelectedNodes; } signals: void Modified();