From 901ae6a83257286d68302001ef84d8b87fd36d8a Mon Sep 17 00:00:00 2001 From: parax0 Date: Tue, 24 Nov 2015 08:40:09 -0700 Subject: [PATCH] Minor TString cleanup (also enable log terminal output in release mode) --- Common/TString.h | 7 ++----- Core/Log.cpp | 8 +------- Core/main.cpp | 1 - 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/Common/TString.h b/Common/TString.h index cbd61d48..661df530 100644 --- a/Common/TString.h +++ b/Common/TString.h @@ -72,11 +72,6 @@ public: { } - // Forward declares of some static functions that are handy for internal use - //static bool CompareCStrings(const CharType*, const CharType*); - //static u32 CStringLength(const CharType*); - //static bool IsWhitespace(CharType); - // Data Accessors inline const CharType* CString() const { @@ -198,6 +193,7 @@ public: _TString ToUpper() const { + // todo: doesn't handle accented characters _TString out(Size()); for (u32 iChar = 0; iChar < Size(); iChar++) @@ -215,6 +211,7 @@ public: _TString ToLower() const { + // todo: doesn't handle accented characters _TString out(Size()); for (u32 iChar = 0; iChar < Size(); iChar++) diff --git a/Core/Log.cpp b/Core/Log.cpp index 0951bbd8..72b9bc02 100644 --- a/Core/Log.cpp +++ b/Core/Log.cpp @@ -34,19 +34,13 @@ void Write(const TString& message) void Error(const TString& message) { Write("ERROR: " + message); - -#ifdef _DEBUG - std::cout << "ERROR: " << message << "\n"; -#endif + std::cout << "ERROR: " << message << "\n"; } void Warning(const TString& message) { Write("Warning: " + message); - -#ifdef _DEBUG std::cout << "Warning: " << message << "\n"; -#endif } void FileWrite(const TString& filename, const TString& message) diff --git a/Core/main.cpp b/Core/main.cpp index f43d9d7a..ed346897 100644 --- a/Core/main.cpp +++ b/Core/main.cpp @@ -3,7 +3,6 @@ #include #include #include -#include int main(int argc, char *argv[]) {