From 919820bdf7485dccbaa0c942aff04c4eec68be2e Mon Sep 17 00:00:00 2001 From: Lioncache Date: Sun, 7 Dec 2025 02:32:49 -0500 Subject: [PATCH] ICreateDeleteDirectoryCommand: std::move strings where applicable Same behavior without churning allocations. --- src/Editor/Undo/ICreateDeleteDirectoryCommand.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Editor/Undo/ICreateDeleteDirectoryCommand.h b/src/Editor/Undo/ICreateDeleteDirectoryCommand.h index ca1a01c5..e6f59b0e 100644 --- a/src/Editor/Undo/ICreateDeleteDirectoryCommand.h +++ b/src/Editor/Undo/ICreateDeleteDirectoryCommand.h @@ -21,8 +21,8 @@ public: ICreateDeleteDirectoryCommand(const QString& rkText, CResourceStore *pStore, TString ParentPath, TString DirName) : IUndoCommand(rkText) , mpStore(pStore) - , mParentPath(ParentPath) - , mDirName(DirName) + , mParentPath(std::move(ParentPath)) + , mDirName(std::move(DirName)) , mpDir(nullptr) {} @@ -66,7 +66,7 @@ class CCreateDirectoryCommand : public ICreateDeleteDirectoryCommand { public: CCreateDirectoryCommand(CResourceStore *pStore, TString ParentPath, TString DirName) - : ICreateDeleteDirectoryCommand(QCoreApplication::translate("CCreateDirectoryCommand", "Create Directory"), pStore, ParentPath, DirName) + : ICreateDeleteDirectoryCommand(QCoreApplication::translate("CCreateDirectoryCommand", "Create Directory"), pStore, std::move(ParentPath), std::move(DirName)) {} void undo() override { DoDelete(); } @@ -77,9 +77,9 @@ class CDeleteDirectoryCommand : public ICreateDeleteDirectoryCommand { public: CDeleteDirectoryCommand(CResourceStore *pStore, TString ParentPath, TString DirName) - : ICreateDeleteDirectoryCommand(QCoreApplication::translate("CDeleteDirectoryCommand", "Delete Directory"), pStore, ParentPath, DirName) + : ICreateDeleteDirectoryCommand(QCoreApplication::translate("CDeleteDirectoryCommand", "Delete Directory"), pStore, std::move(ParentPath), std::move(DirName)) { - mpDir = pStore->GetVirtualDirectory(ParentPath + DirName, false); + mpDir = pStore->GetVirtualDirectory(mParentPath + mDirName, false); ASSERT(mpDir); ASSERT(!mpDir->IsRoot()); }