From ad1b285e2b64822c097bc2fe125f4bd70906998b Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 28 Jun 2020 06:02:15 -0400 Subject: [PATCH] CStringListModel: Make use of in-class initializers where applicable --- src/Editor/StringEditor/CStringListModel.cpp | 1 - src/Editor/StringEditor/CStringListModel.h | 20 ++++++++++---------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/Editor/StringEditor/CStringListModel.cpp b/src/Editor/StringEditor/CStringListModel.cpp index 0d191a1d..42b8bb15 100644 --- a/src/Editor/StringEditor/CStringListModel.cpp +++ b/src/Editor/StringEditor/CStringListModel.cpp @@ -9,7 +9,6 @@ CStringListModel::CStringListModel(CStringEditor* pInEditor) : QAbstractListModel(pInEditor) , mpEditor(pInEditor) , mpStringTable(pInEditor->StringTable()) - , mStringPreviewLanguage(ELanguage::English) { } diff --git a/src/Editor/StringEditor/CStringListModel.h b/src/Editor/StringEditor/CStringListModel.h index 0e22508f..7ea2cfb2 100644 --- a/src/Editor/StringEditor/CStringListModel.h +++ b/src/Editor/StringEditor/CStringListModel.h @@ -17,25 +17,25 @@ class CStringListModel : public QAbstractListModel TResPtr mpStringTable; /** Language to use for the string preview for modes that support it */ - ELanguage mStringPreviewLanguage; + ELanguage mStringPreviewLanguage{ELanguage::English}; public: - CStringListModel(CStringEditor* pInEditor); + explicit CStringListModel(CStringEditor* pInEditor); /** Change the preview language display */ void SetPreviewLanguage(ELanguage InLanguage); /** QAbstractListModel interface */ - virtual int rowCount(const QModelIndex& kParent) const override; - virtual QVariant data(const QModelIndex& kIndex, int Role) const override; - virtual Qt::ItemFlags flags(const QModelIndex& kIndex) const override; + int rowCount(const QModelIndex& kParent) const override; + QVariant data(const QModelIndex& kIndex, int Role) const override; + Qt::ItemFlags flags(const QModelIndex& kIndex) const override; /** Drag & Drop support */ - virtual Qt::DropActions supportedDragActions() const override; - virtual Qt::DropActions supportedDropActions() const override; - virtual QMimeData* mimeData(const QModelIndexList& kIndexes) const override; - virtual bool canDropMimeData(const QMimeData* pkData, Qt::DropAction Action, int Row, int Column, const QModelIndex& kParent) const override; - virtual bool dropMimeData(const QMimeData* pkData, Qt::DropAction Action, int Row, int Column, const QModelIndex& kParent) override; + Qt::DropActions supportedDragActions() const override; + Qt::DropActions supportedDropActions() const override; + QMimeData* mimeData(const QModelIndexList& kIndexes) const override; + bool canDropMimeData(const QMimeData* pkData, Qt::DropAction Action, int Row, int Column, const QModelIndex& kParent) const override; + bool dropMimeData(const QMimeData* pkData, Qt::DropAction Action, int Row, int Column, const QModelIndex& kParent) override; }; #endif // CSTRINGLISTMODEL_H