From b13ebc56bbd4d1b457075e5afbe71419f9709095 Mon Sep 17 00:00:00 2001
From: Lioncache <mai.iam2048@gmail.com>
Date: Wed, 3 Dec 2025 15:34:48 -0500
Subject: [PATCH] CProgressDialog: Remove redundant future copies

We can pass by reference here.
---
 src/Editor/CProgressDialog.cpp | 2 +-
 src/Editor/CProgressDialog.h   | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Editor/CProgressDialog.cpp b/src/Editor/CProgressDialog.cpp
index d4bf7b83..4b0d3ae6 100644
--- a/src/Editor/CProgressDialog.cpp
+++ b/src/Editor/CProgressDialog.cpp
@@ -3,7 +3,7 @@
 #include "CEditorApplication.h"
 #include <QCloseEvent>
 
-CProgressDialog::CProgressDialog(QString OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent)
+CProgressDialog::CProgressDialog(const QString& OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent)
     : IProgressNotifierUI(pParent)
     , mpUI(std::make_unique<Ui::CProgressDialog>())
     , mUseBusyIndicator(UseBusyIndicator)
diff --git a/src/Editor/CProgressDialog.h b/src/Editor/CProgressDialog.h
index e0b8a0e8..8e481513 100644
--- a/src/Editor/CProgressDialog.h
+++ b/src/Editor/CProgressDialog.h
@@ -26,7 +26,7 @@ class CProgressDialog : public IProgressNotifierUI
     bool mCanceled = false;
 
 public:
-    explicit CProgressDialog(QString OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent = nullptr);
+    explicit CProgressDialog(const QString& OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent = nullptr);
     ~CProgressDialog() override;
 
     void DisallowCanceling();
@@ -44,7 +44,7 @@ public slots:
     // Results
 protected:
     template<typename RetType>
-    void InternalWaitForResults(QFuture<RetType> Future)
+    void InternalWaitForResults(const QFuture<RetType>& Future)
     {
         gpEdApp->SetEditorTicksEnabled(false);
 
@@ -61,7 +61,7 @@ protected:
 
 public:
     template<typename RetType>
-    RetType WaitForResults(QFuture<RetType> Future)
+    RetType WaitForResults(const QFuture<RetType>& Future)
     {
         InternalWaitForResults(Future);
         return Future.result();
@@ -69,7 +69,7 @@ public:
 };
 
 template<>
-inline void CProgressDialog::WaitForResults(QFuture<void> Future)
+inline void CProgressDialog::WaitForResults(const QFuture<void>& Future)
 {
     InternalWaitForResults(Future);
 }