From e7a2a10d646eebc7cd90beb86bf56a239db325ab Mon Sep 17 00:00:00 2001
From: Lioncache <mai.iam2048@gmail.com>
Date: Sun, 7 Dec 2025 08:08:04 -0500
Subject: [PATCH] CSelectInstanceDialog: Pass QModelIndex by const reference

Gets rid of a few trivial 24 byte copies.
---
 src/Editor/WorldEditor/CSelectInstanceDialog.cpp | 11 +++++------
 src/Editor/WorldEditor/CSelectInstanceDialog.h   |  4 ++--
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/Editor/WorldEditor/CSelectInstanceDialog.cpp b/src/Editor/WorldEditor/CSelectInstanceDialog.cpp
index 00eaaef6..505e98bf 100644
--- a/src/Editor/WorldEditor/CSelectInstanceDialog.cpp
+++ b/src/Editor/WorldEditor/CSelectInstanceDialog.cpp
@@ -60,20 +60,19 @@ void CSelectInstanceDialog::OnTabChanged(int NewTabIndex)
     ui->ButtonBox->button(QDialogButtonBox::Ok)->setEnabled(mValidSelection);
 }
 
-void CSelectInstanceDialog::OnTreeClicked(QModelIndex Index)
+void CSelectInstanceDialog::OnTreeClicked(const QModelIndex& Index)
 {
-    int TabIndex = ui->TabWidget->currentIndex();
+    const int TabIndex = ui->TabWidget->currentIndex();
 
     if (TabIndex == 0)
     {
-        QModelIndex SourceIndex = mLayersProxyModel.mapToSource(Index);
+        const QModelIndex SourceIndex = mLayersProxyModel.mapToSource(Index);
         mpLayersInst = mLayersModel.IndexObject(SourceIndex);
         mValidSelection = (mpLayersInst != nullptr);
     }
-
     else
     {
-        QModelIndex SourceIndex = mTypesProxyModel.mapToSource(Index);
+        const QModelIndex SourceIndex = mTypesProxyModel.mapToSource(Index);
         mpTypesInst = mTypesModel.IndexObject(SourceIndex);
         mValidSelection = (mpTypesInst != nullptr);
     }
@@ -81,7 +80,7 @@ void CSelectInstanceDialog::OnTreeClicked(QModelIndex Index)
     ui->ButtonBox->button(QDialogButtonBox::Ok)->setEnabled(mValidSelection);
 }
 
-void CSelectInstanceDialog::OnTreeDoubleClicked(QModelIndex /*Index*/)
+void CSelectInstanceDialog::OnTreeDoubleClicked(const QModelIndex& /*Index*/)
 {
     // Instance selection was handled in OnTreeClicked on the first click.
     if (mValidSelection)
diff --git a/src/Editor/WorldEditor/CSelectInstanceDialog.h b/src/Editor/WorldEditor/CSelectInstanceDialog.h
index 7190d39c..c13d9a82 100644
--- a/src/Editor/WorldEditor/CSelectInstanceDialog.h
+++ b/src/Editor/WorldEditor/CSelectInstanceDialog.h
@@ -36,8 +36,8 @@ public:
 
 public slots:
     void OnTabChanged(int NewTabIndex);
-    void OnTreeClicked(QModelIndex Index);
-    void OnTreeDoubleClicked(QModelIndex Index);
+    void OnTreeClicked(const QModelIndex& Index);
+    void OnTreeDoubleClicked(const QModelIndex& Index);
 };
 
 #endif // CSELECTINSTANCEDIALOG_H