From f34886a76e0b31a1fda43abc1eaf6e5d17f6cdad Mon Sep 17 00:00:00 2001 From: Lioncache Date: Wed, 3 Dec 2025 15:43:19 -0500 Subject: [PATCH] CSelectResourcePanel: Elide copies where applicable We can just pass by const reference. --- src/Editor/Widgets/CSelectResourcePanel.cpp | 4 ++-- src/Editor/Widgets/CSelectResourcePanel.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Editor/Widgets/CSelectResourcePanel.cpp b/src/Editor/Widgets/CSelectResourcePanel.cpp index ec61760c..eda4315f 100644 --- a/src/Editor/Widgets/CSelectResourcePanel.cpp +++ b/src/Editor/Widgets/CSelectResourcePanel.cpp @@ -79,12 +79,12 @@ void CSelectResourcePanel::FocusChanged(QWidget*, QWidget *pNew) deleteLater(); } -void CSelectResourcePanel::SearchStringChanged(QString SearchString) +void CSelectResourcePanel::SearchStringChanged(const QString& SearchString) { mProxyModel.SetSearchString(SearchString); } -void CSelectResourcePanel::ResourceClicked(QModelIndex Index) +void CSelectResourcePanel::ResourceClicked(const QModelIndex& Index) { QModelIndex SourceIndex = mProxyModel.mapToSource(Index); CResourceEntry *pEntry = mModel.EntryForIndex(SourceIndex); diff --git a/src/Editor/Widgets/CSelectResourcePanel.h b/src/Editor/Widgets/CSelectResourcePanel.h index d81590cc..8b9c9819 100644 --- a/src/Editor/Widgets/CSelectResourcePanel.h +++ b/src/Editor/Widgets/CSelectResourcePanel.h @@ -26,8 +26,8 @@ public: public slots: void FocusChanged(QWidget *pOld, QWidget *pNew); - void SearchStringChanged(QString SearchString); - void ResourceClicked(QModelIndex Index); + void SearchStringChanged(const QString& SearchString); + void ResourceClicked(const QModelIndex& Index); }; #endif // CSELECTRESOURCEPANEL_H