Lioncache
a85bbd3e49
CResourceBrowser: Pass strings by const reference in signals
...
Allows slots to avoid copies where applicable.
2025-12-07 02:37:54 -05:00
Lioncache
919820bdf7
ICreateDeleteDirectoryCommand: std::move strings where applicable
...
Same behavior without churning allocations.
2025-12-07 02:32:51 -05:00
Lioncache
f577335087
Editor/Undo: Mark relevant variables as maybe unused
...
Prevents potential warnings on release mode.
2025-12-07 02:30:04 -05:00
Lioncache
deb1aaae01
CVirtualDirectoryModel: Mark Found variable as [[maybe_unused]]
...
This can technically be unused on release builds.
2025-12-07 02:26:08 -05:00
Lioncache
5ff96c750b
Editor/CWorldEditor: Eliminate redundant copies
2025-12-07 02:25:24 -05:00
Lioncache
051d0ec50b
Editor/CPropertyModel: std::move font instance
...
Avoids making a full copy of the font.
2025-12-07 02:08:54 -05:00
Lioncache
25c45b2b28
CSceneNode: Make use of structured bindings in RayAABoxIntersectTest()
...
Same thing, but lets the returned values have more self-explanatory
names.
2025-12-06 18:31:34 -05:00
Lioncache
4914ccdc22
CAnimSetLoader: Make use of designated initializes + reserve where applicable
...
Simplifies some declarations, and overall reduces allocation churning.
2025-12-06 18:07:39 -05:00
Lioncache
04f31acc71
CAudioGroupLoader: Reserve audio lookup table elements beforehand
...
Potentially reduces repeated reallocations.
2025-12-06 17:50:24 -05:00
Lioncache
335816af03
CFlagsProperty: Default comparison operators
...
Same behavior, less code.
2025-12-06 17:36:05 -05:00
Lioncache
5d35a14538
CEnumProperty: Default comparison operators
...
Same behavior, less code.
2025-12-06 17:35:39 -05:00
Lioncache
55ed25023b
CResourceEntry: Mark bool as maybe unused
...
This can be considered unused in release builds
2025-12-06 17:22:36 -05:00
Lioncache
172f450b84
CArrayProperty: Make Use of defaulted comparisons
...
Same behavior, less code.
2025-12-06 17:22:02 -05:00
Lioncache
f093c3d552
Core/AssetNameGeneration: Mark assert variables as maybe unused
...
These may be considered unused in release builds.
2025-12-06 17:12:57 -05:00
Lioncache
5241a3e7a1
CGameExporter: Use string construction over .data() passthrough
...
This way the string will take into the account the total size of the
string view instead of effectively running strlen() over the pointer,
allowing non-null-terminated strings to properly work.
2025-12-06 17:02:08 -05:00
Lioncache
d0270402fe
Core: Make use of contains() where applicable
...
Makes a few checks a little less verbose.
2025-12-06 16:37:31 -05:00
Lioncache
a98f856342
CResourceProxyModel: Add missing includes
2025-12-03 17:41:13 -05:00
Lioncache
d75f017522
CModelEditorWindow: Reduce string churn
...
We can just pass by reference.
2025-12-03 17:25:37 -05:00
Lioncache
379fd472ed
CResourceTableModel: Get rid of unnecessary parameter copies
2025-12-03 17:06:56 -05:00
Lioncache
478060ce75
CollisionRenderSettingsDialog: Validate hex inputs
...
This way we don't have a case where incorrect values are implicitly
converted to the error value of zero (i.e. we shouldn't even accept
bogus strings like "0xzzz")
Not the most ideal UX, but this is still better than not doing anything
about it.
2025-12-03 17:02:15 -05:00
Lioncache
454d9b3ee2
CCollisionRenderSettingsDialog: Simplify hex string handling
...
We can do all of this handling within Qt without needing TStrings
2025-12-03 16:03:39 -05:00
Lioncache
32da55ef5b
CCollisionRenderSettingsDialog: Reduce copies
2025-12-03 15:49:17 -05:00
Lioncache
f34886a76e
CSelectResourcePanel: Elide copies where applicable
...
We can just pass by const reference.
2025-12-03 15:43:22 -05:00
Lioncache
b13ebc56bb
CProgressDialog: Remove redundant future copies
...
We can pass by reference here.
2025-12-03 15:38:47 -05:00
Lioncache
449798b16c
Editor: Mark functions internally linked where applicable
2025-12-03 10:41:35 -05:00
Lioncache
c010e0e7cb
IEditor: Eliminate variable shadowing
2025-12-03 10:34:37 -05:00
Lioncache
faffce9c97
CExportGameDialog: Eliminate variable shadowing
2025-12-03 10:09:18 -05:00
Lioncache
e0f33910d3
CExportGameDialog: Remove uses of string_view .data()
...
We can use safer methods here by using the bounded size.
2025-12-03 10:06:19 -05:00
Lioncache
4067d9ec9f
main: Remove deprecated Hi-DPI attributes
...
Turns out these are always enabled, so there's no need to specify them
explicitly.
2025-12-03 09:57:28 -05:00
Lioncache
8270cf4a2b
CSceneViewport: Use non-deprecated variant of QMouseEvent
2025-12-03 09:54:37 -05:00
Lioncache
1f877cd761
CCharacterEditor: Remove redundant animation access
...
We can just use the retrieved animation the first time.
2025-12-03 08:07:43 -05:00
Lioncache
5cf54f4bca
CBasicViewport: Remove unnecessary casts
2025-12-03 07:51:09 -05:00
Lioncache
397c3554e8
CStateMessageModel: Move SEntry name
...
Allows for eliminating a redundant copy
2025-12-02 23:18:30 -05:00
Lioncache
70c3d7d68c
CNodeSelection: Avoid copy churning
...
We can return via const reference to avoid making redundant copies of
QLists.
2025-12-02 23:00:01 -05:00
Lioncache
64b38a1358
CSceneViewport: Move node list in OnSelectConnected()
...
Gets rid of unnecessary copying.
2025-12-02 22:59:48 -05:00
Lioncache
ea47abb3ca
CResourceTableModel: Make parent directory signifier untranslatable
...
There's basically no reason to allow translation of this.
2025-12-02 22:59:35 -05:00
Lioncache
2e4ddea65b
CResourceBrowser: Allow navigating directories with the Enter keys
...
Previously the resource browser required you to double click on
everything in order to interact with it (going into directories, or
launching handlers for particular files, etc).
This is kinda stinky workflow-wise long-term when flipping between
assets; so we can make the interface a little less mouse-centric by
allowing the use of the enter keys to also perform the same behavior.
2025-12-02 22:59:08 -05:00
Lioncache
137bed91d8
INodeEditor: Mark strings as literals
2025-12-02 22:58:50 -05:00
Lioncache
d768118cdc
CBasicViewport: Map arrow keys to WSAD
...
Just provides straightforward left-handed analogs on the other side of the keyboard
for moving the viewport camera.
2025-12-02 22:58:27 -05:00
Lioncache
2e2ca40596
Main: Remove now unnecessary version check
...
Since we require Qt 6 now, we can just make this code unconditional.
2025-12-01 16:17:55 -05:00
Lioncache
2419b11b45
Editor: Disable implicit Qt string conversions
...
Requires that our format conversions be explicit.
2025-12-01 16:08:27 -05:00
Lioncache
5fc6b50923
Editor: Mark remaining undo command strings as translatable
...
Ensures that we're marking the remnant potential display strings
properly.
2025-12-01 14:38:30 -05:00
Lioncache
db7e832f32
Editor: Update to C++23
...
Track the latest standard instead of being stuck on C++17.
2025-12-01 01:51:47 -05:00
Lioncache
fbddb3f7be
CMakeLists: Silence unavoidable warnings on MSVC
2025-11-30 23:06:21 -05:00
Lioncache
682290c8d1
externals: Update LibCommon
...
Tracks the latest commit to make use of tinyxml2 11.0.0 instead of 7.0.0
2025-11-30 17:33:00 -05:00
Lioncache
e4637a75c4
dewfile: Update tinyxml2 from 7.0.0 to 11.0.0
...
7.0.0 is around 7 years old, so we should be tracking a more up to date
version. This also makes the library compatible with CMake 4.0+
2025-11-30 17:02:11 -05:00
Lioncache
dc393c6415
dewfile: Update zlib from 1.2.11 to 1.3.1
...
In addition to API improvements and security fixes, this also makes zlib
buildable using CMake 4.0+, since it removes backwards compatibility for
older CMake versions.
2025-11-30 16:51:39 -05:00
Lioncache
3dc25217a1
CPasteNodesCommand: Make use of unique_ptr
...
Same behavior, but simplified allocation handling.
2025-11-30 16:45:31 -05:00
Lioncache
43eae548ac
Editor: Convert QVector over to QList
...
In Qt 6 QVector is now a typedef alias for QList, so we can convert these over
to make the semantics explicit.
2025-11-30 15:44:23 -05:00
Lioncache
0e56aa3fa8
CEditorApplication: Remove wonky closing parenthesis in package cooking dialog
...
This just looks out of place (and is a remnant from the translation
string changes).
2025-11-30 15:19:29 -05:00