From 1b37122b12f95b26b86150b069407208a94310ed Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 10 Sep 2019 20:08:36 -0400 Subject: [PATCH] Sequencer: std::move studio instances in constructor Avoids an unnecessary atomic reference count increment and decrement --- lib/Sequencer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Sequencer.cpp b/lib/Sequencer.cpp index c8c289b..d82ac17 100644 --- a/lib/Sequencer.cpp +++ b/lib/Sequencer.cpp @@ -53,7 +53,7 @@ Sequencer::~Sequencer() { Sequencer::Sequencer(Engine& engine, const AudioGroup& group, GroupId groupId, const SongGroupIndex* songGroup, SongId setupId, ObjToken studio) -: Entity(engine, group, groupId), m_songGroup(songGroup), m_studio(studio) { +: Entity(engine, group, groupId), m_songGroup(songGroup), m_studio(std::move(studio)) { auto it = m_songGroup->m_midiSetups.find(setupId); if (it != m_songGroup->m_midiSetups.cend()) m_midiSetup = it->second.data(); @@ -61,7 +61,7 @@ Sequencer::Sequencer(Engine& engine, const AudioGroup& group, GroupId groupId, c Sequencer::Sequencer(Engine& engine, const AudioGroup& group, GroupId groupId, const SFXGroupIndex* sfxGroup, ObjToken studio) -: Entity(engine, group, groupId), m_sfxGroup(sfxGroup), m_studio(studio) { +: Entity(engine, group, groupId), m_sfxGroup(sfxGroup), m_studio(std::move(studio)) { std::map sortSFX; for (const auto& sfx : sfxGroup->m_sfxEntries) sortSFX[sfx.first] = &sfx.second;