From 694ecdd9c37db2642b95f2f4a48c28398443082b Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 25 Aug 2019 22:56:46 -0400 Subject: [PATCH] Editor/CMakeLists: Add QT_NO_URL_CAST_FROM_STRING Prevents implicit conversion from QString to QUrl in order to avoid potentially incorrect conversions from being performed. This makes all such conversions explicit. --- Editor/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Editor/CMakeLists.txt b/Editor/CMakeLists.txt index 0a9a179..1dc2108 100644 --- a/Editor/CMakeLists.txt +++ b/Editor/CMakeLists.txt @@ -68,6 +68,9 @@ target_compile_definitions(amuse-gui PRIVATE # Disable narrowing conversions in signal/slot connect() calls. -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT + # Disable implicit QString->QUrl conversions to enforce use of proper resolving functions. + -DQT_NO_URL_CAST_FROM_STRING + # Allows for more efficient string concatenation, resulting in less temporaries. -DQT_USE_QSTRINGBUILDER )