From f269b66f854f38ff01f483c4cc02ad2b16cba1af Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 25 Aug 2019 22:59:44 -0400 Subject: [PATCH] Editor/CMakeLists: Add QT_NO_PROCESS_COMBINED_ARGUMENT_START Disables an error-prone start() overload for QProcess. This prevents cases where arguments to a process may be split unintentionally. --- Editor/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Editor/CMakeLists.txt b/Editor/CMakeLists.txt index 1dc2108..591cce8 100644 --- a/Editor/CMakeLists.txt +++ b/Editor/CMakeLists.txt @@ -68,6 +68,9 @@ target_compile_definitions(amuse-gui PRIVATE # Disable narrowing conversions in signal/slot connect() calls. -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT + # Disable unsafe overloads of QProcess' start() function. + -DQT_NO_PROCESS_COMBINED_ARGUMENT_START + # Disable implicit QString->QUrl conversions to enforce use of proper resolving functions. -DQT_NO_URL_CAST_FROM_STRING