From f50d67eff05f41b6f95b16f1a4398e51f144f784 Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Tue, 10 Sep 2019 19:48:29 -0400
Subject: [PATCH] Sequencer: Eliminate magic values where applicable

Many of them are just representative of the sizes of an array, so we can
just query the array instead.
---
 lib/Sequencer.cpp | 57 +++++++++++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 19 deletions(-)

diff --git a/lib/Sequencer.cpp b/lib/Sequencer.cpp
index a9ce985..a51bf5a 100644
--- a/lib/Sequencer.cpp
+++ b/lib/Sequencer.cpp
@@ -246,11 +246,13 @@ ObjToken<Voice> Sequencer::ChannelState::keyOn(uint8_t note, uint8_t velocity) {
 }
 
 ObjToken<Voice> Sequencer::keyOn(uint8_t chan, uint8_t note, uint8_t velocity) {
-  if (chan > 15)
+  if (chan >= m_chanStates.size()) {
     return {};
+  }
 
-  if (!m_chanStates[chan])
+  if (!m_chanStates[chan]) {
     m_chanStates[chan] = ChannelState(*this, chan);
+  }
 
   return m_chanStates[chan].keyOn(note, velocity);
 }
@@ -268,8 +270,9 @@ void Sequencer::ChannelState::keyOff(uint8_t note, uint8_t velocity) {
 }
 
 void Sequencer::keyOff(uint8_t chan, uint8_t note, uint8_t velocity) {
-  if (chan > 15 || !m_chanStates[chan])
+  if (chan >= m_chanStates.size() || !m_chanStates[chan]) {
     return;
+  }
 
   m_chanStates[chan].keyOff(note, velocity);
 }
@@ -351,8 +354,9 @@ void Sequencer::ChannelState::prevProgram() {
 }
 
 void Sequencer::setCtrlValue(uint8_t chan, uint8_t ctrl, int8_t val) {
-  if (chan > 15)
+  if (chan >= m_chanStates.size()) {
     return;
+  }
 
   if (ctrl == 0x66) {
     fmt::print(fmt("Loop Start\n"));
@@ -360,8 +364,9 @@ void Sequencer::setCtrlValue(uint8_t chan, uint8_t ctrl, int8_t val) {
     fmt::print(fmt("Loop End\n"));
   }
 
-  if (!m_chanStates[chan])
+  if (!m_chanStates[chan]) {
     m_chanStates[chan] = ChannelState(*this, chan);
+  }
 
   m_chanStates[chan].setCtrlValue(ctrl, val);
 }
@@ -375,11 +380,13 @@ void Sequencer::ChannelState::setPitchWheel(float pitchWheel) {
 }
 
 void Sequencer::setPitchWheel(uint8_t chan, float pitchWheel) {
-  if (chan > 15)
+  if (chan >= m_chanStates.size()) {
     return;
+  }
 
-  if (!m_chanStates[chan])
+  if (!m_chanStates[chan]) {
     m_chanStates[chan] = ChannelState(*this, chan);
+  }
 
   m_chanStates[chan].setPitchWheel(pitchWheel);
 }
@@ -422,18 +429,22 @@ void Sequencer::allOff(bool now) {
 }
 
 void Sequencer::allOff(uint8_t chan, bool now) {
-  if (chan > 15 || !m_chanStates[chan])
+  if (chan >= m_chanStates.size() || !m_chanStates[chan]) {
     return;
+  }
 
   if (now) {
-    for (const auto& vox : m_chanStates[chan].m_chanVoxs)
+    for (const auto& vox : m_chanStates[chan].m_chanVoxs) {
       vox.second->kill();
-    for (const auto& vox : m_chanStates[chan].m_keyoffVoxs)
+    }
+    for (const auto& vox : m_chanStates[chan].m_keyoffVoxs) {
       vox->kill();
+    }
     m_chanStates[chan].m_chanVoxs.clear();
     m_chanStates[chan].m_keyoffVoxs.clear();
-  } else
+  } else {
     m_chanStates[chan].allOff();
+  }
 }
 
 void Sequencer::ChannelState::killKeygroup(uint8_t kg, bool now) {
@@ -575,12 +586,14 @@ void Sequencer::setVolume(float vol, float fadeTime) {
 }
 
 int8_t Sequencer::getChanProgram(int8_t chanId) const {
-  if (chanId > 15)
+  if (static_cast<size_t>(chanId) >= m_chanStates.size()) {
     return 0;
+  }
 
   if (!m_chanStates[chanId]) {
-    if (!m_midiSetup)
+    if (!m_midiSetup) {
       return 0;
+    }
     return m_midiSetup[chanId].programNo;
   }
 
@@ -588,31 +601,37 @@ int8_t Sequencer::getChanProgram(int8_t chanId) const {
 }
 
 bool Sequencer::setChanProgram(int8_t chanId, int8_t prog) {
-  if (chanId > 15)
+  if (static_cast<size_t>(chanId) >= m_chanStates.size()) {
     return false;
+  }
 
-  if (!m_chanStates[chanId])
+  if (!m_chanStates[chanId]) {
     m_chanStates[chanId] = ChannelState(*this, chanId);
+  }
 
   return m_chanStates[chanId].programChange(prog);
 }
 
 void Sequencer::nextChanProgram(int8_t chanId) {
-  if (chanId > 15)
+  if (static_cast<size_t>(chanId) >= m_chanStates.size()) {
     return;
+  }
 
-  if (!m_chanStates[chanId])
+  if (!m_chanStates[chanId]) {
     m_chanStates[chanId] = ChannelState(*this, chanId);
+  }
 
   return m_chanStates[chanId].nextProgram();
 }
 
 void Sequencer::prevChanProgram(int8_t chanId) {
-  if (chanId > 15)
+  if (static_cast<size_t>(chanId) >= m_chanStates.size()) {
     return;
+  }
 
-  if (!m_chanStates[chanId])
+  if (!m_chanStates[chanId]) {
     m_chanStates[chanId] = ChannelState(*this, chanId);
+  }
 
   return m_chanStates[chanId].prevProgram();
 }