Commit Graph

183 Commits

Author SHA1 Message Date
Phillip Stephens 6c7094f6fb
Fix casting error 2020-04-22 03:41:35 -07:00
Lioncash 99f00a7cba EffectReverb: Make use of std::array where applicable
Makes the array types more strongly typed and allows removing the use of
hardcoded array sizes.
2020-03-27 17:18:40 -04:00
Lioncash 5b6d736cfb EffectChorus: Make use of std::array where applicable
Same behavior, but with stronger typing.
2020-03-27 16:45:04 -04:00
Lioncash be754a44a4 EffectDelay: Make use of std::array where applicable
Makes the arrays more strongly typed and allows dehardcoding some array
sizes.
2020-03-27 16:31:38 -04:00
Jack Andersen c27bb5c435 Merge branch 'master' of ssh://git.axiodl.com:6431/AxioDL/amuse 2019-09-30 21:36:35 -10:00
Jack Andersen 5d4abb5fb1 Code style improvements 2019-09-30 21:34:12 -10:00
Phillip Stephens 757defee7a
Merge pull request #43 from lioncash/array2
AudioGroupPool: Use std::array where applicable
2019-09-10 23:53:38 -07:00
Phillip Stephens 0dca047352
Merge pull request #40 from lioncash/const
Studio: Make _cyclicCheck a const member function
2019-09-10 23:53:19 -07:00
Lioncash 321a229dfd AudioGroupPool: Use std::array where applicable
Makes the array types strongly-typed and also allows for size querying.
2019-09-10 21:09:10 -04:00
Lioncash 04fbc328e9 Studio: Make _cyclicCheck a const member function
This doesn't actually modify the internal state of the studio instance,
so we can mark it as a const member function.
2019-09-10 20:20:37 -04:00
Lioncash 9ec78d6b9f Sequencer: Always initialize ChannelState channel ID
Provides a deterministic initial state for the default constructor case.
2019-09-10 20:05:05 -04:00
Lioncash 5f76f0ecbf Sequencer: Use std::array for m_ctrlVals
This is the only array in the header that isn't using std::array.
2019-09-10 20:03:26 -04:00
Lioncash b6f0201fbb General: Be explicit about athena's Endian type
Allows this code to still compile if the enum is ever changed into an
enum class.
2019-09-08 17:22:38 -04:00
Lioncash d10a0ac7f1 General: Be explicit about athena's SeekOrigin type
Allows the code to still compile if the enum is turned into an enum
class.
2019-09-08 16:59:29 -04:00
Phillip Stephens d88b14c38a
Merge pull request #37 from lioncash/emitter
Emitter: Use std::array where applicable
2019-09-08 00:10:40 -07:00
Lioncash 29e7d8bc1e Emitter: Use std::array where applicable
Makes the data more strongly-typed and prevents implicit array->pointer
decay
2019-09-07 20:55:26 -04:00
Lioncash 7600f8ad27 General: Make operator bool() instances explicit
Prevents error-prone implicit conversions to bool.
2019-09-07 11:27:43 -04:00
Lioncash 50c4b5cdab General: Amend clamp parameter order
Batch replace on switching to standardized variants assumed common
ordering, which evidently wasn't the case
2019-09-07 06:40:20 -04:00
Lioncash eaf62288a2 Common: Replace amuse::clamp with std::clamp
We can use the standardized facility for this now with C++17
2019-08-26 05:14:21 -04:00
Lioncash d7aaff25d0 General: Clean up inclusions
Ensures that each header includes all of its dependencies that can't be
forward declared.
2019-08-25 07:34:27 -04:00
Phillip Stephens cbf331823f
Merge pull request #12 from lioncash/override
General: Make use of override where applicable
2019-08-24 23:47:53 -07:00
Lioncash 67c64a2d4e General: Make use of override where applicable
Continues the use of override.
2019-08-25 01:28:36 -04:00
Lioncash a8f4c1d34a Common: Less strict memory ordering requirements for IObj
Applies the same relaxed restrictions as applied to boo in
4d91a1b3c3
and
84f62a0f2c
2019-08-25 00:09:48 -04:00
Lioncash c46bb3f72b Common: Make interfaces constexpr and noexcept where applicable
Many of these types are trivial helper types. These can be made
constexpr and noexcept to allow using them with other interfaces in a
more flexible manner.
2019-08-25 00:04:01 -04:00
Phillip Stephens 529efa72b4 Fixes for `override` 2019-08-10 17:48:04 -07:00
Jack Andersen 1e35db90aa Windows build fixes 2019-07-27 15:18:09 -10:00
Jack Andersen b0e4973c64 Massive fmtlib refactor 2019-07-19 18:23:25 -10:00
Jack Andersen 2a3444400e Better CMake dependency handling 2019-06-11 16:02:52 -10:00
Jack Andersen aeaba9366d Support for compiling against libc++ 2019-04-06 18:55:39 -10:00
Jack Andersen a4b8946ee2 Ensure all ObjectIDs are unique project-wide 2019-02-28 10:34:26 -10:00
Jack Andersen 54ef2dd73b Correct SCALEVOLUME behavior 2019-02-07 15:07:46 -10:00
Jack Andersen fc2f8542c1 Windows compile fix 2019-01-28 22:26:40 -10:00
Jack Andersen d80f1346bb Fix unwanted cutoff bug 2019-01-22 21:52:00 -10:00
Jack Andersen a7a408cc66 New code style refactor 2018-12-07 19:20:09 -10:00
Jack Andersen b4c073c373 More accurate attenuation curve 2018-10-25 21:44:56 -10:00
Jack Andersen 885a2d2154 Windows build fixes 2018-10-14 10:10:33 -10:00
Jack Andersen dbd48a39cc Convert to pragma once 2018-10-06 17:40:25 -10:00
Phillip Stephens 9e6d97564b Switch build fixes 2018-09-25 15:39:22 -07:00
Jack Andersen 81f0a91569 Looping SNG support; bug fixes 2018-09-08 11:34:01 -10:00
Jack Andersen 8fee7a282b Avoid narrowing conversion for panning 2018-09-02 20:33:41 -10:00
Jack Andersen 6a7f32a29d Bug fixes for MP2 extraction 2018-09-02 14:43:05 -10:00
Jack Andersen 4fc5dfdc76 macOS fixes 2018-08-27 17:48:53 -10:00
Jack Andersen 19c5443e9e Bug fixes, xref search, more context menus 2018-08-25 18:57:02 -10:00
Jack Andersen 27cdee0c14 Clipboard support and various bug fixes 2018-08-24 22:34:04 -10:00
Jack Andersen 303877655f Fixes for Windows 2018-08-19 10:05:39 -10:00
Jack Andersen 08988fe3ec Group export and various bug fixes 2018-08-18 14:28:52 -10:00
Jack Andersen fec074ad30 Studio setup window and volume LUT 2018-08-15 20:26:44 -10:00
Jack Andersen 5e89954094 More undo commands and pitch/mod coding fix 2018-08-13 22:36:02 -10:00
Jack Andersen d24e06f101 All editors implemented 2018-08-09 20:19:23 -10:00
Jack Andersen eff832bb8c Implement SongGroupEditor 2018-08-08 21:42:17 -10:00