AxioDL/boo
2
0
Fork 0
mirror of https://github.com/AxioDL/boo.git synced 2025-12-09 21:47:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Safer null-pointer handling in AudioQueueServices

Browse Source
This commit is contained in:
Jack Andersen
2016-05-24 11:56:22 -10:00
parent a464f3d68c
commit db8c002f4e
1 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lib/audiodev/AQS.cpp
View File

@@ -42,7 +42,7 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
AudioQueueBufferRef m_buffers[3];
size_t m_frameBytes;
MIDIClientRef m_midiClient;
MIDIClientRef m_midiClient = 0;
std::mutex m_engineMutex;
std::condition_variable m_engineEnterCv;
@@ -115,6 +115,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::vector<std::pair<std::string, std::string>> enumerateMIDIDevices() const
{
if (!m_midiClient)
return {};
std::vector<std::pair<std::string, std::string>> ret;
ItemCount numDevices = MIDIGetNumberOfDevices();
@@ -368,6 +371,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::unique_ptr<IMIDIIn> newVirtualMIDIIn(ReceiveFunctor&& receiver)
{
if (!m_midiClient)
return {};
std::unique_ptr<IMIDIIn> ret = std::make_unique<MIDIIn>(true, std::move(receiver));
if (!ret)
return {};
@@ -387,6 +393,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::unique_ptr<IMIDIOut> newVirtualMIDIOut()
{
if (!m_midiClient)
return {};
std::unique_ptr<IMIDIOut> ret = std::make_unique<MIDIOut>(true);
if (!ret)
return {};
@@ -403,6 +412,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::unique_ptr<IMIDIInOut> newVirtualMIDIInOut(ReceiveFunctor&& receiver)
{
if (!m_midiClient)
return {};
std::unique_ptr<IMIDIInOut> ret = std::make_unique<MIDIInOut>(true, std::move(receiver));
if (!ret)
return {};
@@ -430,6 +442,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::unique_ptr<IMIDIIn> newRealMIDIIn(const char* name, ReceiveFunctor&& receiver)
{
if (!m_midiClient)
return {};
MIDIEndpointRef src = LookupMIDISource(name);
if (!src)
return {};
@@ -454,6 +469,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::unique_ptr<IMIDIOut> newRealMIDIOut(const char* name)
{
if (!m_midiClient)
return {};
MIDIEndpointRef dst = LookupMIDIDest(name);
if (!dst)
return {};
@@ -476,6 +494,9 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
std::unique_ptr<IMIDIInOut> newRealMIDIInOut(const char* name, ReceiveFunctor&& receiver)
{
if (!m_midiClient)
return {};
MIDIEndpointRef src = LookupMIDISource(name);
if (!src)
return {};
@@ -648,7 +669,8 @@ struct AQSAudioVoiceEngine : BaseAudioVoiceEngine
~AQSAudioVoiceEngine()
{
AudioQueueDispose(m_queue, false);
MIDIClientDispose(m_midiClient);
if (m_midiClient)
MIDIClientDispose(m_midiClient);
}
void pumpAndMixVoices()