Luke Street
abfd5a464f
CGroundMovement: Fix CheckFalling not being called consistently
2020-04-29 02:09:20 -04:00
Phillip Stephens
92076a3bd3
Implement CBurrower
2020-04-28 07:16:10 -07:00
Phillip Stephens
9b94dd7c3a
Fix compiling CGameOptionsTouchBar
2020-04-26 18:47:01 -07:00
Lioncash
1948ec3274
CWallWalker: Remove unused variables in PreThink
...
We can leave a comment documenting this to make the code itself a little
nicer to read.
2020-04-26 03:28:48 -04:00
Lioncash
d4264b6469
CWallWalker: Eliminate signed->unsigned implicit conversion in header
...
Prevents compiler warnings.
2020-04-26 03:22:03 -04:00
Lioncash
4f56bf8eb6
CWallWalker: Simplify CCollisionSurface initializer
...
Allows it to sit on one line.
2020-04-26 03:20:47 -04:00
Lioncash
deff9d054b
CTimeProvider: Move global instance to cpp file
...
This isn't used anywhere externally, so we can keep it hidden in the cpp
file.
2020-04-26 03:05:57 -04:00
Lioncash
002102c530
RumbleFxTable: Make table constexpr
...
Eliminates any potential runtime initializers.
2020-04-26 01:27:46 -04:00
Lioncash
6c475b6764
CGuiWidgetDrawParms: Make constexpr constructible
...
We can allow this structure to be constructed in a constexpr context.
This also allows us to remove the cpp file, given it's no longer
necessary.
2020-04-26 01:15:04 -04:00
Lioncash
07ebdd364c
CDamageVulnerability: Make constructors constexpr
...
Eliminates any potential runtime initializers related to file-scope
constant instances of this class.
2020-04-26 01:06:26 -04:00
Lioncash
0ad1f8ba42
CDamageVulnerability: Amend typo in parameter name
2020-04-26 00:56:45 -04:00
Lioncash
f1ff48c38b
CDamageVulnerability: Remove unnecessary inline specifiers
...
These functions are already marked static, so they're already a
candidate for inlining.
We can mark them as constexpr though, given how trivial they are.
2020-04-26 00:54:36 -04:00
Lioncash
b76b956339
CElementGen: Give all function prototype parameters names
2020-04-25 03:16:08 -04:00
Lioncash
57d953a045
CElementGen: Eliminate sign conversion warnings with function parameters
...
Makes the expected types explicit.
2020-04-25 03:09:29 -04:00
Lioncash
eb4362a4d4
CDecalDataFactory: Remove unused includes
2020-04-25 02:52:53 -04:00
Lioncash
96070f0c89
CGuiTextPane: Eliminate implicit float->int conversions
2020-04-25 02:28:52 -04:00
Luke Street
e99e79ac9a
AssetNameMap: Fix fmt strings
2020-04-24 02:49:40 -04:00
Luke Street
3c48da0cdb
Merge remote-tracking branch 'origin/trim'
2020-04-24 02:43:56 -04:00
Lioncash
d7c9135d27
CBomb: Fix boolean parameter not being used within SetFuseDisabled()
...
Prevents silent logic bugs, particularly given this function is called
with true as well inside CTryclops::InMaxRange.
2020-04-24 01:12:04 -04:00
Lioncash
27861d5c78
CUVElement: Convert stateful structs into classes
...
Avoids exposing the internals of the data by default (since they were
previously fully accessible).
2020-04-24 00:59:51 -04:00
Lioncash
b32bc296ad
CUVElement/CVectorElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:58:44 -04:00
Lioncash
4a9095a2af
CRealElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:57:13 -04:00
Lioncash
f620b4325f
CIntElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:55:43 -04:00
Lioncash
102d62846c
CColorElement: Make use of [[maybe_unused]] where applicable
2020-04-24 00:54:08 -04:00
Lioncash
6d53912770
CStringTable: Make use of [[maybe_unused]] where applicable
2020-04-23 21:24:39 -04:00
Lioncash
ee0762db32
CRasterFont: Make use of [[maybe_unused]] where applicable
2020-04-23 21:23:17 -04:00
Lioncash
5e9bf292d7
CTextureCache: Make use of [[maybe_unused]] where applicable
2020-04-23 21:15:30 -04:00
Lioncash
600076030f
CStateManager: Make use of bool parameter in SetWarping()
...
Allows toggling the warping.
2020-04-23 21:12:52 -04:00
Lioncash
25b0c69818
CSaveWorld: Make use of [[maybe_unused]] where applicable
...
Prevents unused parameter warnings.
2020-04-23 20:51:59 -04:00
Lioncash
301eb24301
CInGameTweakManagerBase: Make internal members of CTweakValue private
2020-04-23 20:48:43 -04:00
Lioncash
e4dedac2b6
CInGameTweakManagerBase: Make use of algorithms where applicable
2020-04-23 20:44:31 -04:00
Lioncash
e1dfe9ff8e
CGameOptionsTouchBar: Make use of [[maybe_unused]] where applicable
...
Silences unused parameter warnings
2020-04-23 20:34:05 -04:00
Lioncash
14e0067a97
CDependencyGroup: Make use of [[maybe_unused]] where applicable
2020-04-23 20:31:29 -04:00
Lioncash
4a6c3cde3c
CWorldLight: Eliminate variable shadowing
...
While we're at it, we can make use of structured bindings.
2020-04-23 07:25:07 -04:00
Lioncash
4e3363a98b
CScriptActorKeyframe: Eliminate variable shadowing
2020-04-23 07:22:10 -04:00
Lioncash
9ec9f42457
CPathFindSearch: Eliminate variable shadowing
2020-04-23 07:19:41 -04:00
Lioncash
078acce378
CMorphBall: Eliminate variable shadowing
2020-04-23 07:18:43 -04:00
Lioncash
31cf98646b
CModVectorElement: Eliminate variable shadowing
...
Prevents "a" from clashing with a local variable.
2020-04-23 07:16:49 -04:00
Lioncash
9fa689a806
CMemoryCardSys: Eliminate variable shadowing
...
Prevents names from clashing with variables from outside the loop scope.
2020-04-23 07:13:22 -04:00
Lioncash
e0bb66f7f0
CParticleElectricDataFactory: Remove unused includes
2020-04-23 03:58:10 -04:00
Lioncash
eefeb5cd0b
CGameArea: Remove undefined behavior type-punning in a few functions
...
We can make use of std::memcpy here to get around this.
2020-04-23 03:06:04 -04:00
Lioncash
df3aed75fe
CGameArea: Eliminate implicit sign conversions in Validate()
2020-04-23 02:53:24 -04:00
Lioncash
419d40051d
CGuiTextSupport: Make enum formatting consistent
2020-04-23 02:41:22 -04:00
Lioncash
b700da547e
CGuiTextSupport: Invert conditionals where applicable
...
Unindents code and allows for easier placement of breakpoints when the
conditions are equal to the early exit path.
2020-04-23 02:39:39 -04:00
Lioncash
787fc3276f
CGuiTextSupport: Use const references where applicable
2020-04-23 02:36:45 -04:00
Lioncash
a21fb1da35
CGuiObject: Remove unused includes
2020-04-23 02:27:11 -04:00
Lioncash
2b2edfa871
CGrappleArm: Invert conditionals where applicable
...
Makes early-exit conditions nicer to follow and also unindents some
code.
2020-04-23 01:57:18 -04:00
Phillip Stephens
823c01ce12
Update submodules
2020-04-22 15:03:12 -07:00
Phillip Stephens
e2f22c8bc0
Update amuse
2020-04-22 03:41:57 -07:00
Phillip Stephens
96b63c2e54
Remove pointless assignment
2020-04-22 03:40:06 -07:00