Commit Graph

349 Commits

Author SHA1 Message Date
Dmitry-Me 3cc6f5c6f2 Annotate fall throughs with comments 2017-08-03 18:42:20 +03:00
Lee Thomason 8c9e3133c4 remove error string inline. hopefully helps with odd linking issues 2017-06-26 16:55:01 -07:00
Lee Thomason 8bba8b41d6 mark unused enums 2017-06-20 09:18:41 -07:00
Lee Thomason 9201bb96d3 Merge pull request #563 from Dmitry-Me/betterParameterNameInClone
Better parameter name
2017-06-19 14:23:39 -07:00
Dmitry-Me 3f63f21cf5 Better parameter name 2017-06-19 18:25:19 +03:00
Lee Thomason 8a763619ac fix incorrect factoring 2017-06-16 09:30:16 -07:00
Lee Thomason bc527554e8 Merge pull request #558 from leethomason/clone
Support clone (deep copy) of XMLDocument and XMLNode
2017-06-15 12:01:48 -07:00
Dmitry-Me c2f677b05e Unlinked nodes assertions 2017-06-15 12:44:27 +03:00
Lee Thomason 1346a174ae tweak comments. fix copy to self case. 2017-06-14 15:14:19 -07:00
Lee Thomason 1bbc66b193 Merge branch 'master' into clone 2017-06-14 15:10:37 -07:00
Lee Thomason b754ddf0fb address feedback from review 2017-06-14 15:02:38 -07:00
Lee Thomason 816d3fa0cd Fix string leaking (and destructors not getting called) when there are XMLNodes that aren't in the document tree 2017-06-05 14:35:55 -07:00
Lee Thomason a30f8bd136 Merge remote-tracking branch 'origin/master' into clone 2017-06-01 18:46:53 -07:00
Lee Thomason 7085f00e40 deep copy and clone 2017-06-01 18:09:43 -07:00
Dmitry-Me 10b8ecc99b Clarify variable names 2017-04-12 17:57:44 +03:00
Dmitry-Me e503563f47 Fully use enum 2017-04-05 18:02:40 +03:00
Dmitry-Me ba68a3aea6 Pointer assertion 2017-03-21 11:39:48 +03:00
Lee Thomason 395ea09f83 Merge pull request #538 from Dmitry-Me/suppressC6011
Suppress C6011 code analysis false positive warning
2017-03-06 12:49:35 -08:00
Dmitry-Me 7221b49fea Suppress C6011 code analysis false positive warning 2017-03-03 15:45:51 +03:00
Dmitry-Me ae8a82a734 Clearer variable name 2017-03-03 15:40:32 +03:00
Lee Thomason 92c0ef327f Merge pull request #527 from Dmitry-Me/reuseNodesCreationCode
Extract and reuse nodes creation code
2017-03-01 13:15:52 -08:00
Dmitry-Me 2aebfb7123 Extract and reuse nodes creation code 2017-02-27 15:53:40 +03:00
Lee Thomason b37cb42b78 Merge pull request #513 from leethomason/bool-write
Bool serialization.
2017-02-17 12:39:06 -08:00
Dmitry-Me f89bd3ef68 Initialize member variables 2017-01-18 18:33:55 +03:00
Lee Thomason c5c99c2ba0 tweaks to bool serialization 2016-12-29 11:19:17 -08:00
Lee Thomason f458d265c1 fix const. hopefully. 2016-12-26 22:47:25 -08:00
Lee Thomason ce667c9233 ability to set bool write values 2016-12-26 16:45:30 -08:00
Lee Thomason 5b733ff481 Merge pull request #504 from Dmitry-Me/ensureLinkPointersAreNotOverwritten
Ensure existing attributes are not leaked on attribute insertion
2016-12-24 07:39:17 -08:00
Lee Thomason e90e901041 tweaks, clarification to line numbers 2016-12-24 07:34:39 -08:00
Dmitry-Me 34a3f8e34d Ensure existing attributes are not leaked on attribute insertion 2016-12-19 12:05:21 +03:00
kezenator e353181a46 CodeReview Fix: initialLineNum? Something a little more descriptive? 2016-11-29 19:49:07 +10:00
kezenator e3d44159e3 CodeReview Fix: The initializer syntax isn't used. Should be 'int unusedLineNum = 0` 2016-11-29 19:47:55 +10:00
kezenator 4f756161d0 CodeReview Fix: The non-const reference syntax isn't used in the codebase. Should be a pointer. 2016-11-29 19:46:27 +10:00
kezenator 2489afcc61 Merge branch 'master' of https://github.com/leethomason/tinyxml2 2016-11-29 19:33:44 +10:00
kezenator ec6941503c Added line number reporting to parse errors and to all nodes and attributes for parsed documents. 2016-11-26 17:21:43 +10:00
Lee Thomason 156bc1b99f Merge pull request #502 from Dmitry-Me/reuseClearError
Reuse code for error clearing
2016-11-25 22:06:11 -08:00
kezenator 5a70071241 Added static method to convert arbitrary ErrorID to a string.
Updated tests to print ErrorID and bool values as strings.
2016-11-26 13:54:42 +10:00
Dmitry-Me 0d2cef0cba Reuse code for error clearing 2016-11-25 18:39:52 +03:00
Dmitry-Me a60caa28cc Reuse attribute creation code 2016-11-22 18:28:08 +03:00
Lee Thomason 7de0b6dd8c Merge pull request #493 from leethomason/jwittner
Friendly API for attribute query.
2016-11-15 14:09:03 -08:00
Lee Thomason d04f21cab8 Merge pull request #496 from Dmitry-Me/detectDeclarationPlacement
Declarations should occur before anything else
2016-11-15 14:08:04 -08:00
Dmitry-Me 446c3bcae3 Declarations should occur before anything else 2016-11-11 10:34:56 +03:00
Dmitry-Me 4336431272 Pointer post-assertion 2016-11-07 18:48:50 +03:00
Lee Thomason c9a6102bf1 Merge branch 'master' of git://github.com/jwittner/tinyxml2 into jwittner-master 2016-10-27 14:33:52 -07:00
Dmitry-Me c5f1e7ce6e Avoid cast to signed integer type 2016-10-14 10:33:02 +03:00
Dmitry-Me ecb9b07476 Reuse "is element with name" check 2016-10-12 16:44:59 +03:00
Josh Wittner 513e69ba68 Merge branch 'master' of https://github.com/leethomason/tinyxml2 2016-10-11 19:00:53 -07:00
Josh Wittner cf3dd09b08 Move implementations to cpp 2016-10-11 18:57:17 -07:00
Kevin Wojniak 318252a973 Fix warning on PowerPC
GCC 5+ will generate "error: comparison is always true due to limited range of data type" when -Wextra is used because PowerPC by default uses unsigned char, so it can never be less than 0.
2016-10-07 10:37:02 -07:00
Lee Thomason 6f1ad6153e Merge pull request #471 from Dmitry-Me/loopInvariantAssertions
Loop invariant pointer assertions
2016-10-02 21:21:38 -07:00