encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/bug/tint/492.wgsl

8 lines
206 B
WebGPU Shading Language
Raw Normal View History

Add transform::Simplify Performs basic peephole optimizations on the AST. Use in transform::Hlsl. Required to have the DecomposeStorageAccess transform operate correctly with the output of InlinePointerLets transform, specifically when declaring `let` pointer expressions to storage buffers. Fixed: tint:221 Fixed: tint:492 Fixed: tint:829 Change-Id: I536390921a6492378104e9c3c100d9e761294a27 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51921 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-05-21 21:01:23 +00:00
[[block]] struct S { a : i32; };
wgsl: Deprecate [[access]] decorations Handle access control on var declarations instead of via [[access]] decorations. This change does the minimal work to migrate the WGSL parser over to the new syntax. Additional changes will be needed to correctly generate defaulted access qualifiers, as well as validating access usage. The [[access]] decorations are still supported by the WGSL parser, with new deprecated warnings, but not for aliases. Example: var x : [[access(x)]] alias_to_struct; Making this work is far more effort than I want to dedicate to backwards compatibility, and I do not beleive any real-world usage will be doing this. Still TODO: * Adding access control as the optional, third parameter to ptr<>. * Calculating default accesses for the various storage types. * Validating usage of variables against the different accesses. Bug: tint:846 Change-Id: If8ca82e5d16ec319ecd01f9a2cafffd930963bde Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/53088 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com> Reviewed-by: David Neto <dneto@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
2021-06-04 20:41:47 +00:00
[[group(0), binding(0)]] var<storage, read_write> buf : S;
Add transform::Simplify Performs basic peephole optimizations on the AST. Use in transform::Hlsl. Required to have the DecomposeStorageAccess transform operate correctly with the output of InlinePointerLets transform, specifically when declaring `let` pointer expressions to storage buffers. Fixed: tint:221 Fixed: tint:492 Fixed: tint:829 Change-Id: I536390921a6492378104e9c3c100d9e761294a27 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51921 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-05-21 21:01:23 +00:00
validation: compute shader must include 'workgroup_size' in its attributes Bug: tint:884 Change-Id: If96c6df3247fee142a779117fa26d006afd4f7ef Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/55680 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
2021-06-29 18:39:44 +00:00
[[stage(compute), workgroup_size(1)]] fn main() {
Add optional access to ptr<> This also completes the work to resolve the access controls for each storage type. Fixed: tint:846 Change-Id: Iab24057ec14620a2978ec63c4a91ba12d1bc6e9b Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/53381 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com>
2021-06-04 22:17:37 +00:00
let p : ptr<storage, i32, read_write> = &buf.a;
Add transform::Simplify Performs basic peephole optimizations on the AST. Use in transform::Hlsl. Required to have the DecomposeStorageAccess transform operate correctly with the output of InlinePointerLets transform, specifically when declaring `let` pointer expressions to storage buffers. Fixed: tint:221 Fixed: tint:492 Fixed: tint:829 Change-Id: I536390921a6492378104e9c3c100d9e761294a27 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/51921 Commit-Queue: Ben Clayton <bclayton@chromium.org> Reviewed-by: David Neto <dneto@google.com>
2021-05-21 21:01:23 +00:00
*p = 12;
}