encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/BUILD.gn

823 lines
28 KiB
Plaintext
Raw Normal View History

Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# Copyright 2018 The Dawn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Build with a different gtest harness when in Chromium Running test in a Chromium build requires using their gtest and gmock targets as well as a harness that is in //base. Since we want to run Dawn tests on the Chromium GPU bots, we need to support two configurations both building tests standalone and in Chromium. BUG=chromium:870747 Change-Id: I862e62a607e193a27562ece0f1f6d46d8728e446 Reviewed-on: https://dawn-review.googlesource.com/c/2080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-31 10:49:21 +00:00
import("//build_overrides/build.gni")
dawn_native: handle NaN lod values in samplers For samplers with NaN mLodMinClamp or mLodMaxClamp, the equality operator returned false. Adds checks for finite values, and also early returns if two pointers are equal. Bug: dawn:143, chromium:965633 Change-Id: Id5998d6eec275af0fbe30e3b4fcb3eed4fe64c6a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7401 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-05-22 17:18:52 +00:00
import("generator/dawn_generator.gni")
BUILD.gn: Split dawn_component/generator in their own files This will allow follow up commits to use them from the different parts of the split-off BUILD.gn file. BUG=dawn:61 Change-Id: I767f6c97c06ee73290d3df482880d1a2df92e187 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5301 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-06 23:17:39 +00:00
import("scripts/dawn_component.gni")
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
import("scripts/dawn_features.gni")
import("scripts/dawn_overrides_with_defaults.gni")
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
import("//testing/test.gni")
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# libdawn_native
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
config("libdawn_native_internal") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs = [ "${dawn_root}/src/common:dawn_internal" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# Suppress warnings that Metal isn't in the deployment target of Chrome
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
}
Generators: main.py is now dawn_json_generator.py This merges all the files for main.py together again except generator_lib.py because there doesn't seeem to be a good way to separate the pure dawn.json generators and the dawn wire generator. Also updates the GN templates to make it easier to define new generators based on generator_lib, and move the Jinja2 template "stdlib" to generator_lib.py BUG=dawn:165 Change-Id: I1b5b2ef0a59cb142e214f3af9a58048a88ae949a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7880 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:03:05 +00:00
dawn_json_generator("libdawn_native_utils_gen") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
target = "dawn_native_utils"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
"dawn_native/ProcTable.cpp",
"dawn_native/dawn_structs_autogen.h",
"dawn_native/dawn_structs_autogen.cpp",
"dawn_native/ValidationUtils_autogen.h",
"dawn_native/ValidationUtils_autogen.cpp",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
if (dawn_enable_opengl) {
dawn_generator("libdawn_native_opengl_loader_gen") {
script = "generator/opengl_loader_generator.py"
args = [
"--gl-xml",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
rebase_path("third_party/khronos/gl.xml", root_build_dir),
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
]
outputs = [
"dawn_native/opengl/OpenGLFunctionsBase_autogen.cpp",
"dawn_native/opengl/OpenGLFunctionsBase_autogen.h",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
"dawn_native/opengl/opengl_platform_autogen.h",
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
]
}
}
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
# Public libdawn_native headers so they can be publically visible for
# dependencies of libdawn_native
source_set("libdawn_native_headers") {
public_deps = [
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/dawn:dawn_headers",
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
]
BUILD.gn: put public include dirs in all_dependent_configs The public include dirs for Dawn were in the dawn_public config but it would only be added to targets as a part of public_configs. This meant that second-level dependencies that ended up needing to include dawn/dawn.h wouldn't know where to find it. Fixed this by adding include dirs in all_dependent_configs and renamed the config to be very explicit that it is for include dirs only. BUG=chromium:938895 Change-Id: Iad70f3ce1f8a02b96bf341e7dd7d6068ce645af7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5920 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-26 17:16:28 +00:00
all_dependent_configs = [ "${dawn_root}/src/common:dawn_public_include_dirs" ]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
sources = [
"src/include/dawn_native/DawnNative.h",
"src/include/dawn_native/dawn_native_export.h",
# Include all backend's public headers so that dependencies can include
# them even when the backends are disabled.
"src/include/dawn_native/D3D12Backend.h",
"src/include/dawn_native/MetalBackend.h",
"src/include/dawn_native/NullBackend.h",
"src/include/dawn_native/OpenGLBackend.h",
"src/include/dawn_native/VulkanBackend.h",
]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# The meat of the compilation for libdawn_native so that we can cheaply have
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# shared_library / static_library versions of it. It compiles all the files
# except those that define exported symbols.
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
source_set("libdawn_native_sources") {
deps = [
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
":libdawn_native_headers",
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
":libdawn_native_utils_gen",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Validate SPIR-V code when creating ShaderModules This integrates spirv-val in dawn_native so that regular and WebGPU-specific validation of shaders is done. Also adds tests to check OpUndef is correctly rejected so we know WebGPU-specific validation is working. Change-Id: If49d276c98bca8cd3c6c1a420903fe34923a2942
2018-09-06 15:25:46 +00:00
"${dawn_spirv_tools_dir}:spvtools_val",
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
"third_party:spirv_cross",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
configs += [ ":libdawn_native_internal" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
libs = []
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
sources = get_target_outputs(":libdawn_native_utils_gen")
sources += [
dawn_native: Add Instance and Adapters New objects are introduced to control what happens before device creation in dawn_native: - Instance: a connection from the application to dawn_native that is used for dependency injection and to discover adapters. - Adapters: represents the possibility of device creation for a specific (GPU, backend) pair. - BackendConnection: an internal object that standardizes the interface between the frontend and backends. The BackendConnection interface is implemented for the Null backend and stubbed out in other backends. This allows this change to port the ValidationTests to use the new Instance and Adapters concept and deal with other backends later. BUG=dawn:29 Change-Id: I19719a9342b4af091accc0c02fb6b9697eadde7b Reviewed-on: https://dawn-review.googlesource.com/c/3500 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-04 10:30:40 +00:00
"src/dawn_native/Adapter.cpp",
"src/dawn_native/Adapter.h",
"src/dawn_native/BackendConnection.cpp",
"src/dawn_native/BackendConnection.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/BindGroup.cpp",
"src/dawn_native/BindGroup.h",
"src/dawn_native/BindGroupLayout.cpp",
"src/dawn_native/BindGroupLayout.h",
"src/dawn_native/Buffer.cpp",
"src/dawn_native/Buffer.h",
"src/dawn_native/CommandAllocator.cpp",
"src/dawn_native/CommandAllocator.h",
"src/dawn_native/CommandBuffer.cpp",
"src/dawn_native/CommandBuffer.h",
"src/dawn_native/CommandBufferStateTracker.cpp",
"src/dawn_native/CommandBufferStateTracker.h",
WebGPU error handling 2: CommandEncoder for samples and end2end tests CommandEncoder is the replacement for CommandBufferBuilder. This commit adds the dawn.json definition for it and an initial implementation that wraps CommandBufferBuilder. This is done so that the code can be ported to CommandEncoder gradually, otherwise the commit would be too big and would risk many merge conflicts. This converts all samples and end2end tests to use CommandEncoder. BUG=dawn:8 Change-Id: If4ce86e6fb39ba4e0c2af6328d40e63be17d18c1 Reviewed-on: https://dawn-review.googlesource.com/c/4741 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-15 12:54:08 +00:00
"src/dawn_native/CommandEncoder.cpp",
"src/dawn_native/CommandEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Commands.cpp",
"src/dawn_native/Commands.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/ComputePassEncoder.cpp",
"src/dawn_native/ComputePassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/ComputePipeline.cpp",
"src/dawn_native/ComputePipeline.h",
"src/dawn_native/Device.cpp",
"src/dawn_native/Device.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/DynamicUploader.cpp",
"src/dawn_native/DynamicUploader.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Error.cpp",
"src/dawn_native/Error.h",
"src/dawn_native/ErrorData.cpp",
"src/dawn_native/ErrorData.h",
Implement timeline fences in Dawn This change implements timeline fences in Dawn. It includes methods and descriptor members to eventually support multi-queue, but does not implement them. Bug: dawn:26 Change-Id: I81d5fee6acef402fe099227a034d9669a89ab6c3 Reviewed-on: https://dawn-review.googlesource.com/c/2460 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-12-03 16:57:34 +00:00
"src/dawn_native/Fence.cpp",
"src/dawn_native/Fence.h",
"src/dawn_native/FenceSignalTracker.cpp",
"src/dawn_native/FenceSignalTracker.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Forward.h",
dawn_native: Add Instance and Adapters New objects are introduced to control what happens before device creation in dawn_native: - Instance: a connection from the application to dawn_native that is used for dependency injection and to discover adapters. - Adapters: represents the possibility of device creation for a specific (GPU, backend) pair. - BackendConnection: an internal object that standardizes the interface between the frontend and backends. The BackendConnection interface is implemented for the Null backend and stubbed out in other backends. This allows this change to port the ValidationTests to use the new Instance and Adapters concept and deal with other backends later. BUG=dawn:29 Change-Id: I19719a9342b4af091accc0c02fb6b9697eadde7b Reviewed-on: https://dawn-review.googlesource.com/c/3500 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-04 10:30:40 +00:00
"src/dawn_native/Instance.cpp",
"src/dawn_native/Instance.h",
Put the reference to DeviceBase in a new ObjectBase ObjectBase will contain data that all WebGPU objects have such as a pointer back to the device, a refcount (via inheriting from RefCounted), a name, an error status etc. BUG=dawn:24 Change-Id: I919e1a6d4a68811ceb6e503b2a793815c92f2528 Reviewed-on: https://dawn-review.googlesource.com/c/1620 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-10-15 12:54:30 +00:00
"src/dawn_native/ObjectBase.cpp",
"src/dawn_native/ObjectBase.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/PassResourceUsage.h",
"src/dawn_native/PerStage.cpp",
"src/dawn_native/PerStage.h",
"src/dawn_native/Pipeline.cpp",
"src/dawn_native/Pipeline.h",
"src/dawn_native/PipelineLayout.cpp",
"src/dawn_native/PipelineLayout.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/ProgrammablePassEncoder.cpp",
"src/dawn_native/ProgrammablePassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Queue.cpp",
"src/dawn_native/Queue.h",
"src/dawn_native/RefCounted.cpp",
"src/dawn_native/RefCounted.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/RenderPassEncoder.cpp",
"src/dawn_native/RenderPassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/RenderPipeline.cpp",
"src/dawn_native/RenderPipeline.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/RingBuffer.cpp",
"src/dawn_native/RingBuffer.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Sampler.cpp",
"src/dawn_native/Sampler.h",
"src/dawn_native/ShaderModule.cpp",
"src/dawn_native/ShaderModule.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/StagingBuffer.cpp",
"src/dawn_native/StagingBuffer.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/SwapChain.cpp",
"src/dawn_native/SwapChain.h",
"src/dawn_native/Texture.cpp",
"src/dawn_native/Texture.h",
"src/dawn_native/ToBackend.h",
Emulate store and multisample resolve on Metal This patch implements "store and MSAA resolve" store operation on Metal drivers that don't support MTLStoreActionStoreAndMultisampleResolve with a workaround that does MSAA resolve in another render pass. Driver workaround is one type of Dawn Toggles. Dawn Toggles will include other optional optimizations and features that can be configured to use or not when we create Dawn Devices. As all Metal try bots don't need this toggle, to better test this patch on the try bots: 1. We add the support of forcing enabling a workaround when starting an Dawn end2end test so that we can test the workaround on the platforms where the workaround is disabled. 2. We add an optional parameter DeviceDescriptor to CreateDevice() so that we can custom the toggles the Dawn device should use. This patch also adds the support of querying toggle details from Instance and the names of the toggles in use from Device. These APIs are tested in the Dawn unittests added in this patch. BUG=dawn:56 TEST=dawn_end2end_tests TEST=dawn_unittests Change-Id: Iae31d2ded6057eee638b6099d3061e9d78b04d55 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6620 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-04-26 07:52:57 +00:00
"src/dawn_native/Toggles.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/dawn_platform.h",
]
if (dawn_enable_d3d12) {
D3D12: Dynamically load D3D12, DXGI and D3DCompiler Linking against their .lib makes loading Dawn fail on systems that don't have the DLLs. This happens for example on Windows7 that doesn't have d3d12.dll. Instead we dynamically load functions pointers from these DLLs at d3d12::Device startup. Change-Id: I4d01a12d0f91bec45bf125450d2c08aaa9ff9fac
2018-08-30 12:20:28 +00:00
libs += [ "dxguid.lib" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
D3D12: Implement the backend connection and adapter. BUG=dawn:29 Change-Id: Id4497b4a91ba58b79d1cd976a52df5a0fa5d60a8 Reviewed-on: https://dawn-review.googlesource.com/c/3844 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 16:07:48 +00:00
"src/dawn_native/d3d12/AdapterD3D12.cpp",
"src/dawn_native/d3d12/AdapterD3D12.h",
"src/dawn_native/d3d12/BackendD3D12.cpp",
"src/dawn_native/d3d12/BackendD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/BindGroupD3D12.cpp",
"src/dawn_native/d3d12/BindGroupD3D12.h",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.cpp",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.h",
"src/dawn_native/d3d12/BufferD3D12.cpp",
"src/dawn_native/d3d12/BufferD3D12.h",
"src/dawn_native/d3d12/CommandAllocatorManager.cpp",
"src/dawn_native/d3d12/CommandAllocatorManager.h",
"src/dawn_native/d3d12/CommandBufferD3D12.cpp",
"src/dawn_native/d3d12/CommandBufferD3D12.h",
"src/dawn_native/d3d12/ComputePipelineD3D12.cpp",
"src/dawn_native/d3d12/ComputePipelineD3D12.h",
Improve D3D12 adapter initialization. Gather device info at device initialization rather than adapter initialization. BUG=dawn:144 Change-Id: I07e114731a37f3738daa585afa99675f2fd36289 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7700 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-12 18:54:57 +00:00
"src/dawn_native/d3d12/D3D12Info.cpp",
"src/dawn_native/d3d12/D3D12Info.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/DescriptorHeapAllocator.cpp",
"src/dawn_native/d3d12/DescriptorHeapAllocator.h",
"src/dawn_native/d3d12/DeviceD3D12.cpp",
"src/dawn_native/d3d12/DeviceD3D12.h",
"src/dawn_native/d3d12/Forward.h",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.cpp",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.h",
"src/dawn_native/d3d12/PipelineLayoutD3D12.cpp",
"src/dawn_native/d3d12/PipelineLayoutD3D12.h",
D3D12: Dynamically load D3D12, DXGI and D3DCompiler Linking against their .lib makes loading Dawn fail on systems that don't have the DLLs. This happens for example on Windows7 that doesn't have d3d12.dll. Instead we dynamically load functions pointers from these DLLs at d3d12::Device startup. Change-Id: I4d01a12d0f91bec45bf125450d2c08aaa9ff9fac
2018-08-30 12:20:28 +00:00
"src/dawn_native/d3d12/PlatformFunctions.cpp",
"src/dawn_native/d3d12/PlatformFunctions.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/QueueD3D12.cpp",
"src/dawn_native/d3d12/QueueD3D12.h",
"src/dawn_native/d3d12/RenderPipelineD3D12.cpp",
"src/dawn_native/d3d12/RenderPipelineD3D12.h",
"src/dawn_native/d3d12/ResourceAllocator.cpp",
"src/dawn_native/d3d12/ResourceAllocator.h",
"src/dawn_native/d3d12/SamplerD3D12.cpp",
"src/dawn_native/d3d12/SamplerD3D12.h",
"src/dawn_native/d3d12/ShaderModuleD3D12.cpp",
"src/dawn_native/d3d12/ShaderModuleD3D12.h",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/dawn_native/d3d12/StagingBufferD3D12.cpp",
"src/dawn_native/d3d12/StagingBufferD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/SwapChainD3D12.cpp",
"src/dawn_native/d3d12/SwapChainD3D12.h",
"src/dawn_native/d3d12/TextureCopySplitter.cpp",
"src/dawn_native/d3d12/TextureCopySplitter.h",
"src/dawn_native/d3d12/TextureD3D12.cpp",
"src/dawn_native/d3d12/TextureD3D12.h",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/d3d12/UtilsD3D12.cpp",
"src/dawn_native/d3d12/UtilsD3D12.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/d3d12_platform.h",
]
}
if (dawn_enable_metal) {
libs += [
"Metal.framework",
"Cocoa.framework",
Collect device information on Metal Becuase CGDisplayIOServicePort is deprecated in OSX >= 10.9, we create an alternative function which manually finding a service port with matching vendor and product IDs. BUG=dawn:10 TEST=dawn_end2end_tests Change-Id: I94ff65911e159c2b7075209d8902c1551560ed47 Reviewed-on: https://dawn-review.googlesource.com/c/2541 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-11-29 10:54:03 +00:00
"IOKit.framework",
Implement wrapping IOSurfaces in dawn::Texture. This allows wrapping IOSurfaces in a dawn::Texture so a Dawn application can sample from, or render to an IOSurface. It uses Metal's functionality for wrapping textures in MTLTexture. Support for single-plane BGRA8, RG8 and R8 IOSurfaces is added as well as tests for sampling and using BeginRenderPass to clear them. BUG=dawn:112 Change-Id: I367dbd1a75a0c7b81901fb0aae05f1cd46af3f3a Reviewed-on: https://dawn-review.googlesource.com/c/5101 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-01 12:01:18 +00:00
"IOSurface.framework",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
sources += [
Metal: Implement the backend connection and adapter. BUG=dawn:29 Change-Id: Idaca7d2f8ac52d5f46d8030571b5e2da3a573a97 Reviewed-on: https://dawn-review.googlesource.com/c/3940 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-05 13:02:30 +00:00
"src/dawn_native/metal/BackendMTL.h",
"src/dawn_native/metal/BackendMTL.mm",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/metal/BufferMTL.h",
"src/dawn_native/metal/BufferMTL.mm",
"src/dawn_native/metal/CommandBufferMTL.h",
"src/dawn_native/metal/CommandBufferMTL.mm",
"src/dawn_native/metal/ComputePipelineMTL.h",
"src/dawn_native/metal/ComputePipelineMTL.mm",
"src/dawn_native/metal/DeviceMTL.h",
"src/dawn_native/metal/DeviceMTL.mm",
"src/dawn_native/metal/Forward.h",
"src/dawn_native/metal/PipelineLayoutMTL.h",
"src/dawn_native/metal/PipelineLayoutMTL.mm",
"src/dawn_native/metal/QueueMTL.h",
"src/dawn_native/metal/QueueMTL.mm",
"src/dawn_native/metal/RenderPipelineMTL.h",
"src/dawn_native/metal/RenderPipelineMTL.mm",
"src/dawn_native/metal/SamplerMTL.h",
"src/dawn_native/metal/SamplerMTL.mm",
"src/dawn_native/metal/ShaderModuleMTL.h",
"src/dawn_native/metal/ShaderModuleMTL.mm",
Memory manager: buffer uploads (Metal+refactor) - Part 3 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: If4d3e717186895b1409502c1dea5ab751a4776b2 Reviewed-on: https://dawn-review.googlesource.com/c/4440 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
2019-02-15 21:18:40 +00:00
"src/dawn_native/metal/StagingBufferMTL.h",
"src/dawn_native/metal/StagingBufferMTL.mm",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/metal/SwapChainMTL.h",
"src/dawn_native/metal/SwapChainMTL.mm",
"src/dawn_native/metal/TextureMTL.h",
"src/dawn_native/metal/TextureMTL.mm",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/metal/UtilsMetal.h",
"src/dawn_native/metal/UtilsMetal.mm",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
if (dawn_enable_null) {
sources += [
dawn_native: define exported functions in their own files. This adds a new FooBackend.cpp file for each backend that defines exactly the symbols that are exported by libdawn_native's headers. THis will allow factoring most of the compilation of dawn_native between the shared and static library variants. BUG=dawn:85 Change-Id: I69c808dac2fe5e8bb08356117e3997677787b08a Reviewed-on: https://dawn-review.googlesource.com/c/3760 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 08:35:16 +00:00
"src/dawn_native/null/DeviceNull.cpp",
"src/dawn_native/null/DeviceNull.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
if (dawn_enable_opengl) {
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
deps += [
":libdawn_native_opengl_loader_gen",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
"third_party:khronos_platform",
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
]
sources += get_target_outputs(":libdawn_native_opengl_loader_gen")
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
OpenGL: Implement the backend connection and adapter. The OpenGL backend can't gather discover default adapters because it needs getProc to do anything so we add DiscoverAdapters method to Instance that takes backend-specific options. dawn_native::opengl::CreateDevice is removed in favor of the adapter path so OpenGLBinding is modified to create an instance locally. This is only temporary until all backends support adapters, at which point a lot of *Binding code will be factored. Also contains a small fix for Result<T, E> with movable types. BUG=dawn:29 Change-Id: I4eb3d4a14a871af73e1872132aff72b45e5fe566 Reviewed-on: https://dawn-review.googlesource.com/c/3663 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-07 09:48:03 +00:00
"src/dawn_native/opengl/BackendGL.cpp",
"src/dawn_native/opengl/BackendGL.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/opengl/BufferGL.cpp",
"src/dawn_native/opengl/BufferGL.h",
"src/dawn_native/opengl/CommandBufferGL.cpp",
"src/dawn_native/opengl/CommandBufferGL.h",
"src/dawn_native/opengl/ComputePipelineGL.cpp",
"src/dawn_native/opengl/ComputePipelineGL.h",
"src/dawn_native/opengl/DeviceGL.cpp",
"src/dawn_native/opengl/DeviceGL.h",
"src/dawn_native/opengl/Forward.h",
Remove OpenGLBinding's dependency on glad This move all the OpenGL-specific code for swapchain handling in a new NativeSwapChainImpl in the OpenGL backend so no code outside of dawn_native needs OpenGL. BUG=dawn:165 Change-Id: I3c0c1055e3215a59fdc8e9550baf30762a7014b5 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8161 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-06-17 09:01:09 +00:00
"src/dawn_native/opengl/NativeSwapChainImplGL.cpp",
"src/dawn_native/opengl/NativeSwapChainImplGL.h",
OpenGL: Don't use glad to load OpenGL entrypoints This makes the OpenGL entry points loaded at Adapter creation from the getProcAddress passed in the DiscoveryOptions and update all GL calls in the backend to go through the new OpenGLFunctions object. A code generator is added that generates the function loader and list of GL procs from Khronos' gl.xml file but we can't get rid of glad yet because it is used to have the PROC typedefs and enum values. BUG=dawn:165 Change-Id: I2a583d79752f55877fa4190846f5be16cf91651a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7983 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-13 10:22:32 +00:00
"src/dawn_native/opengl/OpenGLFunctions.cpp",
"src/dawn_native/opengl/OpenGLFunctions.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/opengl/PersistentPipelineStateGL.cpp",
"src/dawn_native/opengl/PersistentPipelineStateGL.h",
"src/dawn_native/opengl/PipelineGL.cpp",
"src/dawn_native/opengl/PipelineGL.h",
"src/dawn_native/opengl/PipelineLayoutGL.cpp",
"src/dawn_native/opengl/PipelineLayoutGL.h",
"src/dawn_native/opengl/QueueGL.cpp",
"src/dawn_native/opengl/QueueGL.h",
"src/dawn_native/opengl/RenderPipelineGL.cpp",
"src/dawn_native/opengl/RenderPipelineGL.h",
"src/dawn_native/opengl/SamplerGL.cpp",
"src/dawn_native/opengl/SamplerGL.h",
"src/dawn_native/opengl/ShaderModuleGL.cpp",
"src/dawn_native/opengl/ShaderModuleGL.h",
"src/dawn_native/opengl/SwapChainGL.cpp",
"src/dawn_native/opengl/SwapChainGL.h",
"src/dawn_native/opengl/TextureGL.cpp",
"src/dawn_native/opengl/TextureGL.h",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/opengl/UtilsGL.cpp",
"src/dawn_native/opengl/UtilsGL.h",
Remove glad and replace it with our own GL header This completely removes the dependency on glad by generating the GL headers from gl.xml directly. This requires adding khrplatform.h so all Khronos dependencies are gathered in third_party/khronos. Also removes a stray CMakeLists.txt that was still hanging out. BUG=dawn:165 Change-Id: Ia64bc51bc8b18c6b48613918e2f309f7405ecb3b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8163 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-06-17 09:17:29 +00:00
"src/dawn_native/opengl/opengl_platform.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
if (dawn_enable_vulkan) {
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
deps += [ "third_party:vulkan_headers" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
Vulkan: Implement the backend connection and adapter. This also changes VulkanInfo to gather info on backends / adapters instead of the device, because all the info gathering can happen before the device is created. BUG=dawn:29 Change-Id: I9dc4412f494428f1ae589544d3adf76fe8b9a3a3 Reviewed-on: https://dawn-review.googlesource.com/c/3941 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-04 09:31:09 +00:00
"src/dawn_native/vulkan/AdapterVk.cpp",
"src/dawn_native/vulkan/AdapterVk.h",
"src/dawn_native/vulkan/BackendVk.cpp",
"src/dawn_native/vulkan/BackendVk.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/BindGroupLayoutVk.cpp",
"src/dawn_native/vulkan/BindGroupLayoutVk.h",
"src/dawn_native/vulkan/BindGroupVk.cpp",
"src/dawn_native/vulkan/BindGroupVk.h",
"src/dawn_native/vulkan/BufferVk.cpp",
"src/dawn_native/vulkan/BufferVk.h",
"src/dawn_native/vulkan/CommandBufferVk.cpp",
"src/dawn_native/vulkan/CommandBufferVk.h",
"src/dawn_native/vulkan/ComputePipelineVk.cpp",
"src/dawn_native/vulkan/ComputePipelineVk.h",
"src/dawn_native/vulkan/DeviceVk.cpp",
"src/dawn_native/vulkan/DeviceVk.h",
"src/dawn_native/vulkan/FencedDeleter.cpp",
"src/dawn_native/vulkan/FencedDeleter.h",
"src/dawn_native/vulkan/Forward.h",
"src/dawn_native/vulkan/MemoryAllocator.cpp",
"src/dawn_native/vulkan/MemoryAllocator.h",
"src/dawn_native/vulkan/NativeSwapChainImplVk.cpp",
"src/dawn_native/vulkan/NativeSwapChainImplVk.h",
"src/dawn_native/vulkan/PipelineLayoutVk.cpp",
"src/dawn_native/vulkan/PipelineLayoutVk.h",
"src/dawn_native/vulkan/QueueVk.cpp",
"src/dawn_native/vulkan/QueueVk.h",
"src/dawn_native/vulkan/RenderPassCache.cpp",
"src/dawn_native/vulkan/RenderPassCache.h",
"src/dawn_native/vulkan/RenderPipelineVk.cpp",
"src/dawn_native/vulkan/RenderPipelineVk.h",
"src/dawn_native/vulkan/SamplerVk.cpp",
"src/dawn_native/vulkan/SamplerVk.h",
"src/dawn_native/vulkan/ShaderModuleVk.cpp",
"src/dawn_native/vulkan/ShaderModuleVk.h",
Memory manager: buffer uploads (Vulkan) - Part 2 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ic2a5df3142fc24fa772b9a85b38248eea8c7e003 Reviewed-on: https://dawn-review.googlesource.com/c/4260 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-06 18:10:12 +00:00
"src/dawn_native/vulkan/StagingBufferVk.cpp",
"src/dawn_native/vulkan/StagingBufferVk.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/SwapChainVk.cpp",
"src/dawn_native/vulkan/SwapChainVk.h",
"src/dawn_native/vulkan/TextureVk.cpp",
"src/dawn_native/vulkan/TextureVk.h",
Complete the sampler object to match WebGPU WebGPUSampler is much more complete than Dawn's Sampler. This patch implement the missing part. BUG=dawn:47 Change-Id: Ief45cb9710493e9d79ddab60fe3be5a123b76ebd Reviewed-on: https://dawn-review.googlesource.com/c/3540 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-04 04:56:08 +00:00
"src/dawn_native/vulkan/UtilsVulkan.cpp",
"src/dawn_native/vulkan/UtilsVulkan.h",
Vulkan: Print the VkResult value on device creation failure. This adds a CheckVkSuccess utility function that adds the VkResult value to the context lost error message. Also adds a small fix to dawn_native/Error.h interoperability between MaybeError and ResultOrError<NonPointer> with tests. BUG=chromium:917555 BUG=dawn:79 Change-Id: Icc01122d62d83693fc0ea3f26b272f2372fd3087 Reviewed-on: https://dawn-review.googlesource.com/c/3623 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-04 10:18:40 +00:00
"src/dawn_native/vulkan/VulkanError.cpp",
"src/dawn_native/vulkan/VulkanError.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/vulkan/VulkanFunctions.cpp",
"src/dawn_native/vulkan/VulkanFunctions.h",
"src/dawn_native/vulkan/VulkanInfo.cpp",
"src/dawn_native/vulkan/VulkanInfo.h",
]
}
}
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# The static and shared libraries for libdawn_native. Most of the files are
# already compiled in libdawn_native_sources, but we still need to compile
# files defining exported symbols.
BUILD.gn: Change the static/shared library template to component This changes the dawn_static_and_shared_library template to be a dawn_component template that mimics the behavior of Chromium's components. This helps avoid issues where on non-component builds on Windows the CRT would get linked statically in both the Dawn shared libraries and the test executables, causing alloc/deallocs across library boundaries to crash. BUG=dawn:29 Change-Id: I69287a523cc0bf5f2e921982ea9c26dcfed82f11 Reviewed-on: https://dawn-review.googlesource.com/c/4040 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-25 03:20:20 +00:00
dawn_component("libdawn_native") {
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
DEFINE_PREFIX = "DAWN_NATIVE"
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
#Make headers publically visible
public_deps = [
":libdawn_native_headers",
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
deps = [
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
":libdawn_native_sources",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
]
sources = [
"src/dawn_native/DawnNative.cpp",
]
configs = [ ":libdawn_native_internal" ]
if (dawn_enable_d3d12) {
sources += [ "src/dawn_native/d3d12/D3D12Backend.cpp" ]
}
if (dawn_enable_metal) {
sources += [ "src/dawn_native/metal/MetalBackend.mm" ]
}
if (dawn_enable_null) {
sources += [ "src/dawn_native/null/NullBackend.cpp" ]
}
if (dawn_enable_opengl) {
sources += [ "src/dawn_native/opengl/OpenGLBackend.cpp" ]
}
if (dawn_enable_vulkan) {
sources += [ "src/dawn_native/vulkan/VulkanBackend.cpp" ]
deps += [ "third_party:vulkan_headers" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
###############################################################################
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
# libdawn_wire
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
###############################################################################
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Generators: main.py is now dawn_json_generator.py This merges all the files for main.py together again except generator_lib.py because there doesn't seeem to be a good way to separate the pure dawn.json generators and the dawn wire generator. Also updates the GN templates to make it easier to define new generators based on generator_lib, and move the Jinja2 template "stdlib" to generator_lib.py BUG=dawn:165 Change-Id: I1b5b2ef0a59cb142e214f3af9a58048a88ae949a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7880 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:03:05 +00:00
dawn_json_generator("libdawn_wire_gen") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
target = "dawn_wire"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
"dawn_wire/WireCmd_autogen.h",
"dawn_wire/WireCmd_autogen.cpp",
Separate WireClient.cpp into multiple files. This patch copies methods and classes from WireClient.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no logical changes are made. Bug: dawn:88 Change-Id: I9d0fcaeb67e789c3ad0597eaa3839adefc3ac5f9 Reviewed-on: https://dawn-review.googlesource.com/c/3980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-16 02:18:06 +00:00
"dawn_wire/client/ApiObjects_autogen.h",
"dawn_wire/client/ApiProcs_autogen.cpp",
"dawn_wire/client/ApiProcs_autogen.h",
Make the wire Client own ObjectAllocators and CommandSerializer This moves ownership of ObjectAllocators and CommandSerializers from the Device to the Client. There may be also be multiple Devices, so New() now takes the Device the object belongs to. Device allocation specializes New() to take the owning Client so that we can get a pointer to the Client from any Dawn API object. Bug: dawn:88 Change-Id: Ie4274d46313884c44a857159e95d236dc1141c0c Reviewed-on: https://dawn-review.googlesource.com/c/4001 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 02:31:37 +00:00
"dawn_wire/client/ClientBase_autogen.h",
Separate WireClient.cpp into multiple files. This patch copies methods and classes from WireClient.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no logical changes are made. Bug: dawn:88 Change-Id: I9d0fcaeb67e789c3ad0597eaa3839adefc3ac5f9 Reviewed-on: https://dawn-review.googlesource.com/c/3980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-16 02:18:06 +00:00
"dawn_wire/client/ClientHandlers_autogen.cpp",
Rename .inl to .inc Bug: chromium:964411 Change-Id: Iff1ff8aadccd3e6ce6abefed983f23241dc19edf Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7341 Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-05-17 20:42:33 +00:00
"dawn_wire/client/ClientPrototypes_autogen.inc",
Separate WireServer.cpp into multiple files. This patch copies methods and classes from WireServer.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no functional changes are made. Bug: dawn:88 Change-Id: I471b8c27804916257eff266a51d087ba1ddbfeb6 Reviewed-on: https://dawn-review.googlesource.com/c/4000 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-30 02:20:58 +00:00
"dawn_wire/server/ServerBase_autogen.h",
Factor wire server handlers into proper command handlers and doers Bug: dawn:88 Change-Id: If637e7ac694d68ad7a4a1e85fd241e8b48e62f6a Reviewed-on: https://dawn-review.googlesource.com/c/4060 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-02-11 19:39:46 +00:00
"dawn_wire/server/ServerDoers_autogen.cpp",
Separate WireServer.cpp into multiple files. This patch copies methods and classes from WireServer.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no functional changes are made. Bug: dawn:88 Change-Id: I471b8c27804916257eff266a51d087ba1ddbfeb6 Reviewed-on: https://dawn-review.googlesource.com/c/4000 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-30 02:20:58 +00:00
"dawn_wire/server/ServerHandlers_autogen.cpp",
Rename .inl to .inc Bug: chromium:964411 Change-Id: Iff1ff8aadccd3e6ce6abefed983f23241dc19edf Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7341 Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-05-17 20:42:33 +00:00
"dawn_wire/server/ServerPrototypes_autogen.inc",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
BUILD.gn: Change the static/shared library template to component This changes the dawn_static_and_shared_library template to be a dawn_component template that mimics the behavior of Chromium's components. This helps avoid issues where on non-component builds on Windows the CRT would get linked statically in both the Dawn shared libraries and the test executables, causing alloc/deallocs across library boundaries to crash. BUG=dawn:29 Change-Id: I69287a523cc0bf5f2e921982ea9c26dcfed82f11 Reviewed-on: https://dawn-review.googlesource.com/c/4040 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-25 03:20:20 +00:00
dawn_component("libdawn_wire") {
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
DEFINE_PREFIX = "DAWN_WIRE"
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
deps = [
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
":libdawn_wire_gen",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Split off libdawn_wire_headers from BUILD.gn These need to be separated from the main BUILD.gn as well. They cannot be easily guarded behind build flags in Chromium because the WebGPUImplementation will extend dawn_wire::CommandSerializer. Bug: dawn:61 Change-Id: Ic7d6bb13cc535ecddb99c832407ba1f37019ed93 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5401 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-03-08 00:51:27 +00:00
"${dawn_root}/src/dawn_wire:libdawn_wire_headers",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs = [ "${dawn_root}/src/common:dawn_internal" ]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
sources = get_target_outputs(":libdawn_wire_gen")
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
sources += [
Create wire Client and Server classes with private impl This creates proper Client and Server interfaces which will be necessary for adding additional features to the Wire for chrome integration Bug: dawn:103 Change-Id: I181e95079b0bac85c2c6152ad8066a94b80c8d28 Reviewed-on: https://dawn-review.googlesource.com/c/4002 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-11 21:50:16 +00:00
"src/dawn_wire/WireClient.cpp",
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
"src/dawn_wire/WireDeserializeAllocator.cpp",
"src/dawn_wire/WireDeserializeAllocator.h",
Create wire Client and Server classes with private impl This creates proper Client and Server interfaces which will be necessary for adding additional features to the Wire for chrome integration Bug: dawn:103 Change-Id: I181e95079b0bac85c2c6152ad8066a94b80c8d28 Reviewed-on: https://dawn-review.googlesource.com/c/4002 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-11 21:50:16 +00:00
"src/dawn_wire/WireServer.cpp",
Separate WireClient.cpp into multiple files. This patch copies methods and classes from WireClient.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no logical changes are made. Bug: dawn:88 Change-Id: I9d0fcaeb67e789c3ad0597eaa3839adefc3ac5f9 Reviewed-on: https://dawn-review.googlesource.com/c/3980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-16 02:18:06 +00:00
"src/dawn_wire/client/ApiObjects.h",
"src/dawn_wire/client/ApiProcs.cpp",
"src/dawn_wire/client/Buffer.cpp",
"src/dawn_wire/client/Buffer.h",
"src/dawn_wire/client/Client.cpp",
"src/dawn_wire/client/Client.h",
Factor wire client handlers into proper command handlers and doers Bug: dawn:88 Change-Id: I3ab28efad7edc7d06f11aa5abae07a1bb3d7e59e Reviewed-on: https://dawn-review.googlesource.com/c/4003 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-30 03:00:17 +00:00
"src/dawn_wire/client/ClientDoers.cpp",
Make the wire Client own ObjectAllocators and CommandSerializer This moves ownership of ObjectAllocators and CommandSerializers from the Device to the Client. There may be also be multiple Devices, so New() now takes the Device the object belongs to. Device allocation specializes New() to take the owning Client so that we can get a pointer to the Client from any Dawn API object. Bug: dawn:88 Change-Id: Ie4274d46313884c44a857159e95d236dc1141c0c Reviewed-on: https://dawn-review.googlesource.com/c/4001 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 02:31:37 +00:00
"src/dawn_wire/client/Device.cpp",
"src/dawn_wire/client/Device.h",
Separate WireClient.cpp into multiple files. This patch copies methods and classes from WireClient.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no logical changes are made. Bug: dawn:88 Change-Id: I9d0fcaeb67e789c3ad0597eaa3839adefc3ac5f9 Reviewed-on: https://dawn-review.googlesource.com/c/3980 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-16 02:18:06 +00:00
"src/dawn_wire/client/Fence.cpp",
"src/dawn_wire/client/Fence.h",
"src/dawn_wire/client/ObjectAllocator.h",
Separate WireServer.cpp into multiple files. This patch copies methods and classes from WireServer.cpp and distributes them over multiple files. Headers and forward declarations are added as necessary, but no functional changes are made. Bug: dawn:88 Change-Id: I471b8c27804916257eff266a51d087ba1ddbfeb6 Reviewed-on: https://dawn-review.googlesource.com/c/4000 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-01-30 02:20:58 +00:00
"src/dawn_wire/server/ObjectStorage.h",
"src/dawn_wire/server/Server.cpp",
"src/dawn_wire/server/Server.h",
"src/dawn_wire/server/ServerBuffer.cpp",
"src/dawn_wire/server/ServerDevice.cpp",
"src/dawn_wire/server/ServerFence.cpp",
"src/dawn_wire/server/ServerQueue.cpp",
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
# Make headers publically visible
public_deps = [
Split off libdawn_wire_headers from BUILD.gn These need to be separated from the main BUILD.gn as well. They cannot be easily guarded behind build flags in Chromium because the WebGPUImplementation will extend dawn_wire::CommandSerializer. Bug: dawn:61 Change-Id: Ic7d6bb13cc535ecddb99c832407ba1f37019ed93 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5401 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
2019-03-08 00:51:27 +00:00
"${dawn_root}/src/dawn_wire:libdawn_wire_headers",
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
###############################################################################
# Utils for tests and samples
###############################################################################
static_library("dawn_utils") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs += [ "${dawn_root}/src/common:dawn_internal" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
sources = [
"src/utils/BackendBinding.cpp",
"src/utils/BackendBinding.h",
Render Pipeline Descriptorization -- Part I This patch remove render pipeline builder and use descriptor to create render pipeline. Sub-objects in descriptor will be removed in future. Bug: dawn:4 Change-Id: I58dd569c7be42c2648311847b939c681189c2854 Reviewed-on: https://dawn-review.googlesource.com/c/2180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2018-12-10 19:47:22 +00:00
"src/utils/ComboRenderPipelineDescriptor.cpp",
"src/utils/ComboRenderPipelineDescriptor.h",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
"src/utils/DawnHelpers.cpp",
"src/utils/DawnHelpers.h",
"src/utils/SystemUtils.cpp",
"src/utils/SystemUtils.h",
"src/utils/TerribleCommandBuffer.cpp",
"src/utils/TerribleCommandBuffer.h",
]
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
public_deps = [
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/dawn:dawn_headers",
[dawn] small fix for BUILD.gn BackendBinding.h includes dawn/dawncpp.h, so dawn_headers_gen needs to be in public_deps. See below reference for more details. https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps Applied `gn format` too. Bug: chromium:931596 Change-Id: I8572ba54b56c96950a58ec068ba797b3031f3c01 Reviewed-on: https://dawn-review.googlesource.com/c/4640 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-02-13 18:42:38 +00:00
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
":libdawn_native",
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
":libdawn_wire",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
Roll shaderc and glslang and use their BUILD.gn This rolls glslang and shaderc to be able to use their BUILD.gn files, and also rolls SPIRV-Tools and spirv-headers to have compatible versions. BUG=chromium:870747 Change-Id: I13c615f6f3d148c9b69f06547992bf5910e04e62 Reviewed-on: https://dawn-review.googlesource.com/c/1680 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-04 17:17:57 +00:00
"${dawn_shaderc_dir}:libshaderc",
Support creating default texture view on 2D array textures This patch intends to implement creating default texture view on 2D array textures. BUG=dawn:16 Change-Id: I4321c9506b2e875146645ad60291196dcfcc8ea0 Reviewed-on: https://dawn-review.googlesource.com/c/1660 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2018-10-09 00:31:58 +00:00
"third_party:glfw",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
libs = []
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
if (dawn_enable_d3d12) {
sources += [ "src/utils/D3D12Binding.cpp" ]
}
if (dawn_enable_metal) {
sources += [ "src/utils/MetalBinding.mm" ]
libs += [
"Metal.framework",
"QuartzCore.framework",
]
# Suppress warnings that Metal isn't in the deployment target of Chrome
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
}
if (dawn_enable_null) {
sources += [ "src/utils/NullBinding.cpp" ]
}
if (dawn_enable_opengl) {
sources += [ "src/utils/OpenGLBinding.cpp" ]
}
if (dawn_enable_vulkan) {
sources += [ "src/utils/VulkanBinding.cpp" ]
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
deps += [ "third_party:vulkan_headers" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
}
###############################################################################
# Dawn test targets
###############################################################################
Generators: main.py is now dawn_json_generator.py This merges all the files for main.py together again except generator_lib.py because there doesn't seeem to be a good way to separate the pure dawn.json generators and the dawn wire generator. Also updates the GN templates to make it easier to define new generators based on generator_lib, and move the Jinja2 template "stdlib" to generator_lib.py BUG=dawn:165 Change-Id: I1b5b2ef0a59cb142e214f3af9a58048a88ae949a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7880 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:03:05 +00:00
dawn_json_generator("mock_dawn_gen") {
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
target = "mock_dawn"
outputs = [
"mock/mock_dawn.h",
"mock/mock_dawn.cpp",
]
}
test("dawn_unittests") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs += [ "${dawn_root}/src/common:dawn_internal" ]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
":dawn_utils",
Add static library versions of libdawn* Chromium will want to have both static and shared library versions of Dawn to use in non-component and component builds respectively. The *_export.h files are modified to noop when *_SHARED_LIBRARY is not defined so that the static library doesn't export symbols that aren't imported in dependents (this would break compilation on Windows). A dawn_library_combo is introduced in BUILD.gn that factors out all the logic needed to produce shared libraries and handle the _EXPORT macros. Also contains a fix to dawncpp to export only the methods that aren't defined in the header (otherwise they get defined multiple times) BUG=dawn:85 Change-Id: Ib747deb9308e1165dd66002487147ba279d3eac0 Reviewed-on: https://dawn-review.googlesource.com/c/3761 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-01-09 09:05:18 +00:00
":libdawn_native",
Add wire_cmd.py and dawn_wire.json to autogenerate all wire commands. Unify code generation for Client->Server and Server->Client commands. Methods in dawn.json are converted into command records and additional commands are specified in dawn_wire.json. This can then be used to completely generate the command handlers and command struct definitions. Bug: dawn:88 Change-Id: Ic796796ede0aafe02e14f1f96790324dad92f4c0 Reviewed-on: https://dawn-review.googlesource.com/c/3800 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-01-15 20:49:53 +00:00
":libdawn_native_sources",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
":libdawn_wire",
":mock_dawn_gen",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
"${dawn_root}/src/dawn:libdawn",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"third_party:gmock_and_gtest",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
# Add internal Dawn Native headers and config for internal unittests.
deps += [ ":libdawn_native_headers" ]
configs += [ ":libdawn_native_internal" ]
sources = get_target_outputs(":mock_dawn_gen")
sources += [
"src/tests/unittests/BitSetIteratorTests.cpp",
"src/tests/unittests/CommandAllocatorTests.cpp",
"src/tests/unittests/EnumClassBitmasksTests.cpp",
"src/tests/unittests/ErrorTests.cpp",
"src/tests/unittests/MathTests.cpp",
"src/tests/unittests/ObjectBaseTests.cpp",
"src/tests/unittests/PerStageTests.cpp",
"src/tests/unittests/RefCountedTests.cpp",
"src/tests/unittests/ResultTests.cpp",
Memory manager: buffer uploads (D3D) - Part 1 Manages a single persistently mapped GPU heap which is sub-allocated inside of ring-buffer for uploads. To handle larger buffers without additional unused heaps, ring buffers are created on-demand. BUG=dawn:28 TEST=dawn_unittests Change-Id: Ifc5a1b06baf8633f1e133245ac1ee76275431cc5 Reviewed-on: https://dawn-review.googlesource.com/c/3160 Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-29 00:10:07 +00:00
"src/tests/unittests/RingBufferTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/SerialMapTests.cpp",
"src/tests/unittests/SerialQueueTests.cpp",
"src/tests/unittests/ToBackendTests.cpp",
"src/tests/unittests/validation/BindGroupValidationTests.cpp",
"src/tests/unittests/validation/BufferValidationTests.cpp",
"src/tests/unittests/validation/CommandBufferValidationTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/unittests/validation/ComputeIndirectValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/ComputeValidationTests.cpp",
"src/tests/unittests/validation/CopyCommandsValidationTests.cpp",
Implementation of Debug Marker APIs Introduces pushDebugGroup, popDebugGroup, and insertDebugMarker implementations for Vulkan and Metal using VK_EXT_debug_marker and XCode, respectively. Bug: dawn:44 Change-Id: I0ae56c4d67aa832123f27a1fcdddf65746261e57 Reviewed-on: https://dawn-review.googlesource.com/c/4241 Commit-Queue: Brandon Jones <brandon1.jones@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-20 20:21:00 +00:00
"src/tests/unittests/validation/DebugMarkerValidationTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/unittests/validation/DrawIndirectValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/DynamicStateCommandValidationTests.cpp",
"src/tests/unittests/validation/FenceValidationTests.cpp",
"src/tests/unittests/validation/QueueSubmitValidationTests.cpp",
"src/tests/unittests/validation/RenderPassDescriptorValidationTests.cpp",
Fix null pointer dereference in CommandBufferStateTracker The CommandBufferStateTracker dereferences a null pointer if there is no bind group set for an index of the layout Change-Id: Id247f9876340d189088e8bbe8cb4d68a4d517c6e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6100 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-03-28 15:28:01 +00:00
"src/tests/unittests/validation/RenderPassValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/RenderPipelineValidationTests.cpp",
dawn_native: handle NaN lod values in samplers For samplers with NaN mLodMinClamp or mLodMaxClamp, the equality operator returned false. Adds checks for finite values, and also early returns if two pointers are equal. Bug: dawn:143, chromium:965633 Change-Id: Id5998d6eec275af0fbe30e3b4fcb3eed4fe64c6a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7401 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-05-22 17:18:52 +00:00
"src/tests/unittests/validation/SamplerValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/ShaderModuleValidationTests.cpp",
Make TextureDescriptor match WebGPU IDL This patch updates the definition of TextureDescriptor to make it match WebGPU IDL: 1. Rename 'arrayLayer' to 'arraySize' 2. Add the missing member "sampleCount" and check that currently sampleCount can only be 1. BUG=dawn:56 TEST=dawn_unittests Change-Id: I642186529f045865ae344cb5545ac80e14445c59 Reviewed-on: https://dawn-review.googlesource.com/c/3180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-12 09:27:16 +00:00
"src/tests/unittests/validation/TextureValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/TextureViewValidationTests.cpp",
Emulate store and multisample resolve on Metal This patch implements "store and MSAA resolve" store operation on Metal drivers that don't support MTLStoreActionStoreAndMultisampleResolve with a workaround that does MSAA resolve in another render pass. Driver workaround is one type of Dawn Toggles. Dawn Toggles will include other optional optimizations and features that can be configured to use or not when we create Dawn Devices. As all Metal try bots don't need this toggle, to better test this patch on the try bots: 1. We add the support of forcing enabling a workaround when starting an Dawn end2end test so that we can test the workaround on the platforms where the workaround is disabled. 2. We add an optional parameter DeviceDescriptor to CreateDevice() so that we can custom the toggles the Dawn device should use. This patch also adds the support of querying toggle details from Instance and the names of the toggles in use from Device. These APIs are tested in the Dawn unittests added in this patch. BUG=dawn:56 TEST=dawn_end2end_tests TEST=dawn_unittests Change-Id: Iae31d2ded6057eee638b6099d3061e9d78b04d55 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6620 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-04-26 07:52:57 +00:00
"src/tests/unittests/validation/ToggleValidationTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/unittests/validation/ValidationTest.cpp",
"src/tests/unittests/validation/ValidationTest.h",
"src/tests/unittests/validation/VertexBufferValidationTests.cpp",
Update VertexInput (InputState) to match spec - Part 1 This is only a renaming: change VertexInput to VertexBuffer, and change InputState to VertexInput. The next two patches will do as follows: 1) change the structure of vertex input descriptor related stuff. 2) change num to count. BUG=dawn:80, dawn:107 Change-Id: Ie76aa653a527759a9c3b4a4792e3254689f053b8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7420 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-05-22 22:46:32 +00:00
"src/tests/unittests/validation/VertexInputValidationTests.cpp",
Split wire tests into multiple test files Bug: dawn:104 Change-Id: I0dc46dabc92c98df13dbf596dea63aeaaea85d3d Reviewed-on: https://dawn-review.googlesource.com/c/4562 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-14 18:47:07 +00:00
"src/tests/unittests/wire/WireArgumentTests.cpp",
"src/tests/unittests/wire/WireBasicTests.cpp",
"src/tests/unittests/wire/WireBufferMappingTests.cpp",
Nuke Builders Part 1: remove the testing BufferBuilder. This requires deleting wire tests for builders that were using it, and leads to small simplifications in the WireTest harness. Also allows removing the BuilderBase class from dawn_native. BUG=dawn:125 Change-Id: I3cbac609207aa652cdc9d37e0b700cce3ac6e093 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6120 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-28 17:12:47 +00:00
"src/tests/unittests/wire/WireErrorCallbackTests.cpp",
Split wire tests into multiple test files Bug: dawn:104 Change-Id: I0dc46dabc92c98df13dbf596dea63aeaaea85d3d Reviewed-on: https://dawn-review.googlesource.com/c/4562 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-14 18:47:07 +00:00
"src/tests/unittests/wire/WireFenceTests.cpp",
Add dawn_wire entrypoints to inject texture in the wire This allows reserving a texture ID in the client and injecting textures in the wire, so that the WebGPU control channel can create WebGPU textures backed by SharedImages in Chromium. BUG=941543 Change-Id: I1efcfe3dce024bb2d3592f22225407a97b641c1f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5820 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-28 12:57:11 +00:00
"src/tests/unittests/wire/WireInjectTextureTests.cpp",
Split wire tests into multiple test files Bug: dawn:104 Change-Id: I0dc46dabc92c98df13dbf596dea63aeaaea85d3d Reviewed-on: https://dawn-review.googlesource.com/c/4562 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-14 18:47:07 +00:00
"src/tests/unittests/wire/WireOptionalTests.cpp",
"src/tests/unittests/wire/WireTest.cpp",
"src/tests/unittests/wire/WireTest.h",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
]
if (dawn_enable_d3d12) {
sources += [ "src/tests/unittests/d3d12/CopySplitTests.cpp" ]
}
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
sources += [ "//gpu/dawn_unittests_main.cc" ]
} else {
sources += [ "src/tests/UnittestsMain.cpp" ]
}
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
test("dawn_end2end_tests") {
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
configs += [ "${dawn_root}/src/common:dawn_internal" ]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
":dawn_utils",
":libdawn_native",
":libdawn_wire",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
"${dawn_root}/src/dawn:libdawn",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"third_party:glfw",
"third_party:gmock_and_gtest",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
sources = [
"src/tests/DawnTest.cpp",
"src/tests/DawnTest.h",
"src/tests/end2end/BasicTests.cpp",
"src/tests/end2end/BindGroupTests.cpp",
"src/tests/end2end/BufferTests.cpp",
Fix clip space on D3D12 and OpenGL The range of the Z-coordinate in clipping volume is [-w, w] on OpenGL, while it is [0, w] on D3D12, Metal and Vulkan. In this patch, the "fixup_clipspace" flag of SPIRV-Cross is enabled on OpenGL backend and disabled on D3D12 backend to unify the behaviour of clip space on all Dawn backends. An end2end test is also added for this fix. This patch also fix a bug when clearing depth stencil attachments on OpenGL backend. Before clearing depth stencil attachments, we should enable depth stencil writing by properly setting depth and stencil masks. We do not need to set the depth and stencil masks back because they will be set again when applying the render pipeline. The newly added test will fail without this fix when running the test together with all the end2ends. BUG=dawn:122 TEST=dawn_end2end_tests Change-Id: I4f50ce3eb1f16d731ee4cffc12a56e17844b4675 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5860 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-03-27 00:01:33 +00:00
"src/tests/end2end/ClipSpaceTests.cpp",
Rename BlendState to ColorState, in order to match web idl BUG=dawn:106 Change-Id: Id2cb1788becfacd09bd7f420d6525d22f96d1fe2 Reviewed-on: https://dawn-review.googlesource.com/c/4781 Commit-Queue: Yunchao He <yunchao.he@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-02-16 02:27:30 +00:00
"src/tests/end2end/ColorStateTests.cpp",
Support BC5 formats on Vulkan This patch supports BC5 formats on Vulkan backends and adds related Dawn end2end tests. For the textures with BC formats, they could have non-multiple-of-4 sizes on the non-zero mipmap levels in sampling, but we are still required to provide texture data in complete 4x4 blocks in texture copies because that is the size of which they are stored in GPU memory. In this patch, we refer the term "physical memory size" as the memory size of the texture subresource in GPU memory, and the term "virtual memory size" as the size used in texture sampling. As Dawn requires the Extent3D in texture copies must fit in the physical memory size, while Vulkan requires it must fit in the virtual memory size, this patch recalculates the imageExtent to ensure it always follow this Vulkan validation rules. For Dawn end2end tests, note that we use pure green and pure red for the textures because BC5 does not support SRGB formats. Furthermore, "CopyPartofTextureSubResourceIntoNonZeroMipmapLevel" is skipped in this patch because there is an issue on the T2T copies from a region within the virtual size of one texture to another one that exceeds the virtual size of another texture in Vulkan SPEC. BUG=dawn:42 TEST=dawn_end2end_tests Change-Id: I17518cd335fb13125cb753bbf879bc06eb20e426 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8260 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2019-07-02 23:55:55 +00:00
"src/tests/end2end/CompressedTextureFormatTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/ComputeCopyStorageBufferTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/end2end/ComputeIndirectTests.cpp",
Add a basic compute shared memory test Change-Id: I6fab17d59d58434d10def29923e71106605c4f32 Bug: None Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6580 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-04-26 02:08:12 +00:00
"src/tests/end2end/ComputeSharedMemoryTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/CopyTests.cpp",
Implement Culling and FrontFace This patch implements Culling and FrontFace on backends, and add tests too. This test also verified that we couldn't invert FrontFace on Metal backend. Otherwise, the tests would fail on all HWs. But we do need to invert CCW/CW on OpenGL backend. Because Y axis is up in OpenGL while Y axis is down in WebGPU. Bug=dawn:43 Change-Id: I7dd0922477397a13c5f7208e104ff352a673a556 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8420 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-07-06 00:11:10 +00:00
"src/tests/end2end/CullingTests.cpp",
Implementation of Debug Marker APIs Introduces pushDebugGroup, popDebugGroup, and insertDebugMarker implementations for Vulkan and Metal using VK_EXT_debug_marker and XCode, respectively. Bug: dawn:44 Change-Id: I0ae56c4d67aa832123f27a1fcdddf65746261e57 Reviewed-on: https://dawn-review.googlesource.com/c/4241 Commit-Queue: Brandon Jones <brandon1.jones@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-20 20:21:00 +00:00
"src/tests/end2end/DebugMarkerTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/DepthStencilStateTests.cpp",
Destroy frontend and backend for Textures Same idea as for buffers, Destroy can be used to free GPU memory associated with resources without waiting for javascript garbage collection to occur. Bug: dawn:46 Change-Id: Ia796b06b5228cbec4cfe8d78a500f967181d8c1f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5540 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com>
2019-03-27 22:04:10 +00:00
"src/tests/end2end/DestroyTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/end2end/DrawIndexedIndirectTests.cpp",
Implement 'baseVertex' in drawIndexed() on D3D12, Metal and Vulkan This patch adds the support of the parameter 'baseVertex' of drawIndexed on D3D12, Metal and Vulkan back-ends. BUG=dawn:51 TEST=dawn_end2end_tests Change-Id: Ibd25884ad2abceaaed744d74c4ee6b0ae6b3fa1b Reviewed-on: https://dawn-review.googlesource.com/c/3221 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-12-13 01:05:26 +00:00
"src/tests/end2end/DrawIndexedTests.cpp",
Reland "dawn_native: Indirect draw/dispatch" This is a reland of 7eb6be186be60a536a9f529b514bb5c5fd79293d Fixes casting issue on 32 bit machines Original change's description: > dawn_native: Indirect draw/dispatch > > Adds indirect draw and dispatch for all backends (without validation). > > Tests for opengl negative offset are skipped since there is no easy > way to add the index buffer offset. Current idea is to use a compute > shader to modify the indirect draw buffer. > > Change-Id: I1d3eec7c699b211423f4b911769cca17bfbcd045 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7481 > Commit-Queue: Idan Raiter <idanr@google.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> Change-Id: Id28c5658ee18ec5c030f721fb44d9f11ebe21ff9 Bug:dawn:54,chromium:972358 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7961 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
2019-06-10 20:56:27 +00:00
"src/tests/end2end/DrawIndirectTests.cpp",
Fix non-zero validation in Draw and DrawIndexed Metal validation layer does not allow indexCount or instanceCount to be 0 in drawIndexedPrimitives and drawPrimitives, otherwise we should draw nothing with these operations. BUG=dawn:76 TEST=dawn_end2end_tests Change-Id: Ic22be73ac992289d4bc8d7b3d4d30d20c4488776 Reviewed-on: https://dawn-review.googlesource.com/c/3900 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-01-30 09:01:08 +00:00
"src/tests/end2end/DrawTests.cpp",
Dynamic Buffer Offset : Metal Backend In a typical application, most draws will use different uniforms values for things like the world position and orientation. In the current state of WebGPU this means that a new bind group needs to be created for each draw to set the right uniforms. Bind group creation is expected to be more expensive than recording draws because they incur an allocation. This feature is to reduce the number of bind groups that need to be created. The patch implemented dynamic buffer offset on metal backend. Bug=dawn:55 Change-Id: I34f397ec9ec10fa5b8e8a1c029d2d6a19e8dc0ee Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7320 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
2019-05-23 00:45:12 +00:00
"src/tests/end2end/DynamicBufferOffsetTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/FenceTests.cpp",
"src/tests/end2end/IndexFormatTests.cpp",
Support multisampled rendering on OpenGL This patch adds the support of multisampled rendering on OpenGL backends and the related end2end tests to test all new features implemented in this patch. BUG=dawn:56 TEST=dawn_end2end_tests Change-Id: I91e462178ee39041ef591503c33c70db511775e9 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5880 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2019-03-28 14:18:11 +00:00
"src/tests/end2end/MultisampledRenderingTests.cpp",
Create nonzero_clear_resources_on_creation_for_testing toggle Created toggle to force texture clearing to 1 bits in order to test the logic of lazy clearing. Bug: dawn:145 Change-Id: I83bc32f046159c709c426b77458fbdf115f7bfd0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7120 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Natasha Lee <natlee@microsoft.com>
2019-05-11 00:21:50 +00:00
"src/tests/end2end/NonzeroTextureCreationTests.cpp",
dawn_native: deduplicate pipeline layouts This is the first step to do pipeline deduplication. It also introduces tests for deduplication. BUG=dawn:143 Change-Id: Ib22496f543f8d1f9cfde04f725612504132c7d72 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6861 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-05-01 12:57:27 +00:00
"src/tests/end2end/ObjectCachingTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/PrimitiveTopologyTests.cpp",
"src/tests/end2end/RenderPassLoadOpTests.cpp",
D3D12: Remove RenderPassDescriptorD3D12 This patch removes RenderPassDescriptorD3D12 completely and moves the creation of RTVs and DSVs to CommandBufferD3D12::RecordCommands(), where we allocate all RTVs and DSVs used in the current command buffer in one RTV heap and one DSV heap. Note that the method to allocate RTVs and DSVs are too simple in this patch, and we will optimize it later. This patch also adds a test to make sure Dawn works correctly when we use two different render passes in one command buffer. This patch is one of the preparations on completely removing RenderPassDescriptorBuilder from Dawn. BUG=dawn:6 Change-Id: I02e30c007fb8668a7474a3caf7a858782d0c92df Reviewed-on: https://dawn-review.googlesource.com/c/4520 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-02-15 10:55:08 +00:00
"src/tests/end2end/RenderPassTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/SamplerTests.cpp",
"src/tests/end2end/ScissorTests.cpp",
Add most WebGPU texture formats on Vulkan This adds the formats to dawn.json, implements support in the Vulkan backend and adds tests performing basic sampling checks for all formats. The R8UnormSrgb and RG8UnormSrgb formats skipped because they are not required in Vulkan (and RG8UnormSrgb is in fact not supported on the machine used for developing this CL). A PR will be sent to the WebGPU repo to remove the from the initial list of formats. The RG11B10Float and RGB10A2Unorm formats of WebGPU are replaced with B10GR11Float and A2RGB10Unorm that are the formats exposed by Vulkan. It is likely that all APIs implement them with components stored in that order. Each format except depth-stencil ones is tested by uploading some interesting texel data and checking that sampling from the texture produces correct results. The goal is to make sure that backends don't make a mistake in the giant switch statements. There was no effort made to check the hardware implementation of the formats. Tests will later be extended to cover rendering and clearing operations as well as multisample resolve. It isn't clear if depth-stencil format will support TRANSFER operations in WebGPU so these are left untested for now. BUG=dawn:128 Change-Id: I78ac5bf77b57398155551e6db3de50b478d69452 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8363 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-07-01 09:58:07 +00:00
"src/tests/end2end/TextureFormatTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/TextureViewTests.cpp",
Clear Vulkan Textures at first usage This prevents dirty textures to be used when memory is recycled while destroying/creating textures. If a texture is not cleared at load, it will be cleared to 0 before it is used. Bug: dawn:145 Change-Id: Ia3f02427478fb48649089829186ccb377caa1912 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6960 Commit-Queue: Natasha Lee <natlee@microsoft.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2019-06-11 18:11:05 +00:00
"src/tests/end2end/TextureZeroInitTests.cpp",
Add end2end test for all vertex formats BUG=dawn:41 Change-Id: I37bde37843522a8d7c8b3bea1cb24c0971efd8e2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6340 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
2019-04-26 15:25:18 +00:00
"src/tests/end2end/VertexFormatTests.cpp",
Update VertexInput (InputState) to match spec - Part 1 This is only a renaming: change VertexInput to VertexBuffer, and change InputState to VertexInput. The next two patches will do as follows: 1) change the structure of vertex input descriptor related stuff. 2) change num to count. BUG=dawn:80, dawn:107 Change-Id: Ie76aa653a527759a9c3b4a4792e3254689f053b8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7420 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-05-22 22:46:32 +00:00
"src/tests/end2end/VertexInputTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
"src/tests/end2end/ViewportOrientationTests.cpp",
Implement RenderPassEncoder::SetViewport: add end2end tests The main aim of this CL is to add tests for SetViewport. But it also implements the feature on Vulkan backend to verify the tests. BUG=dawn:53 TEST=dawn_end2end_tests Change-Id: I9578b2d9650cb952ce67cf91f79e9682c9932ee3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8820 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Yunchao He <yunchao.he@intel.com>
2019-07-16 19:27:09 +00:00
"src/tests/end2end/ViewportTests.cpp",
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
]
Implement wrapping IOSurfaces in dawn::Texture. This allows wrapping IOSurfaces in a dawn::Texture so a Dawn application can sample from, or render to an IOSurface. It uses Metal's functionality for wrapping textures in MTLTexture. Support for single-plane BGRA8, RG8 and R8 IOSurfaces is added as well as tests for sampling and using BeginRenderPass to clear them. BUG=dawn:112 Change-Id: I367dbd1a75a0c7b81901fb0aae05f1cd46af3f3a Reviewed-on: https://dawn-review.googlesource.com/c/5101 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
2019-03-01 12:01:18 +00:00
libs = []
if (dawn_enable_metal) {
sources += [ "src/tests/end2end/IOSurfaceWrappingTests.cpp" ]
libs += [ "IOSurface.framework" ]
}
Revert "Create new src/tests BUILD.gn file." This reverts commit 672d29d14c26e39341d75b8d1dc1a4e7ee4b6f66. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=913171 Original change's description: > Create new src/tests BUILD.gn file. > > Move all test-related build stuff into its own BUILD.gn file. This > required moving the dawn_generator template into a common file, so it > can be called by both BUILD.gn and src/tests/BUILD.gn. > > [This is a reland of https://dawn-review.googlesource.com/c/dawn/+/2940 > with a fix for mock_dawn.] > > Bug: dawn:61 > Change-Id: Id1e6d0c2b07caa2610cebe206511e972ac18fe8d > Reviewed-on: https://dawn-review.googlesource.com/c/3020 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,senorblanco@chromium.org Change-Id: I54cdc558b128935dc8a8d22ec2b5e879271c35ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://dawn-review.googlesource.com/c/3080 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-08 10:35:53 +00:00
# When building inside Chromium, use their gtest main function because it is
# needed to run in swarming correctly.
if (build_with_chromium) {
sources += [ "//gpu/dawn_end2end_tests_main.cc" ]
} else {
sources += [ "src/tests/End2EndTestsMain.cpp" ]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
BUILD.gn: Add temporary proxy groups for test targets This will allow use to update gn_isolate_map_pyl to point to the groups instead of the targets, while we move the actual targets in a different file. BUG=chromium:913171 Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1 Reviewed-on: https://dawn-review.googlesource.com/c/3100 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-10 16:45:24 +00:00
# Temporary groups to make a 5-way patch to fix crbug.com/913171
group("dawn_unittests_temp_group") {
testonly = true
Make TextureDescriptor match WebGPU IDL This patch updates the definition of TextureDescriptor to make it match WebGPU IDL: 1. Rename 'arrayLayer' to 'arraySize' 2. Add the missing member "sampleCount" and check that currently sampleCount can only be 1. BUG=dawn:56 TEST=dawn_unittests Change-Id: I642186529f045865ae344cb5545ac80e14445c59 Reviewed-on: https://dawn-review.googlesource.com/c/3180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-12 09:27:16 +00:00
deps = [
":dawn_unittests",
]
BUILD.gn: Add temporary proxy groups for test targets This will allow use to update gn_isolate_map_pyl to point to the groups instead of the targets, while we move the actual targets in a different file. BUG=chromium:913171 Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1 Reviewed-on: https://dawn-review.googlesource.com/c/3100 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-10 16:45:24 +00:00
}
group("dawn_end2end_tests_temp_group") {
testonly = true
Make TextureDescriptor match WebGPU IDL This patch updates the definition of TextureDescriptor to make it match WebGPU IDL: 1. Rename 'arrayLayer' to 'arraySize' 2. Add the missing member "sampleCount" and check that currently sampleCount can only be 1. BUG=dawn:56 TEST=dawn_unittests Change-Id: I642186529f045865ae344cb5545ac80e14445c59 Reviewed-on: https://dawn-review.googlesource.com/c/3180 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-12 09:27:16 +00:00
deps = [
":dawn_end2end_tests",
]
BUILD.gn: Add temporary proxy groups for test targets This will allow use to update gn_isolate_map_pyl to point to the groups instead of the targets, while we move the actual targets in a different file. BUG=chromium:913171 Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1 Reviewed-on: https://dawn-review.googlesource.com/c/3100 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-12-10 16:45:24 +00:00
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
###############################################################################
# Dawn samples, only in standalone builds
###############################################################################
if (dawn_standalone) {
# Static library to contain code and dependencies common to all samples
static_library("dawn_sample_utils") {
sources = [
"examples/SampleUtils.cpp",
"examples/SampleUtils.h",
]
# Export all of these as public deps so that `gn check` allows includes
public_deps = [
":dawn_utils",
":libdawn_native",
":libdawn_wire",
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
"${dawn_root}/src/common",
"${dawn_root}/src/dawn:libdawn",
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
"third_party:glfw",
]
Split off common and libdawn / dawn_headers from BUILD.gn This adds an option to dawn_generator to generate files in a different directory so the generated stay at the same place. Otherwise compilation errors occur because of stale versions of the headers on the CQ builders. BUG=dawn:61 Change-Id: I71ceb3172b5a4e35911973a03be29d90fa684416 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/5304 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-03-07 01:46:39 +00:00
public_configs = [ "${dawn_root}/src/common:dawn_internal" ]
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
}
# Template for samples to avoid listing dawn_sample_utils as a dep every time
template("dawn_sample") {
executable(target_name) {
deps = [
":dawn_sample_utils",
]
forward_variables_from(invoker, "*", [ "deps" ])
if (defined(invoker.deps)) {
deps += invoker.deps
}
}
}
dawn_sample("CppHelloTriangle") {
sources = [
"examples/CppHelloTriangle.cpp",
]
}
dawn_sample("CHelloTriangle") {
sources = [
"examples/CHelloTriangle.cpp",
]
}
dawn_sample("ComputeBoids") {
sources = [
"examples/ComputeBoids.cpp",
]
deps = [
"third_party:glm",
]
}
dawn_sample("Animometer") {
sources = [
"examples/Animometer.cpp",
]
}
dawn_sample("CubeReflection") {
sources = [
"examples/CubeReflection.cpp",
]
deps = [
"third_party:glm",
]
}
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
group("dawn_samples") {
deps = [
Fix for D3D12 re-used bindgroup bug. If a bindgroup was re-used in multiple command buffers in a single call to queue.Submit(), it was skipping the creation of the corresponding descriptor heap for that bind group in the second command buffer. The fix is to use the command buffer's index into the submit command as part of the key for the bind group's descriptor heap. Change-Id: Ie66a0e772b10cc72bf040f090dac4c4a10f24266 Reviewed-on: https://dawn-review.googlesource.com/c/1740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-10-04 16:59:05 +00:00
":Animometer",
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
":CHelloTriangle",
":ComputeBoids",
Fix for D3D12 re-used bindgroup bug. If a bindgroup was re-used in multiple command buffers in a single call to queue.Submit(), it was skipping the creation of the corresponding descriptor heap for that bind group in the second command buffer. The fix is to use the command buffer's index into the submit command as part of the key for the bind group's descriptor heap. Change-Id: Ie66a0e772b10cc72bf040f090dac4c4a10f24266 Reviewed-on: https://dawn-review.googlesource.com/c/1740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-10-04 16:59:05 +00:00
":CppHelloTriangle",
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
":CubeReflection",
]
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
}
Add fuzzers for SPIRV-Cross This CL adds in fuzzers for SPIRV-Cross for HLSL, GLSL, and MSL outputs. These fuzzers live in Dawn because there is not appropriate location in the Chromium source repo for them and it is unlikely they would be land-able in the SPIRV-Cross repo, because it is not coupled with Chromium's build system and thus Clusterfuzz so would be effectively dead code. Dawn depends on this code, but it is also integrated into the Chromium build system, so this was the best place I could find for them The code under fuzz unfortunately uses exceptions/aborting as its error reporting mechanism. This is an acknowledge short coming and there are efforts to remove this behaviour. To work around this and reduce the number of false positives found by the fuzzers, a signal trap has been implemented which will be removed once the code under fuzz has been updated. The trap replaces the existing signal handler and silencing signals while running the code under test. This allows the code under test to call abort() and not crash the fuzzing process. Theoretically, only SIGABRT should need to be trapped, but something is causing the signal from abort() to be converted to SIGSEGV when running under ASAN. This signal trap has been tested with the fuzzing/sanitizers by intentionally inserting bad calls that will occur after a few thousand test cases. It was confirmed that the fuzzer detected the issue and stops fuzzing. The alternate to implementing this signal trap would be to turn on exceptions for the fuzzer. This was attempted, but proved to be fruitless due to what was reported as an ODR issue, but couldn't couldn't be silenced. The likely underlying issue was a pre-built library or other object being built without exceptions was causing different versions of symbols or the exception version of the standard library not being instrumented by ASAN. Given the majority of Chromium eco-system turns off exceptions, fixing this issue would not be helpful to the larger community and was looking like it would require significant effort. BUG=chromium:903380 Change-Id: I63a5595383f99b7a0e150d72bb04c89b8d722631 Reviewed-on: https://dawn-review.googlesource.com/c/2260 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-11-12 12:20:21 +00:00
###############################################################################
# Fuzzers
###############################################################################
Build fuzzer tests in standalone builds too. This will avoid compilation to break, and adds standalone reproducers for the fuzzer_tests. BUG=chromium:903380 BUG=dawn:34 Change-Id: I9995a852076d9f6d1ebdee5b999989c2d74d4709 Reviewed-on: https://dawn-review.googlesource.com/c/2321 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Dan Sinclair <dsinclair@google.com>
2018-11-12 18:09:56 +00:00
group("dawn_fuzzers") {
testonly = true
deps = [
"src/fuzzers:dawn_spirv_cross_glsl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_hlsl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_msl_fast_fuzzer",
"src/fuzzers:dawn_wire_server_and_frontend_fuzzer",
]
Add fuzzers for SPIRV-Cross This CL adds in fuzzers for SPIRV-Cross for HLSL, GLSL, and MSL outputs. These fuzzers live in Dawn because there is not appropriate location in the Chromium source repo for them and it is unlikely they would be land-able in the SPIRV-Cross repo, because it is not coupled with Chromium's build system and thus Clusterfuzz so would be effectively dead code. Dawn depends on this code, but it is also integrated into the Chromium build system, so this was the best place I could find for them The code under fuzz unfortunately uses exceptions/aborting as its error reporting mechanism. This is an acknowledge short coming and there are efforts to remove this behaviour. To work around this and reduce the number of false positives found by the fuzzers, a signal trap has been implemented which will be removed once the code under fuzz has been updated. The trap replaces the existing signal handler and silencing signals while running the code under test. This allows the code under test to call abort() and not crash the fuzzing process. Theoretically, only SIGABRT should need to be trapped, but something is causing the signal from abort() to be converted to SIGSEGV when running under ASAN. This signal trap has been tested with the fuzzing/sanitizers by intentionally inserting bad calls that will occur after a few thousand test cases. It was confirmed that the fuzzer detected the issue and stops fuzzing. The alternate to implementing this signal trap would be to turn on exceptions for the fuzzer. This was attempted, but proved to be fruitless due to what was reported as an ODR issue, but couldn't couldn't be silenced. The likely underlying issue was a pre-built library or other object being built without exceptions was causing different versions of symbols or the exception version of the standard library not being instrumented by ASAN. Given the majority of Chromium eco-system turns off exceptions, fixing this issue would not be helpful to the larger community and was looking like it would require significant effort. BUG=chromium:903380 Change-Id: I63a5595383f99b7a0e150d72bb04c89b8d722631 Reviewed-on: https://dawn-review.googlesource.com/c/2260 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-11-12 12:20:21 +00:00
}