From 031e529714fb0ab6f44aac8734d1ccd82fc2278b Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Wed, 13 Apr 2022 08:53:36 +0000 Subject: [PATCH] Remove redundant virtual. This CL removes a redundant virtual and enables the readability/inheritance lint in src/dawn Bug: dawn:1339 Change-Id: I3dcc84894b8d308461219a5ea206ca31300de297 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86504 Auto-Submit: Dan Sinclair Reviewed-by: Corentin Wallez Commit-Queue: Corentin Wallez --- src/dawn/CPPLINT.cfg | 1 - src/dawn/native/d3d12/BufferD3D12.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dawn/CPPLINT.cfg b/src/dawn/CPPLINT.cfg index 1a4d058ed0..82132f2682 100644 --- a/src/dawn/CPPLINT.cfg +++ b/src/dawn/CPPLINT.cfg @@ -2,7 +2,6 @@ filter=-build/include_order filter=-build/include_what_you_use filter=-build/namespaces filter=-readability/casting -filter=-readability/inheritance filter=-readability/namespace filter=-runtime/explicit filter=-runtime/indentation_namespace diff --git a/src/dawn/native/d3d12/BufferD3D12.h b/src/dawn/native/d3d12/BufferD3D12.h index 8d10bbbcae..cdca5600e9 100644 --- a/src/dawn/native/d3d12/BufferD3D12.h +++ b/src/dawn/native/d3d12/BufferD3D12.h @@ -62,7 +62,7 @@ namespace dawn::native::d3d12 { void UnmapImpl() override; void DestroyImpl() override; bool IsCPUWritableAtCreation() const override; - virtual MaybeError MapAtCreationImpl() override; + MaybeError MapAtCreationImpl() override; void* GetMappedPointerImpl() override; MaybeError MapInternal(bool isWrite, size_t start, size_t end, const char* contextInfo);