From 09a98b64bec2d67aaa685a666870a04a4c77a66c Mon Sep 17 00:00:00 2001
From: Alexis Hetu <sugoi@google.com>
Date: Thu, 7 Jul 2022 09:38:31 +0000
Subject: [PATCH] Remove Dawn Depth16Unorm test suppressions for SwiftShader
 Vulkan
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Depth16Unorm specific issue should now be fixed:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/66888
so the test suppressions can be removed.

Bug: b/204919030
Change-Id: Ib221d2e11712995237da506ecc6de1f292bfa0bb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95700
Auto-Submit: Alexis Hétu <sugoi@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
---
 .../tests/end2end/DepthStencilLoadOpTests.cpp     | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/src/dawn/tests/end2end/DepthStencilLoadOpTests.cpp b/src/dawn/tests/end2end/DepthStencilLoadOpTests.cpp
index 2e8af0353b..d0de8f2738 100644
--- a/src/dawn/tests/end2end/DepthStencilLoadOpTests.cpp
+++ b/src/dawn/tests/end2end/DepthStencilLoadOpTests.cpp
@@ -178,11 +178,6 @@ class DepthStencilLoadOpTests : public DawnTestWithParams<DepthStencilLoadOpTest
 
 // Check that clearing a mip level works at all.
 TEST_P(DepthStencilLoadOpTests, ClearMip0) {
-    // TODO(https://issuetracker.google.com/issues/204919030): SwiftShader does not clear
-    // Depth16Unorm correctly with some values.
-    DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsSwiftshader() &&
-                          GetParam().mFormat == wgpu::TextureFormat::Depth16Unorm);
-
     wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
     encoder.BeginRenderPass(&renderPassDescriptors[0]).End();
     wgpu::CommandBuffer commandBuffer = encoder.Finish();
@@ -214,11 +209,6 @@ TEST_P(DepthStencilLoadOpTests, ClearBothMip0Then1) {
     // TODO(crbug.com/dawn/838): Sampling from the non-zero mip does not work.
     DAWN_SUPPRESS_TEST_IF(IsMetal() && IsIntel() && GetParam().mCheck == Check::SampleDepth);
 
-    // TODO(https://issuetracker.google.com/issues/204919030): SwiftShader does not clear
-    // Depth16Unorm correctly with some values.
-    DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsSwiftshader() &&
-                          GetParam().mFormat == wgpu::TextureFormat::Depth16Unorm);
-
     wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
     encoder.BeginRenderPass(&renderPassDescriptors[0]).End();
     encoder.BeginRenderPass(&renderPassDescriptors[1]).End();
@@ -234,11 +224,6 @@ TEST_P(DepthStencilLoadOpTests, ClearBothMip1Then0) {
     // TODO(crbug.com/dawn/838): Sampling from the non-zero mip does not work.
     DAWN_SUPPRESS_TEST_IF(IsMetal() && IsIntel() && GetParam().mCheck == Check::SampleDepth);
 
-    // TODO(https://issuetracker.google.com/issues/204919030): SwiftShader does not clear
-    // Depth16Unorm correctly with some values.
-    DAWN_SUPPRESS_TEST_IF(IsVulkan() && IsSwiftshader() &&
-                          GetParam().mFormat == wgpu::TextureFormat::Depth16Unorm);
-
     wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
     encoder.BeginRenderPass(&renderPassDescriptors[1]).End();
     encoder.BeginRenderPass(&renderPassDescriptors[0]).End();