From 0f8b5078880e56553d05543e4fb6d5803b046908 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Mon, 3 Dec 2018 12:22:06 +0000 Subject: [PATCH] Suppress tests failing on GPU FYI Mac Pro (AMD) TBR=kainino@chromium.org BUG=dawn:58 Change-Id: Ibd71a4a7cbc559b868ea8fd801d51ad4b3d7f6fd Reviewed-on: https://dawn-review.googlesource.com/c/2803 Reviewed-by: Corentin Wallez Commit-Queue: Corentin Wallez --- src/tests/end2end/TextureViewTests.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/tests/end2end/TextureViewTests.cpp b/src/tests/end2end/TextureViewTests.cpp index acccc23982..9a334706e9 100644 --- a/src/tests/end2end/TextureViewTests.cpp +++ b/src/tests/end2end/TextureViewTests.cpp @@ -411,11 +411,19 @@ TEST_P(TextureViewTest, TextureCubeMapArrayOnWholeTexture) { // Test sampling from a cube map texture array view that covers a sub part of a 2D array texture. TEST_P(TextureViewTest, TextureCubeMapArrayViewOnPartOfTexture) { + // Test failing on the GPU FYI Mac Pro (AMD), see + // https://bugs.chromium.org/p/dawn/issues/detail?id=58 + DAWN_SKIP_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); + TextureCubeMapTest(20, 3, 12, true); } // Test sampling from a cube map texture array view that covers the last layer of a 2D array texture. TEST_P(TextureViewTest, TextureCubeMapArrayViewCoveringLastLayer) { + // Test failing on the GPU FYI Mac Pro (AMD), see + // https://bugs.chromium.org/p/dawn/issues/detail?id=58 + DAWN_SKIP_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); + constexpr uint32_t kTotalLayers = 20; constexpr uint32_t kBaseLayer = 8; TextureCubeMapTest(kTotalLayers, kBaseLayer, kTotalLayers - kBaseLayer, true); @@ -423,6 +431,10 @@ TEST_P(TextureViewTest, TextureCubeMapArrayViewCoveringLastLayer) { // Test sampling from a cube map array texture view that only has a single cube map. TEST_P(TextureViewTest, TextureCubeMapArrayViewSingleCubeMap) { + // Test failing on the GPU FYI Mac Pro (AMD), see + // https://bugs.chromium.org/p/dawn/issues/detail?id=58 + DAWN_SKIP_TEST_IF(IsMacOS() && IsMetal() && IsAMD()); + TextureCubeMapTest(20, 7, 6, true); }