From 14487c34f7d9627711cbcab63af9ce853718762e Mon Sep 17 00:00:00 2001 From: Jiawei Shao Date: Mon, 1 Apr 2019 07:47:47 +0000 Subject: [PATCH] Skip RenderPassLoadOpTests.ColorClearThenLoadAndDraw on Linux Intel OpenGL RenderPassLoadOpTests.ColorClearThenLoadAndDraw is flaky on Linux Intel drivers, so we have to skip it temporarily. As currently we cannot collect PCI IDs on OpenGL drivers, we have to skip this test on all OpenGL backends. BUG=dawn:126, chromium:947246 Change-Id: Ic1b75ee70d72b8e96ac87018cfc886661e4ae3de Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6260 Commit-Queue: Corentin Wallez Reviewed-by: Corentin Wallez --- src/tests/end2end/RenderPassLoadOpTests.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/tests/end2end/RenderPassLoadOpTests.cpp b/src/tests/end2end/RenderPassLoadOpTests.cpp index e8cc3aa6b5..f3810d663c 100644 --- a/src/tests/end2end/RenderPassLoadOpTests.cpp +++ b/src/tests/end2end/RenderPassLoadOpTests.cpp @@ -112,6 +112,12 @@ class RenderPassLoadOpTests : public DawnTest { // Tests clearing, loading, and drawing into color attachments TEST_P(RenderPassLoadOpTests, ColorClearThenLoadAndDraw) { + // TODO(jiawei.shao@intel.com): investigate why the test is flaky on Linux Intel OpenGL drivers. + // Currently we cannot collect PCI IDs from OpenGL drivers, we have to skip it on all OpenGL + // backends. + // Tracking bug: https://bugs.chromium.org/p/dawn/issues/detail?id=126 + DAWN_SKIP_TEST_IF(IsOpenGL() && IsLinux()); + // Part 1: clear once, check to make sure it's cleared utils::ComboRenderPassDescriptor renderPassClearZero({renderTargetView}); auto commandsClearZeroEncoder = device.CreateCommandEncoder();