From 1966ea9727de342342bea9a60667d6467f8f8b74 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Wed, 4 Jan 2023 16:58:20 +0000 Subject: [PATCH] DISABLE WireBufferMappingReadTests.DestroyInsideMapReadCallback It is failing under ASAN but should be fixed after at the same time as issue dawn:1619 that makes mapping callbacks called only at the end of the BufferBase method. Bug: dawn:1619, dawn:1621 Change-Id: Idfdb6e36432a47eaef63b46e041f1404a2562f40 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116284 Auto-Submit: Corentin Wallez Reviewed-by: Austin Eng Kokoro: Kokoro Commit-Queue: Austin Eng --- src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp b/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp index 7ae8d130cd..d1d1cc8a76 100644 --- a/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp +++ b/src/dawn/tests/unittests/wire/WireBufferMappingTests.cpp @@ -335,7 +335,9 @@ TEST_F(WireBufferMappingReadTests, UnmapInsideMapReadCallback) { // Test that the MapReadCallback isn't fired twice the buffer external refcount reaches 0 in the // callback -TEST_F(WireBufferMappingReadTests, DestroyInsideMapReadCallback) { +// TODO(dawn:1621): Suppressed because the mapping handling still touches the buffer after it is +// destroyed triggering an ASAN error. +TEST_F(WireBufferMappingReadTests, DISABLED_DestroyInsideMapReadCallback) { wgpuBufferMapAsync(buffer, WGPUMapMode_Read, 0, kBufferSize, ToMockBufferMapCallback, nullptr); uint32_t bufferContent = 31337;