From 261643bb9f2519a6eda3d50b88636c9da064d564 Mon Sep 17 00:00:00 2001 From: Antonio Maiorano Date: Thu, 24 Jun 2021 09:15:06 +0000 Subject: [PATCH] Fix doxygen warnings Change-Id: I5b3765ca0362e517990334d47f9defa673732a04 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/55800 Kokoro: Kokoro Reviewed-by: Ben Clayton Commit-Queue: Ben Clayton --- src/reader/spirv/entry_point_info.h | 3 +++ src/reader/spirv/parser_impl.h | 13 +++++++------ src/transform/zero_init_workgroup_memory.cc | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/reader/spirv/entry_point_info.h b/src/reader/spirv/entry_point_info.h index 946d62f757..09a4e41272 100644 --- a/src/reader/spirv/entry_point_info.h +++ b/src/reader/spirv/entry_point_info.h @@ -26,8 +26,11 @@ namespace spirv { /// The size of an integer-coordinate grid, in the x, y, and z dimensions. struct GridSize { + /// x value uint32_t x = 0; + /// y value uint32_t y = 0; + /// z value uint32_t z = 0; }; diff --git a/src/reader/spirv/parser_impl.h b/src/reader/spirv/parser_impl.h index 525f737888..2b818dd30e 100644 --- a/src/reader/spirv/parser_impl.h +++ b/src/reader/spirv/parser_impl.h @@ -99,13 +99,13 @@ struct WorkgroupSizeInfo { uint32_t component_type_id = 0u; /// The SPIR-V IDs of the X, Y, and Z components of the workgroup size /// builtin. - uint32_t x_id = 0u; - uint32_t y_id = 0u; - uint32_t z_id = 0u; + uint32_t x_id = 0u; /// X component ID + uint32_t y_id = 0u; /// Y component ID + uint32_t z_id = 0u; /// Z component ID /// The effective workgroup size, if this is a compute shader. - uint32_t x_value = 0u; - uint32_t y_value = 0u; - uint32_t z_value = 0u; + uint32_t x_value = 0u; /// X workgroup size + uint32_t y_value = 0u; /// Y workgroup size + uint32_t z_value = 0u; /// Z workgroup size }; /// Parser implementation for SPIR-V. @@ -325,6 +325,7 @@ class ParserImpl : Reader { /// @returns true if parser is still successful. bool RegisterWorkgroupSizeBuiltin(); + /// @returns the workgroup size builtin const WorkgroupSizeInfo& workgroup_size_builtin() { return workgroup_size_builtin_; } diff --git a/src/transform/zero_init_workgroup_memory.cc b/src/transform/zero_init_workgroup_memory.cc index 53f96182af..100a379eb8 100644 --- a/src/transform/zero_init_workgroup_memory.cc +++ b/src/transform/zero_init_workgroup_memory.cc @@ -26,7 +26,7 @@ namespace tint { namespace transform { -// PIMPL state for the ZeroInitWorkgroupMemory transform +/// PIMPL state for the ZeroInitWorkgroupMemory transform struct ZeroInitWorkgroupMemory::State { /// The clone context CloneContext& ctx;