From 266a32954e2a839118c2ddc06576d3033280652d Mon Sep 17 00:00:00 2001
From: dan sinclair <dsinclair@google.com>
Date: Tue, 14 Apr 2020 18:16:08 +0000
Subject: [PATCH] Cleanup lint errors.

This CL cleans up some lint errors.

Change-Id: Ibfe9768cc4272d015a35a8d7edde0390b8fc66a5
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/19504
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
---
 src/ast/if_statement.h       |  2 +-
 src/ast/variable.h           |  4 ++--
 src/reader/spirv/function.cc | 34 +++++++++++++++++-----------------
 src/reader/spirv/function.h  |  2 ++
 4 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/src/ast/if_statement.h b/src/ast/if_statement.h
index f173de4b1d..3ee40f85e1 100644
--- a/src/ast/if_statement.h
+++ b/src/ast/if_statement.h
@@ -1,4 +1,4 @@
-// Copyright 2020 The Tint Authors.
+// Copyright 2020 The Tint Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
diff --git a/src/ast/variable.h b/src/ast/variable.h
index 6db32e4fde..b84ef82080 100644
--- a/src/ast/variable.h
+++ b/src/ast/variable.h
@@ -1,4 +1,4 @@
-// Copyright 2020 The Tint Authors.
+// Copyright 2020 The Tint Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -55,7 +55,7 @@ class DecoratedVariable;
 /// 3. A formal parameter to a function is a name for a typed value to
 ///    be passed into a function.  Example:
 ///
-///       fn twice(a: i32) -> i32 { // "a:i32" is the formal parameter
+///       fn twice(a: i32) -> i32 {  // "a:i32" is the formal parameter
 ///         return a + a;
 ///       }
 ///
diff --git a/src/reader/spirv/function.cc b/src/reader/spirv/function.cc
index 0f24f1280f..e6eb339fe4 100644
--- a/src/reader/spirv/function.cc
+++ b/src/reader/spirv/function.cc
@@ -337,23 +337,23 @@ std::unique_ptr<ast::Expression> FunctionEmitter::MaybeEmitCombinatorialValue(
   // glsl.std.450 readonly function
 
   // Instructions:
-  // 	OpCopyObject
-  // 	OpUndef
-  // 	OpBitcast
-  // 	OpSatConvertSToU
-  // 	OpSatConvertUToS
-  // 	OpSatConvertFToS
-  // 	OpSatConvertFToU
-  // 	OpSatConvertSToF
-  // 	OpSatConvertUToF
-  // 	OpUConvert
-  // 	OpSConvert
-  // 	OpFConvert
-  // 	OpConvertPtrToU // Not in WebGPU
-  // 	OpConvertUToPtr // Not in WebGPU
-  // 	OpPtrCastToGeneric // Not in Vulkan
-  // 	OpGenericCastToPtr // Not in Vulkan
-  // 	OpGenericCastToPtrExplicit // Not in Vulkan
+  //    OpCopyObject
+  //    OpUndef
+  //    OpBitcast
+  //    OpSatConvertSToU
+  //    OpSatConvertUToS
+  //    OpSatConvertFToS
+  //    OpSatConvertFToU
+  //    OpSatConvertSToF
+  //    OpSatConvertUToF
+  //    OpUConvert
+  //    OpSConvert
+  //    OpFConvert
+  //    OpConvertPtrToU // Not in WebGPU
+  //    OpConvertUToPtr // Not in WebGPU
+  //    OpPtrCastToGeneric // Not in Vulkan
+  //    OpGenericCastToPtr // Not in Vulkan
+  //    OpGenericCastToPtrExplicit // Not in Vulkan
   //
   //    OpAccessChain
   //    OpInBoundsAccessChain
diff --git a/src/reader/spirv/function.h b/src/reader/spirv/function.h
index b5d588652e..a22140cd46 100644
--- a/src/reader/spirv/function.h
+++ b/src/reader/spirv/function.h
@@ -16,6 +16,8 @@
 #define SRC_READER_SPIRV_FUNCTION_H_
 
 #include <memory>
+#include <unordered_map>
+#include <unordered_set>
 #include <vector>
 
 #include "source/opt/basic_block.h"