From 2f321dd4abb0f6a63be482215aef3ce26a353b38 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Mon, 18 Feb 2019 09:37:53 +0000 Subject: [PATCH] Suppress BufferSetSubDataTests.ManySetSubData on Mac Intel This test started failing on the macOS 10.14 builders as soon as it was re-enabled. Suppress them while we investigate. TBR=kainino@chromium.org BUG=dawn:108 Change-Id: I7470a751d74c97558128cbbc90574b3d05629a3e Reviewed-on: https://dawn-review.googlesource.com/c/4821 Reviewed-by: Corentin Wallez Commit-Queue: Corentin Wallez --- src/tests/end2end/BufferTests.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/tests/end2end/BufferTests.cpp b/src/tests/end2end/BufferTests.cpp index e677ebc83e..91e104ad08 100644 --- a/src/tests/end2end/BufferTests.cpp +++ b/src/tests/end2end/BufferTests.cpp @@ -180,6 +180,10 @@ TEST_P(BufferSetSubDataTests, SmallDataAtOffset) { // Stress test for many calls to SetSubData TEST_P(BufferSetSubDataTests, ManySetSubData) { + // Test failing on Mac Metal Intel, maybe because Metal runs out of space to encode commands. + // See https://bugs.chromium.org/p/dawn/issues/detail?id=108 + DAWN_SKIP_TEST_IF(IsMacOS() && IsMetal() && IsIntel()); + // Note: Increasing the size of the buffer will likely cause timeout issues. // In D3D12, timeout detection occurs when the GPU scheduler tries but cannot preempt the task // executing these commands in-flight. If this takes longer than ~2s, a device reset occurs and