From 320c6c87b2ed980d4c7622230976d40ad0fc54a1 Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Wed, 26 Aug 2020 15:26:32 +0000 Subject: [PATCH] Revert "Skip TextureSubresourceTest.MipmapLevelsTest on Vulkan w/ validation" This reverts commit e8dc820fbc1e28eba80b8e8c49bb3e566874f4e7. Reason for revert: The Vulkan validation layers bug has been fixed Original change's description: > Skip TextureSubresourceTest.MipmapLevelsTest on Vulkan w/ validation > > This test is broken after a validation layers update. > > Tbr=cwallez@chromium.org > Bug: dawn:517 > Change-Id: Ia685ba7bd17d8cdb49477997aaee4e5a9f00f9c7 > > Change-Id: I6f05516f00c8d05b96c8af578e09df9dc416385b > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/27123 > Reviewed-by: Austin Eng > Commit-Queue: Austin Eng TBR=cwallez@chromium.org,enga@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: dawn:517 Change-Id: I844960bfda35be59659ee88ff8b5028fbd0ca612 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/27400 Reviewed-by: Austin Eng Reviewed-by: Corentin Wallez Commit-Queue: Austin Eng --- src/tests/end2end/TextureSubresourceTests.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/tests/end2end/TextureSubresourceTests.cpp b/src/tests/end2end/TextureSubresourceTests.cpp index 801f61ce80..e9276b25c5 100644 --- a/src/tests/end2end/TextureSubresourceTests.cpp +++ b/src/tests/end2end/TextureSubresourceTests.cpp @@ -137,10 +137,6 @@ class TextureSubresourceTest : public DawnTest { // Test different mipmap levels TEST_P(TextureSubresourceTest, MipmapLevelsTest) { - // TODO(crbug.com/dawn/517): The Vulkan backend hits this validation rule. - // https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-vkCmdDraw-None-02687 - DAWN_SKIP_TEST_IF(IsBackendValidationEnabled() && IsVulkan()); - // Create a texture with 2 mipmap levels and 1 layer wgpu::Texture texture = CreateTexture(2, 1,