From 37200bd0be6a3188f6815b4015e857a6c4f947fe Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Tue, 19 Apr 2022 17:06:54 +0000 Subject: [PATCH] Revert "Speculatively suppress RequiredBufferSizeInCopyTests on Win Intel x86" This reverts commit 3199179167cc4e8ce86cd258e80d8343a7932ee8. Reason for revert: Suppressing these tests didn't help flakes at all. Original change's description: > Speculatively suppress RequiredBufferSizeInCopyTests on Win Intel x86 > > Bug: dawn:1375 > Change-Id: Ieb218fc90e93734f2ccaacaf9a0dd22c57d93163 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86866 > Reviewed-by: Loko Kung > Commit-Queue: Austin Eng > Kokoro: Kokoro # Not skipping CQ checks because original CL landed > 1 day ago. Bug: dawn:1375 Change-Id: I3b725340516e25b0c8bffb8b817c86278645aba8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87320 Commit-Queue: Austin Eng Auto-Submit: Austin Eng Reviewed-by: Loko Kung Commit-Queue: Loko Kung Kokoro: Kokoro --- src/dawn/tests/end2end/RequiredBufferSizeInCopyTests.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/dawn/tests/end2end/RequiredBufferSizeInCopyTests.cpp b/src/dawn/tests/end2end/RequiredBufferSizeInCopyTests.cpp index 51d37e967f..9b1f0ff94d 100644 --- a/src/dawn/tests/end2end/RequiredBufferSizeInCopyTests.cpp +++ b/src/dawn/tests/end2end/RequiredBufferSizeInCopyTests.cpp @@ -14,7 +14,6 @@ #include "dawn/tests/DawnTest.h" -#include "dawn/common/Platform.h" #include "dawn/utils/TestUtils.h" #include "dawn/utils/WGPUHelpers.h" @@ -72,14 +71,6 @@ namespace { class RequiredBufferSizeInCopyTests : public DawnTestWithParams { protected: - void SetUp() override { - DawnTestWithParams::SetUp(); -#ifdef DAWN_PLATFORM_32_BIT - // Suspect causing flaky hangs or crashes. crbug.com/dawn/1375. - DAWN_SUPPRESS_TEST_IF(IsWindows() && IsIntel()); -#endif - } - void DoTest(const uint64_t bufferSize) { wgpu::BufferDescriptor descriptor; descriptor.size = bufferSize;