From 399b88845cce35381afe4b5fd9c0c2174df297ec Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Thu, 18 Mar 2021 12:27:24 +0000 Subject: [PATCH] Quickfix for unknown warning in Chromium Chromium uses clang 13.0 that likely removes the warning while Skia uses clang 12.0 that still has the warning. Temporarily skip the -Wno-return-std-move-in-c++11 in Chromium only while Skia changes to not add warnings to it's third_party dependencies. Bug: dawn:706 Change-Id: I625f0046204328dcf2cfb1eb9824f8a4a928b8ff Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45240 Commit-Queue: Corentin Wallez Commit-Queue: Ben Clayton Auto-Submit: Corentin Wallez Reviewed-by: Ben Clayton --- src/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BUILD.gn b/src/BUILD.gn index 49d04cd902..787afe2c87 100644 --- a/src/BUILD.gn +++ b/src/BUILD.gn @@ -28,7 +28,7 @@ config("tint_common_config") { "${tint_spirv_tools_dir}/include", ] - if (is_clang) { + if (is_clang && !build_with_chromium) { # Suppress a warning enabled by Skia: Tint is C++14 so the C++11 defect # detected by this warning has been fixed. cflags = [ "-Wno-return-std-move-in-c++11" ]