From 3cc58af801922841dc09219cfa7d66a49f9a35db Mon Sep 17 00:00:00 2001 From: Li Hao Date: Mon, 3 Sep 2018 17:13:33 +0800 Subject: [PATCH] Update reason for hiding vktrace layer --- src/dawn_native/vulkan/DeviceVk.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/dawn_native/vulkan/DeviceVk.cpp b/src/dawn_native/vulkan/DeviceVk.cpp index 7245ec8411..e9a9183ff1 100644 --- a/src/dawn_native/vulkan/DeviceVk.cpp +++ b/src/dawn_native/vulkan/DeviceVk.cpp @@ -421,8 +421,9 @@ namespace dawn_native { namespace vulkan { extensions->push_back(extension); }; - // vktrace works by instering a layer, but we hide it behind a macro unless we are - // debugging in vktrace. + // vktrace works by instering a layer, but we hide it behind a macro due to the vktrace + // layer crashes when used without vktrace server started, see this vktrace issue: + // https://github.com/LunarG/VulkanTools/issues/254 // Also it is good to put it in first position so that it doesn't see Vulkan calls inserted // by other layers. #if defined(DAWN_USE_VKTRACE)