From 3f5c01ae9248c02df90f1e470cc8fe3e019a6a01 Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Thu, 7 Jan 2021 16:04:24 +0000 Subject: [PATCH] Reland "Update PrimitiveTopologyTests to use WGSL" This reverts commit ad0bec6c96965e82a8f0b967ce7a97d658c1d62a. Reason for revert: The change was incorrectly blamed for a autoroll failure and reverted unnecessarily. Original change's description: > Revert "Update PrimitiveTopologyTests to use WGSL" > > This reverts commit b9641b8225b82cfda56c3e0544cea041172deef7. > > Reason for revert: Suspect causing Dawn roll to fail > > Original change's description: > > Update PrimitiveTopologyTests to use WGSL > > > > A rebased fork of https://dawn-review.googlesource.com/c/dawn/+/33774 > > > > Bug: dawn:572 > > Change-Id: Icb24ac5b62984e9b093e61077155b9a1eafb344b > > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35801 > > Commit-Queue: Ben Clayton > > Auto-Submit: Ben Clayton > > Reviewed-by: Austin Eng > > Reviewed-by: Corentin Wallez > > TBR=cwallez@chromium.org,enga@chromium.org,bclayton@google.com > > Change-Id: Ib6fe527f28cf17f8f8e817c59121e357b9b65cd1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: dawn:572 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36520 > Reviewed-by: Austin Eng > Commit-Queue: Austin Eng TBR=cwallez@chromium.org,enga@chromium.org,bclayton@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: dawn:572 Change-Id: I2e8859c9b9f12c005bef1309c7bad98f61af2ac7 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36842 Reviewed-by: Corentin Wallez Commit-Queue: Ben Clayton --- src/tests/end2end/PrimitiveTopologyTests.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tests/end2end/PrimitiveTopologyTests.cpp b/src/tests/end2end/PrimitiveTopologyTests.cpp index be3e9e90ad..b103aab599 100644 --- a/src/tests/end2end/PrimitiveTopologyTests.cpp +++ b/src/tests/end2end/PrimitiveTopologyTests.cpp @@ -151,9 +151,6 @@ class PrimitiveTopologyTest : public DawnTest { void SetUp() override { DawnTest::SetUp(); - // TODO(crbug.com/tint/398): GLSL builtins don't work with SPIR-V reader. - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_generator")); - renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize); vsModule = utils::CreateShaderModuleFromWGSL(device, R"(