diff --git a/src/dawn/native/RenderEncoderBase.cpp b/src/dawn/native/RenderEncoderBase.cpp index e6fd1a9d0c..f186c162dc 100644 --- a/src/dawn/native/RenderEncoderBase.cpp +++ b/src/dawn/native/RenderEncoderBase.cpp @@ -237,8 +237,6 @@ namespace dawn::native { if (IsValidationEnabled()) { DAWN_TRY(GetDevice()->ValidateObject(pipeline)); - // TODO(dawn:563): More detail about why the states are incompatible would be - // nice. DAWN_INVALID_IF(pipeline->GetAttachmentState() != mAttachmentState.Get(), "Attachment state of %s is not compatible with %s.\n" "%s expects an attachment state of %s.\n" diff --git a/src/dawn/native/RenderPassEncoder.cpp b/src/dawn/native/RenderPassEncoder.cpp index aac0ca7bd6..b7f756338d 100644 --- a/src/dawn/native/RenderPassEncoder.cpp +++ b/src/dawn/native/RenderPassEncoder.cpp @@ -281,12 +281,13 @@ namespace dawn::native { for (uint32_t i = 0; i < count; ++i) { DAWN_TRY(GetDevice()->ValidateObject(renderBundles[i])); - // TODO(dawn:563): Give more detail about why the states are incompatible. - DAWN_INVALID_IF( - attachmentState != renderBundles[i]->GetAttachmentState(), - "Attachment state of renderBundles[%i] (%s) is not compatible with " - "attachment state of %s.", - i, renderBundles[i], this); + DAWN_INVALID_IF(attachmentState != renderBundles[i]->GetAttachmentState(), + "Attachment state of renderBundles[%i] (%s) is not " + "compatible with %s.\n" + "%s expects an attachment state of %s.\n" + "renderBundles[%i] (%s) has an attachment state of %s.", + i, renderBundles[i], this, this, attachmentState, i, + renderBundles[i], renderBundles[i]->GetAttachmentState()); bool depthReadOnlyInBundle = renderBundles[i]->IsDepthReadOnly(); DAWN_INVALID_IF(