From 43c39a1ba42a1b1bc94337b11fe744fc36663693 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Mon, 14 Dec 2020 20:45:08 +0000 Subject: [PATCH] Re-enable disabled unit tests The issues causing these tests to fail with the Inspector enabled have been resolved. BUG=dawn:578 Change-Id: Ie0b7b4d6b2d1a3b432f4eed7542c64e31bf44fdb Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35680 Commit-Queue: Ryan Harrison Commit-Queue: Corentin Wallez Auto-Submit: Ryan Harrison Reviewed-by: Corentin Wallez Reviewed-by: Austin Eng --- .../unittests/validation/RenderPipelineValidationTests.cpp | 3 --- .../unittests/validation/StorageTextureValidationTests.cpp | 6 ------ 2 files changed, 9 deletions(-) diff --git a/src/tests/unittests/validation/RenderPipelineValidationTests.cpp b/src/tests/unittests/validation/RenderPipelineValidationTests.cpp index 24c3f30299..7aee3c34dd 100644 --- a/src/tests/unittests/validation/RenderPipelineValidationTests.cpp +++ b/src/tests/unittests/validation/RenderPipelineValidationTests.cpp @@ -480,9 +480,6 @@ TEST_F(RenderPipelineValidationTest, TextureViewDimensionCompatibility) { // Test that declaring a storage buffer in the vertex shader without setting pipeline layout won't // cause crash. TEST_F(RenderPipelineValidationTest, StorageBufferInVertexShaderNoLayout) { - // TODO(rharrison): Re-enable once tint:383 is resolved. - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_inspector")); - wgpu::ShaderModule vsModuleWithStorageBuffer = utils::CreateShaderModuleFromWGSL(device, R"( [[block]] struct Dst { [[offset(0)]] data : [[stride(4)]] array; diff --git a/src/tests/unittests/validation/StorageTextureValidationTests.cpp b/src/tests/unittests/validation/StorageTextureValidationTests.cpp index f5bd623888..12a3f81668 100644 --- a/src/tests/unittests/validation/StorageTextureValidationTests.cpp +++ b/src/tests/unittests/validation/StorageTextureValidationTests.cpp @@ -122,9 +122,6 @@ class StorageTextureValidationTests : public ValidationTest { // Validate read-only storage textures can be declared in vertex and fragment shaders, while // writeonly storage textures cannot be used in vertex shaders. TEST_F(StorageTextureValidationTests, RenderPipeline) { - // TODO(rharrison): Re-enable once https://dawn-review.googlesource.com/c/tint/+/34424 lands - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_inspector")); - // Readonly storage texture can be declared in a vertex shader. { wgpu::ShaderModule vsModule = utils::CreateShaderModuleFromWGSL(device, R"( @@ -197,9 +194,6 @@ TEST_F(StorageTextureValidationTests, RenderPipeline) { // Validate both read-only and write-only storage textures can be declared in // compute shaders. TEST_F(StorageTextureValidationTests, ComputePipeline) { - // TODO(rharrison): Re-enable once https://dawn-review.googlesource.com/c/tint/+/34424 lands - DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_inspector")); - // Read-only storage textures can be declared in a compute shader. { wgpu::ShaderModule csModule = utils::CreateShaderModuleFromWGSL(device, R"(