From 45b18ce064a065c83f814331bec2084b64e5d4ba Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Tue, 16 Feb 2021 20:56:21 +0000 Subject: [PATCH] Fix CMake build, fix doxygen warning inspector_test.cc: Remove unused method test_helper.h: Fix comment type on member Change-Id: I53b1392fa1fa8154efdcd471d1df1bbf27e04dc9 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41728 Commit-Queue: Ben Clayton Commit-Queue: Ryan Harrison Commit-Queue: dan sinclair Auto-Submit: Ben Clayton Reviewed-by: Ryan Harrison Reviewed-by: dan sinclair --- src/inspector/inspector_test.cc | 15 --------------- src/writer/wgsl/test_helper.h | 2 +- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/src/inspector/inspector_test.cc b/src/inspector/inspector_test.cc index f52e688eaf..6472ebd13b 100644 --- a/src/inspector/inspector_test.cc +++ b/src/inspector/inspector_test.cc @@ -631,21 +631,6 @@ class InspectorHelper : public ProgramBuilder { return {texture_type, subtype, access_control}; } - /// Generates appropriate types for a Write-Only StorageTexture - /// @param dim the texture dimension of the storage texture - /// @param format the image format of the storage texture - /// @returns the storage texture type, subtype & access control type - std::tuple - MakeWriteOnlyStorageTextureTypes(type::TextureDimension dim, - type::ImageFormat format) { - type::StorageTexture* texture_type; - type::Type* subtype; - std::tie(texture_type, subtype) = MakeStorageTextureTypes(dim, format); - auto* access_control = create( - ast::AccessControl::kWriteOnly, texture_type); - return {texture_type, subtype, access_control}; - } - /// Adds a storage texture variable to the program /// @param name the name of the variable /// @param type the type to use diff --git a/src/writer/wgsl/test_helper.h b/src/writer/wgsl/test_helper.h index 14a69a2a84..5039ebea1b 100644 --- a/src/writer/wgsl/test_helper.h +++ b/src/writer/wgsl/test_helper.h @@ -50,7 +50,7 @@ class TestHelperBase : public BASE, public ProgramBuilder { /// The type determiner TypeDeterminer td; - // The program built with a call to Build() + /// The program built with a call to Build() std::unique_ptr program; private: