diff --git a/src/dawn/native/d3d12/BindGroupLayoutD3D12.cpp b/src/dawn/native/d3d12/BindGroupLayoutD3D12.cpp index 80d4ea4e71..4e586a0947 100644 --- a/src/dawn/native/d3d12/BindGroupLayoutD3D12.cpp +++ b/src/dawn/native/d3d12/BindGroupLayoutD3D12.cpp @@ -78,21 +78,15 @@ namespace dawn::native::d3d12 { D3D12_DESCRIPTOR_RANGE_TYPE descriptorRangeType = WGPUBindingInfoToDescriptorRangeType(bindingInfo); - - // TODO(dawn:728) In the future, special handling will be needed for external textures - // here because they encompass multiple views. mShaderRegisters[bindingIndex] = uint32_t(bindingInfo.binding); - if (bindingIndex < GetDynamicBufferCount()) { - continue; - } - // For dynamic resources, Dawn uses root descriptor in D3D12 backend. So there is no // need to allocate the descriptor from descriptor heap or create descriptor ranges. + if (bindingIndex < GetDynamicBufferCount()) { + continue; + } ASSERT(!bindingInfo.buffer.hasDynamicOffset); - // TODO(dawn:728) In the future, special handling will be needed for external textures - // here because they encompass multiple views. mDescriptorHeapOffsets[bindingIndex] = descriptorRangeType == D3D12_DESCRIPTOR_RANGE_TYPE_SAMPLER ? mSamplerDescriptorCount++ diff --git a/src/dawn/native/vulkan/BindGroupLayoutVk.cpp b/src/dawn/native/vulkan/BindGroupLayoutVk.cpp index 20a8e1bcfd..8ed4340ae9 100644 --- a/src/dawn/native/vulkan/BindGroupLayoutVk.cpp +++ b/src/dawn/native/vulkan/BindGroupLayoutVk.cpp @@ -100,8 +100,6 @@ namespace dawn::native::vulkan { VkDescriptorSetLayoutBinding vkBinding; vkBinding.binding = static_cast(bindingIndex); - // TODO(dawn:728) In the future, special handling will be needed for external textures - // here because they encompass multiple views. vkBinding.descriptorType = VulkanDescriptorType(bindingInfo); vkBinding.descriptorCount = 1; vkBinding.stageFlags = VulkanShaderStageFlags(bindingInfo.visibility); @@ -126,8 +124,6 @@ namespace dawn::native::vulkan { std::map descriptorCountPerType; for (BindingIndex bindingIndex{0}; bindingIndex < GetBindingCount(); ++bindingIndex) { - // TODO(dawn:728) In the future, special handling will be needed for external textures - // here because they encompass multiple views. VkDescriptorType vulkanType = VulkanDescriptorType(GetBindingInfo(bindingIndex)); // map::operator[] will return 0 if the key doesn't exist.