From 4950095ac9c1023ef5101eb1bb7ef8804c29981e Mon Sep 17 00:00:00 2001 From: "Li, Hao" Date: Fri, 10 Jan 2020 14:55:18 +0000 Subject: [PATCH] Remove suppression for BindGroupTests.MultipleBindLayouts on Metal The padded matrix issue in MSL has been fixed in SPIRV-Cross, and it's updated in https://dawn-review.googlesource.com/c/dawn/+/13421, so we can add BindGroupTests.MultipleBindLayouts back. Bug: dawn:33 Change-Id: I8847ab536ebfd779219a1c6d0e1a9a128adf7e85 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13560 Commit-Queue: Hao Li Reviewed-by: Jiawei Shao Reviewed-by: Corentin Wallez --- src/tests/end2end/BindGroupTests.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/tests/end2end/BindGroupTests.cpp b/src/tests/end2end/BindGroupTests.cpp index 54721efbf3..fd3ad56b15 100644 --- a/src/tests/end2end/BindGroupTests.cpp +++ b/src/tests/end2end/BindGroupTests.cpp @@ -332,10 +332,6 @@ TEST_P(BindGroupTests, UBOSamplerAndTexture) { } TEST_P(BindGroupTests, MultipleBindLayouts) { - // Test fails on Metal. - // https://bugs.chromium.org/p/dawn/issues/detail?id=33 - DAWN_SKIP_TEST_IF(IsMetal()); - utils::BasicRenderPass renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize); wgpu::ShaderModule vsModule =