diff --git a/src/backend/common/CommandBuffer.cpp b/src/backend/common/CommandBuffer.cpp index 76fb13ca79..43436739b1 100644 --- a/src/backend/common/CommandBuffer.cpp +++ b/src/backend/common/CommandBuffer.cpp @@ -436,8 +436,7 @@ namespace backend { constexpr ValidationAspects requiredDispatchAspects = 1 << VALIDATION_ASPECT_COMPUTE_PIPELINE | - 1 << VALIDATION_ASPECT_BINDGROUPS | - 1 << VALIDATION_ASPECT_VERTEX_BUFFERS; + 1 << VALIDATION_ASPECT_BINDGROUPS; if ((requiredDispatchAspects & ~aspects).any()) { // Compute the lazily computed aspects @@ -445,11 +444,6 @@ namespace backend { aspects.set(VALIDATION_ASPECT_BINDGROUPS); } - auto requiredInputs = lastPipeline->GetInputState()->GetInputsSetMask(); - if ((inputsSet & ~requiredInputs).none()) { - aspects.set(VALIDATION_ASPECT_VERTEX_BUFFERS); - } - // Check again if anything is missing if ((requiredDispatchAspects & ~aspects).any()) { HandleError("Some dispatch state is missing"); diff --git a/src/tests/CMakeLists.txt b/src/tests/CMakeLists.txt index 0332eb7e29..66f91bfe27 100644 --- a/src/tests/CMakeLists.txt +++ b/src/tests/CMakeLists.txt @@ -26,6 +26,7 @@ add_executable(nxt_unittests ${UNITTESTS_DIR}/ToBackendTests.cpp ${UNITTESTS_DIR}/WireTests.cpp ${VALIDATION_TESTS_DIR}/BufferValidationTests.cpp + ${VALIDATION_TESTS_DIR}/ComputeValidationTests.cpp ${VALIDATION_TESTS_DIR}/DepthStencilStateValidationTests.cpp ${VALIDATION_TESTS_DIR}/ValidationTest.cpp ${VALIDATION_TESTS_DIR}/ValidationTest.h diff --git a/src/tests/unittests/validation/ComputeValidationTests.cpp b/src/tests/unittests/validation/ComputeValidationTests.cpp new file mode 100644 index 0000000000..59a8ccc748 --- /dev/null +++ b/src/tests/unittests/validation/ComputeValidationTests.cpp @@ -0,0 +1,20 @@ +// Copyright 2017 The NXT Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +#include "ValidationTest.h" + +class ComputeValidationTest : public ValidationTest { +}; + +//TODO(cwallez@chromium.org): Add a regression test for Disptach validation trying to acces the input state.