From 51bab8067ab8b97444fa411e02a1952e5eb9686e Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Tue, 12 Apr 2022 17:53:11 +0000 Subject: [PATCH] Remove redundant override in include/dawn. This CL removes two redundant override annotations in the include/dawn folder. The override is redundant due to the final attribute. This fixes readability/inheritance in include/dawn. Bug: dawn:1339 Change-Id: I8d58d099ec36f379b2f0beb55007aafc64dab7c1 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86445 Reviewed-by: Corentin Wallez Commit-Queue: Dan Sinclair Auto-Submit: Dan Sinclair --- include/dawn/CPPLINT.cfg | 1 - include/dawn/wire/WireClient.h | 3 +-- include/dawn/wire/WireServer.h | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/dawn/CPPLINT.cfg b/include/dawn/CPPLINT.cfg index bbf66f3978..f5c9c6dfc4 100644 --- a/include/dawn/CPPLINT.cfg +++ b/include/dawn/CPPLINT.cfg @@ -1,2 +1 @@ -filter=-readability/inheritance filter=-runtime/indentation_namespace diff --git a/include/dawn/wire/WireClient.h b/include/dawn/wire/WireClient.h index a493532ff0..d8b50a33a8 100644 --- a/include/dawn/wire/WireClient.h +++ b/include/dawn/wire/WireClient.h @@ -68,8 +68,7 @@ namespace dawn::wire { explicit WireClient(const WireClientDescriptor& descriptor); ~WireClient() override; - const volatile char* HandleCommands(const volatile char* commands, - size_t size) override final; + const volatile char* HandleCommands(const volatile char* commands, size_t size) final; ReservedTexture ReserveTexture(WGPUDevice device); ReservedSwapChain ReserveSwapChain(WGPUDevice device); diff --git a/include/dawn/wire/WireServer.h b/include/dawn/wire/WireServer.h index 7c8fb56258..1957de0356 100644 --- a/include/dawn/wire/WireServer.h +++ b/include/dawn/wire/WireServer.h @@ -39,8 +39,7 @@ namespace dawn::wire { explicit WireServer(const WireServerDescriptor& descriptor); ~WireServer() override; - const volatile char* HandleCommands(const volatile char* commands, - size_t size) override final; + const volatile char* HandleCommands(const volatile char* commands, size_t size) final; bool InjectTexture(WGPUTexture texture, uint32_t id,