From 552045a559855295db0f54a29f374976403148c8 Mon Sep 17 00:00:00 2001 From: Austin Eng Date: Tue, 10 May 2022 18:17:54 +0000 Subject: [PATCH] Don't use incremental build in webgpu-cts/scripts/list.py The incremental build can become stale for unknown reasons, breaking presubmits. Disable it for now. Bug: dawn:1395 Change-Id: I83a71da0006ee3184b8df2996d8e53b6efbcc20a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89640 Reviewed-by: Corentin Wallez Commit-Queue: Austin Eng Kokoro: Kokoro --- webgpu-cts/scripts/compile_src.py | 4 ++-- webgpu-cts/scripts/list.py | 8 +++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/webgpu-cts/scripts/compile_src.py b/webgpu-cts/scripts/compile_src.py index 9ebcfc429a..83d1de68be 100755 --- a/webgpu-cts/scripts/compile_src.py +++ b/webgpu-cts/scripts/compile_src.py @@ -32,7 +32,7 @@ finally: def compile_src(out_dir): # First, clean the output directory so deleted files are pruned from old builds. - shutil.rmtree(out_dir) + shutil.rmtree(out_dir, ignore_errors=True) run_tsc_ignore_errors([ "--project", @@ -56,7 +56,7 @@ def compile_src_for_node(out_dir, additional_args=None, clean=True): additional_args = additional_args or [] if clean: # First, clean the output directory so deleted files are pruned from old builds. - shutil.rmtree(out_dir) + shutil.rmtree(out_dir, ignore_errors=True) args = [ "--project", diff --git a/webgpu-cts/scripts/list.py b/webgpu-cts/scripts/list.py index 70d278ac99..fb72d85e3c 100755 --- a/webgpu-cts/scripts/list.py +++ b/webgpu-cts/scripts/list.py @@ -35,11 +35,9 @@ def list_testcases(query, js_out_dir=None): try: logging.info('WebGPU CTS: Transpiling tools...') - compile_src_for_node(js_out_dir, [ - '--incremental', '--tsBuildInfoFile', - os.path.join(js_out_dir, 'build.tsbuildinfo') - ], - clean=False) + # TODO(crbug.com/dawn/1395): Bring back usage of an incremental build to + # speed up this operation. It was disabled due to flakiness. + compile_src_for_node(js_out_dir) old_sys_path = sys.path try: