From 58d1e89426d39169e3d74f85a1939befdbee5d15 Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Wed, 11 Jan 2023 20:05:37 +0000 Subject: [PATCH] dawn/node: Avoid empty vector index If a device lists no features, don't zero-index an empty std::vector. Change-Id: I10d632f0c5d5a162abec180797ad11adee67fc6b Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116863 Reviewed-by: Corentin Wallez Auto-Submit: Ben Clayton Kokoro: Kokoro Commit-Queue: Ben Clayton --- src/dawn/node/binding/GPUDevice.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/dawn/node/binding/GPUDevice.cpp b/src/dawn/node/binding/GPUDevice.cpp index 9e0baa700f..92ec3716ce 100644 --- a/src/dawn/node/binding/GPUDevice.cpp +++ b/src/dawn/node/binding/GPUDevice.cpp @@ -181,7 +181,9 @@ GPUDevice::~GPUDevice() { interop::Interface GPUDevice::getFeatures(Napi::Env env) { size_t count = device_.EnumerateFeatures(nullptr); std::vector features(count); - device_.EnumerateFeatures(&features[0]); + if (count > 0) { + device_.EnumerateFeatures(features.data()); + } return interop::GPUSupportedFeatures::Create(env, env, std::move(features)); }