From 59024a62f6402fe139df3e78beb9b6184d7dfb69 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Wed, 3 Feb 2021 20:26:13 +0000 Subject: [PATCH] Re-enable Mac ShaderTests Issues with log2 on Metal/Intel were actually due to floating point precision not being guaranteed and the tests not accounting to that. This has been corrected. BUG=dawn:663 Change-Id: I401d22898e69ea6b3f96f3d2c57a28b1dc682ed5 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/40243 Commit-Queue: Ryan Harrison Commit-Queue: Austin Eng Auto-Submit: Ryan Harrison Reviewed-by: Austin Eng --- src/tests/end2end/ShaderTests.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tests/end2end/ShaderTests.cpp b/src/tests/end2end/ShaderTests.cpp index 189eebbe2b..4acb52f17a 100644 --- a/src/tests/end2end/ShaderTests.cpp +++ b/src/tests/end2end/ShaderTests.cpp @@ -23,9 +23,6 @@ class ShaderTests : public DawnTest {}; // Test that log2 is being properly calculated, base on crbug.com/1046622 TEST_P(ShaderTests, ComputeLog2) { - // TODO(crbug.com/dawn/663): log2(32) is currently being incorrectly calculated. - DAWN_SKIP_TEST_IF(IsMacOS() && IsIntel()); - uint32_t const kSteps = 19; std::vector data(kSteps, 0); std::vector expected{0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 32};