From 593c87b41429130fb16696d025f9ac4ca0e360cd Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Fri, 7 May 2021 15:48:04 +0000 Subject: [PATCH] Remove fuzzing for transform::EmitVertPointSize BUG=tint:753 Change-Id: Idb1f942defe6233421ea735a56bab8da8add8024 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50360 Commit-Queue: Ryan Harrison Commit-Queue: Ben Clayton Auto-Submit: Ryan Harrison Reviewed-by: Ben Clayton Kokoro: Kokoro --- fuzzers/BUILD.gn | 8 ----- fuzzers/CMakeLists.txt | 1 - fuzzers/tint_all_transforms_fuzzer.cc | 3 -- fuzzers/tint_emit_vertex_point_size_fuzzer.cc | 34 ------------------- fuzzers/tint_vertex_pulling_fuzzer.cc | 3 -- include/tint/tint.h | 2 +- 6 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644 fuzzers/tint_emit_vertex_point_size_fuzzer.cc diff --git a/fuzzers/BUILD.gn b/fuzzers/BUILD.gn index 74943facba..2f6eae58a9 100644 --- a/fuzzers/BUILD.gn +++ b/fuzzers/BUILD.gn @@ -71,12 +71,6 @@ if (build_with_chromium) { deps = [ ":tint_fuzzer_common" ] } - # TODO(tint:753): Remove once transform used by sanitizers - fuzzer_test("tint_emit_vertex_point_size_fuzzer") { - sources = [ "tint_emit_vertex_point_size_fuzzer.cc" ] - deps = [ ":tint_fuzzer_common" ] - } - fuzzer_test("tint_first_index_offset_fuzzer") { sources = [ "tint_first_index_offset_fuzzer.cc" ] deps = [ ":tint_fuzzer_common" ] @@ -194,8 +188,6 @@ if (build_with_chromium) { ":tint_all_transforms_fuzzer", ":tint_binding_remapper_fuzzer", ":tint_bound_array_accessors_fuzzer", - ":tint_emit_vertex_point_size_fuzzer", # TODO(tint:753): Remove once - # transform used by sanitizers ":tint_first_index_offset_fuzzer", ":tint_inspector_fuzzer", ":tint_renamer_fuzzer", diff --git a/fuzzers/CMakeLists.txt b/fuzzers/CMakeLists.txt index b5ef5bf4e7..34e927e2de 100644 --- a/fuzzers/CMakeLists.txt +++ b/fuzzers/CMakeLists.txt @@ -33,7 +33,6 @@ if (${TINT_BUILD_WGSL_READER} AND ${TINT_BUILD_SPV_WRITER}) add_tint_fuzzer(tint_all_transforms_fuzzer) add_tint_fuzzer(tint_binding_remapper_fuzzer) add_tint_fuzzer(tint_bound_array_accessors_fuzzer) - add_tint_fuzzer(tint_emit_vertex_point_size_fuzzer) # TODO(tint:753): Remove once transform used by sanitizers add_tint_fuzzer(tint_first_index_offset_fuzzer) add_tint_fuzzer(tint_inspector_fuzzer) add_tint_fuzzer(tint_renamer_fuzzer) diff --git a/fuzzers/tint_all_transforms_fuzzer.cc b/fuzzers/tint_all_transforms_fuzzer.cc index bb096f4312..9e2dc502e4 100644 --- a/fuzzers/tint_all_transforms_fuzzer.cc +++ b/fuzzers/tint_all_transforms_fuzzer.cc @@ -31,9 +31,6 @@ bool AddPlatformIndependentPasses(Config* config) { ExtractVertexPullingInputs(&config->reader, &config->inputs); config->manager.Add(); - config->manager - .Add(); // TODO(tint:753): Remove once - // transform used by sanitizers config->manager.Add(); config->manager.Add(); config->manager.Add(); diff --git a/fuzzers/tint_emit_vertex_point_size_fuzzer.cc b/fuzzers/tint_emit_vertex_point_size_fuzzer.cc deleted file mode 100644 index d5ab5b4bcc..0000000000 --- a/fuzzers/tint_emit_vertex_point_size_fuzzer.cc +++ /dev/null @@ -1,34 +0,0 @@ -// Copyright 2021 The Tint Authors. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -// TODO(tint:753): Remove this fuzzer once that transform is only -// being used from sanitizers. - -#include "fuzzers/tint_common_fuzzer.h" - -namespace tint { -namespace fuzzers { - -extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) { - tint::transform::Manager transform_manager; - transform_manager.Add(); - - tint::fuzzers::CommonFuzzer fuzzer(InputFormat::kWGSL, OutputFormat::kSpv); - fuzzer.SetTransformManager(&transform_manager, {}); - - return fuzzer.Run(data, size); -} - -} // namespace fuzzers -} // namespace tint diff --git a/fuzzers/tint_vertex_pulling_fuzzer.cc b/fuzzers/tint_vertex_pulling_fuzzer.cc index 62a68abc9b..6e1dc0640b 100644 --- a/fuzzers/tint_vertex_pulling_fuzzer.cc +++ b/fuzzers/tint_vertex_pulling_fuzzer.cc @@ -12,9 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -// TODO(tint:753): Remove this fuzzer once that transform is only -// being used from sanitizers. - #include "fuzzers/tint_common_fuzzer.h" namespace tint { diff --git a/include/tint/tint.h b/include/tint/tint.h index ae0ff17de1..4f61086bcd 100644 --- a/include/tint/tint.h +++ b/include/tint/tint.h @@ -26,7 +26,7 @@ #include "src/sem/type_manager.h" #include "src/transform/binding_remapper.h" #include "src/transform/bound_array_accessors.h" -#include "src/transform/emit_vertex_point_size.h" // TODO(tint:753): Remove once transform used by sanitizers +#include "src/transform/emit_vertex_point_size.h" #include "src/transform/first_index_offset.h" #include "src/transform/manager.h" #include "src/transform/renamer.h"