From 596d6fe00db768f9d723219f98a3f626f333caf8 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Wed, 28 Nov 2018 11:30:43 +0000 Subject: [PATCH] Result: Fix documentation and a typo BUG= Change-Id: I42425a1ee0a4e62a7c1e090878a9d61534eaf784 Reviewed-on: https://dawn-review.googlesource.com/c/2700 Commit-Queue: Corentin Wallez Reviewed-by: Kai Ninomiya --- src/common/Result.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/common/Result.h b/src/common/Result.h index 1aeac54162..326144c374 100644 --- a/src/common/Result.h +++ b/src/common/Result.h @@ -38,11 +38,11 @@ class Result; // The interface of Result shoud look like the following. // public: -// Result(T success); -// Result(E error); +// Result(T&& success); +// Result(E&& error); // // Result(Result&& other); -// Result&& operator=(Result&& other); +// Result& operator=(Result&& other); // // ~Result(); // @@ -113,8 +113,8 @@ class DAWN_NO_DISCARD Result { Empty = 2, }; - // Utility functions to manipulate the tagged pointer some of them don't need to be templated - // but we really want them inlined so we keep them in templates + // Utility functions to manipulate the tagged pointer. Some of them don't need to be templated + // but we really want them inlined so we keep them in the headers static intptr_t MakePayload(void* pointer, PayloadType type); static PayloadType GetPayloadType(intptr_t payload); static T* GetSuccessFromPayload(intptr_t payload);