From 649687497fc9daa8c7e7aaa5e5efe29ad01f1286 Mon Sep 17 00:00:00 2001
From: dan sinclair <dsinclair@chromium.org>
Date: Tue, 19 Apr 2022 23:15:14 +0000
Subject: [PATCH] Convert SerialStorage::Iterator over to being explicit.

This CL adds the attribute and fixes up the call sites to work with the
constructors being explicit.

Bug: dawn:1339
Change-Id: Ic584477c064411e42143dfc6179bbddb0d6a69c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86871
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
---
 src/dawn/common/SerialStorage.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/dawn/common/SerialStorage.h b/src/dawn/common/SerialStorage.h
index 5194a21d35..2eae0adee6 100644
--- a/src/dawn/common/SerialStorage.h
+++ b/src/dawn/common/SerialStorage.h
@@ -35,7 +35,7 @@ class SerialStorage {
   public:
     class Iterator {
       public:
-        Iterator(StorageIterator start);
+        explicit Iterator(StorageIterator start);
         Iterator& operator++();
 
         bool operator==(const Iterator& other) const;
@@ -52,7 +52,7 @@ class SerialStorage {
 
     class ConstIterator {
       public:
-        ConstIterator(ConstStorageIterator start);
+        explicit ConstIterator(ConstStorageIterator start);
         ConstIterator& operator++();
 
         bool operator==(const ConstIterator& other) const;
@@ -198,12 +198,12 @@ SerialStorage<Derived>::BeginEnd::BeginEnd(typename SerialStorage<Derived>::Stor
 
 template <typename Derived>
 typename SerialStorage<Derived>::Iterator SerialStorage<Derived>::BeginEnd::begin() const {
-    return {mStartIt};
+    return SerialStorage::Iterator(mStartIt);
 }
 
 template <typename Derived>
 typename SerialStorage<Derived>::Iterator SerialStorage<Derived>::BeginEnd::end() const {
-    return {mEndIt};
+    return SerialStorage::Iterator(mEndIt);
 }
 
 // SerialStorage::Iterator