From 67a2d57e3ffcc895a0f77181bcd5b6bcb0310bbd Mon Sep 17 00:00:00 2001 From: Brandon Jones Date: Tue, 21 Dec 2021 00:07:01 +0000 Subject: [PATCH] Temporarily avoid error message formatting failure For unknown reasons formatting of a error context message fails in RenderEncoderBase::APISetBindGroup fails if the bind group is printed as a string in the message. This despite the exact same code working as intended in ComputePassEncoder::APISetBindGroup. Replacing it with a static "[BindGroup]" to allow the rest of the message to format correctly until the reason for the failure can be determined. Bug: dawn:1190 Change-Id: I31105acff4d08849a34e406c6b8e85fab28f17b5 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/73280 Auto-Submit: Brandon Jones Reviewed-by: Corentin Wallez Reviewed-by: Kai Ninomiya Commit-Queue: Kai Ninomiya --- src/dawn_native/RenderEncoderBase.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/dawn_native/RenderEncoderBase.cpp b/src/dawn_native/RenderEncoderBase.cpp index b30f5173a7..d4cc5172c4 100644 --- a/src/dawn_native/RenderEncoderBase.cpp +++ b/src/dawn_native/RenderEncoderBase.cpp @@ -403,7 +403,11 @@ namespace dawn_native { return {}; }, - "encoding %s.SetBindGroup(%u, %s, %u, ...).", this, groupIndexIn, group, + // TODO(dawn:1190): For unknown reasons formatting this message fails if `group` is used + // as a string value in the message. This despite the exact same code working as + // intended in ComputePassEncoder::APISetBindGroup. Replacing with a static [BindGroup] + // until the reason for the failure can be determined. + "encoding %s.SetBindGroup(%u, [BindGroup], %u, ...).", this, groupIndexIn, dynamicOffsetCount); }