From 7052cb57ff6b5463531640c386ae0798ed4f225f Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Fri, 24 Feb 2023 17:03:59 +0000 Subject: [PATCH] Revert "Add test setting the locale." This reverts commit 9cdc3343ff2f88e44bbc2f43feb2c0f05b3e03ad. Reason for revert: For some reason, Windows kokoro bots are now taking objection to this test. Original change's description: > Add test setting the locale. > > This CL adds a test which sets the locale to one which uses `1,00` > instead of `1.00`. This ensures the float emission will get the right > format. > > Bug: tint:1686 > Change-Id: Ib87235c7beac351b7dcbf37534df07135da377e5 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/120881 > Reviewed-by: Ben Clayton > Kokoro: Kokoro > Commit-Queue: Dan Sinclair TBR=dsinclair@chromium.org,bclayton@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2ace266871958a2d467855d55079aae467195ce0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: tint:1686 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/121462 Commit-Queue: Ben Clayton Reviewed-by: Antonio Maiorano Reviewed-by: James Price Kokoro: Kokoro --- src/tint/writer/float_to_string_test.cc | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/tint/writer/float_to_string_test.cc b/src/tint/writer/float_to_string_test.cc index 643f070de0..901334e4e7 100644 --- a/src/tint/writer/float_to_string_test.cc +++ b/src/tint/writer/float_to_string_test.cc @@ -17,7 +17,6 @@ #include #include #include -#include #include "gtest/gtest.h" #include "src/tint/utils/bitcast.h" @@ -80,16 +79,6 @@ TEST(FloatToStringTest, Precision) { EXPECT_EQ(FloatToString(1e-20f), "9.99999968e-21"); } -#if !defined(__linux__) -TEST(FloatToStringTest, Locale) { - std::locale::global(std::locale("sv_SE.UTF-8")); - - EXPECT_EQ(FloatToString(1e-9f), "0.000000001"); - - std::locale::global(std::locale::classic()); -} -#endif // !defined(__linux__) - //////////////////////////////////////////////////////////////////////////////// // FloatToBitPreservingString // ////////////////////////////////////////////////////////////////////////////////