From 71512e30caa7139e192a32d702ae8f1556858970 Mon Sep 17 00:00:00 2001 From: Antonio Maiorano Date: Fri, 9 Apr 2021 13:26:38 +0000 Subject: [PATCH] Remove validator.h With this change, the Validator is fully removed from Tint, including from it's public API. Fix: tint:642 Change-Id: Id4867cc3866bb2ea09eff499537d58b938d18f43 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47125 Kokoro: Kokoro Commit-Queue: Antonio Maiorano Reviewed-by: Ben Clayton --- include/tint/tint.h | 1 - src/BUILD.gn | 1 - src/CMakeLists.txt | 1 - src/validator/validator.h | 53 --------------------------------------- 4 files changed, 56 deletions(-) delete mode 100644 src/validator/validator.h diff --git a/include/tint/tint.h b/include/tint/tint.h index 6e72c470e1..7b55fe2ac3 100644 --- a/include/tint/tint.h +++ b/include/tint/tint.h @@ -32,7 +32,6 @@ #include "src/transform/renamer.h" #include "src/transform/vertex_pulling.h" #include "src/type/type_manager.h" -#include "src/validator/validator.h" #include "src/writer/writer.h" #if TINT_BUILD_SPV_READER diff --git a/src/BUILD.gn b/src/BUILD.gn index 8a7dc89a6a..8c197e2113 100644 --- a/src/BUILD.gn +++ b/src/BUILD.gn @@ -465,7 +465,6 @@ source_set("libtint_core_src") { "utils/hash.h", "utils/math.h", "utils/unique_vector.h", - "validator/validator.h", "writer/append_vector.cc", "writer/append_vector.h", "writer/float_to_string.cc", diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index b920e8c56c..91567fc546 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -280,7 +280,6 @@ set(TINT_LIB_SRCS utils/hash.h utils/math.h utils/unique_vector.h - validator/validator.h writer/append_vector.cc writer/append_vector.h writer/float_to_string.cc diff --git a/src/validator/validator.h b/src/validator/validator.h deleted file mode 100644 index bbcaf69057..0000000000 --- a/src/validator/validator.h +++ /dev/null @@ -1,53 +0,0 @@ -// Copyright 2020 The Tint Authors. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -#ifndef SRC_VALIDATOR_VALIDATOR_H_ -#define SRC_VALIDATOR_VALIDATOR_H_ - -#include - -#include "src/diagnostic/diagnostic.h" - -namespace tint { - -class Program; - -// TODO(amaiorano): This class is deprecated. Delete after removing its usage in -// Dawn. -/// Determines if the program is complete and valid -class Validator { - public: - /// Runs the validator - /// @param program the program to validate - /// @returns true if the validation was successful - bool Validate(const Program* program) { - (void)program; - return true; - } - - /// @returns error messages from the validator - std::string error() { return {}; } - /// @returns true if an error was encountered - bool has_error() const { return false; } - - /// @returns the full list of diagnostic messages. - const diag::List& diagnostics() const { return diags_; } - - private: - diag::List diags_; -}; - -} // namespace tint - -#endif // SRC_VALIDATOR_VALIDATOR_H_