From 757d153d54fda786fdfd882ba6d8d5ee44efab5b Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Thu, 9 Apr 2020 17:18:40 +0000 Subject: [PATCH] Fix UBO/SSBO OOB in ComputeStorageBufferBarrierTests The test was failing on Swiftshader, likely because the allocations for the SSBO and the UBO where neighbors. The UBO test uses uvec4 instead of uint so it needs 4 times less invocations to perform the test. Bug: dawn:283 Change-Id: Id1952505763a0a3eb34718e000cb386e1faa4ade Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19082 Reviewed-by: Austin Eng Commit-Queue: Kai Ninomiya --- src/tests/end2end/ComputeStorageBufferBarrierTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/end2end/ComputeStorageBufferBarrierTests.cpp b/src/tests/end2end/ComputeStorageBufferBarrierTests.cpp index 5c8b2e3edf..31e66e2d5c 100644 --- a/src/tests/end2end/ComputeStorageBufferBarrierTests.cpp +++ b/src/tests/end2end/ComputeStorageBufferBarrierTests.cpp @@ -181,7 +181,7 @@ TEST_P(ComputeStorageBufferBarrierTests, UniformToStorageAddPingPong) { wgpu::ComputePassEncoder pass = encoder.BeginComputePass(); pass.SetPipeline(pipeline); pass.SetBindGroup(0, bindGroups[b]); - pass.Dispatch(kNumValues); + pass.Dispatch(kNumValues / 4); pass.EndPass(); }