From 79aee9c56d12e85bad0551ab6044a1a4b5bc67c0 Mon Sep 17 00:00:00 2001 From: Corentin Wallez Date: Tue, 16 Oct 2018 09:16:15 +0000 Subject: [PATCH] Suppress test failure on Vulkan BUG=dawn:16 Change-Id: I8d0ae82d379ff092e1d585f2b69dd6226aa55c39 Reviewed-on: https://dawn-review.googlesource.com/c/1820 Reviewed-by: Jiawei Shao Commit-Queue: Corentin Wallez --- src/tests/DawnTest.cpp | 8 ++++++++ src/tests/DawnTest.h | 7 ------- src/tests/end2end/TextureViewTests.cpp | 3 +++ 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/tests/DawnTest.cpp b/src/tests/DawnTest.cpp index a770b42cc1..ad88763214 100644 --- a/src/tests/DawnTest.cpp +++ b/src/tests/DawnTest.cpp @@ -96,6 +96,14 @@ namespace { DawnTest* test; size_t slot; }; + + constexpr uint32_t kVendorID_AMD = 0x1002; + constexpr uint32_t kVendorID_ARM = 0x13B5; + constexpr uint32_t kVendorID_ImgTec = 0x1010; + constexpr uint32_t kVendorID_Intel = 0x8086; + constexpr uint32_t kVendorID_Nvidia = 0x10DE; + constexpr uint32_t kVendorID_Qualcomm = 0x5143; + } // namespace DawnTest::DawnTest() = default; diff --git a/src/tests/DawnTest.h b/src/tests/DawnTest.h index a9f676f7db..1c681169b3 100644 --- a/src/tests/DawnTest.h +++ b/src/tests/DawnTest.h @@ -65,13 +65,6 @@ enum BackendType { }; std::ostream& operator<<(std::ostream& stream, BackendType backend); -constexpr uint32_t kVendorID_AMD = 0x1002; -constexpr uint32_t kVendorID_ARM = 0x13B5; -constexpr uint32_t kVendorID_ImgTec = 0x1010; -constexpr uint32_t kVendorID_Intel = 0x8086; -constexpr uint32_t kVendorID_Nvidia = 0x10DE; -constexpr uint32_t kVendorID_Qualcomm = 0x5143; - namespace utils { class BackendBinding; class TerribleCommandBuffer; diff --git a/src/tests/end2end/TextureViewTests.cpp b/src/tests/end2end/TextureViewTests.cpp index 860325ba32..d645e45b89 100644 --- a/src/tests/end2end/TextureViewTests.cpp +++ b/src/tests/end2end/TextureViewTests.cpp @@ -141,6 +141,9 @@ protected: // Test drawing a rect with a checkerboard 2D array texture. TEST_P(TextureViewTest, Default2DArrayTexture) { + // TODO(cwallez@chromium.org) understand what the issue is + DAWN_SKIP_TEST_IF(IsVulkan() && IsNvidia()); + constexpr uint32_t kLayers = 3; initTexture(kLayers);